[Bug other/51125] New: FAIL: g++.dg/tm/pr45940-3.C

[Bug other/51125] New: FAIL: g++.dg/tm/pr45940-3.C

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51125

             Bug #: 51125
           Summary: FAIL: g++.dg/tm/pr45940-3.C
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com


On Linux/x86-64, revision 181350 gave

FAIL: g++.dg/tm/pr45940-3.C -std=gnu++98 (internal compiler error)
FAIL: g++.dg/tm/pr45940-3.C -std=gnu++98 (test for excess errors)
FAIL: g++.dg/tm/pr45940-3.C -std=gnu++11 (internal compiler error)
FAIL: g++.dg/tm/pr45940-3.C -std=gnu++11 (test for excess errors)
FAIL: g++.dg/tm/pr45940-4.C -std=gnu++98 (internal compiler error)
FAIL: g++.dg/tm/pr45940-4.C -std=gnu++98 (test for excess errors)
FAIL: g++.dg/tm/pr45940-4.C -std=gnu++11 (internal compiler error)
FAIL: g++.dg/tm/pr45940-4.C -std=gnu++11 (test for excess errors)

[Bug other/51125] FAIL: g++.dg/tm/pr45940-3.C

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51125

--- Comment #1 from Uros Bizjak <ubizjak at gmail dot com> 2011-11-14 18:58:33 UTC ---
A gdb backtrace would certainly help.

[Bug other/51125] FAIL: g++.dg/tm/pr45940-3.C

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51125

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> 2011-11-14 19:41:12 UTC ---
(gdb) bt
#0  fancy_abort (file=0x103d0c0 "/export/gnu/import/git/gcc/gcc/gimplify.c", 
    line=468, function=0x103dfc3 "create_tmp_var")
    at /export/gnu/import/git/gcc/gcc/diagnostic.c:898
#1  0x00000000008e9c24 in create_tmp_var (type=<optimized out>, 
    prefix=<optimized out>) at /export/gnu/import/git/gcc/gcc/gimplify.c:468
#2  0x00000000008fc5ab in create_tmp_from_val (val=0x7ffff12c6528)
    at /export/gnu/import/git/gcc/gcc/gimplify.c:498
#3  lookup_tmp_var (is_formal=false, val=0x7ffff12c6528)
    at /export/gnu/import/git/gcc/gcc/gimplify.c:515
#4  internal_get_tmp_var (val=0x7ffff12c6528, pre_p=0x7fffffffde48, 
    post_p=<optimized out>, is_formal=false)
    at /export/gnu/import/git/gcc/gcc/gimplify.c:584
#5  0x00000000008ebe01 in gimplify_expr (expr_p=<optimized out>, 
    pre_p=<optimized out>, post_p=0x7fffffffdcc8, gimple_test_f=
    0x8c6c70 <is_gimple_addressable(tree_node*)>, fallback=3)
    at /export/gnu/import/git/gcc/gcc/gimplify.c:7728
#6  0x00000000008fca12 in gimplify_addr_expr (expr_p=0x7fffffffddb8, 
    pre_p=0x7fffffffde48, post_p=<optimized out>)
    at /export/gnu/import/git/gcc/gcc/gimplify.c:4914
#7  0x00000000008ed04b in gimplify_expr (expr_p=<optimized out>, 
    pre_p=<optimized out>, post_p=0x7fffffffdcc8, 
    gimple_test_f=0x8c6e90 <is_gimple_val(tree_node*)>, fallback=1)
    at /export/gnu/import/git/gcc/gcc/gimplify.c:6950
---Type <return> to continue, or q <return> to quit---
#8  0x00000000009023e1 in force_gimple_operand_1 (expr=0x7ffff12dd758, 
    stmts=0x7fffffffde48, gimple_test_f=0x8c6e90 <is_gimple_val(tree_node*)>, 
    var=0x0) at /export/gnu/import/git/gcc/gcc/gimplify.c:8385
#9  0x0000000000902583 in force_gimple_operand_gsi_1 (gsi=0x7fffffffdf30, 
    expr=<optimized out>, gimple_test_f=<optimized out>, var=<optimized out>, 
    before=true, m=GSI_SAME_STMT)
    at /export/gnu/import/git/gcc/gcc/gimplify.c:8425
#10 0x0000000000a4d5b9 in expand_assign_tm (region=0x17bfbd0, 
    gsi=0x7fffffffdf30) at /export/gnu/import/git/gcc/gcc/trans-mem.c:2173
#11 0x0000000000a52ebf in expand_block_tm (bb=<optimized out>, 
    region=0x17bfbd0) at /export/gnu/import/git/gcc/gcc/trans-mem.c:2324
#12 execute_tm_mark () at /export/gnu/import/git/gcc/gcc/trans-mem.c:2436
#13 0x000000000099ff78 in execute_one_pass (pass=0x1594120)
    at /export/gnu/import/git/gcc/gcc/passes.c:2074
#14 0x00000000009a02e5 in execute_pass_list (pass=0x1594120)
    at /export/gnu/import/git/gcc/gcc/passes.c:2129
#15 0x00000000009a02f7 in execute_pass_list (pass=0x1594180)
    at /export/gnu/import/git/gcc/gcc/passes.c:2130
#16 0x0000000000ab438e in tree_rest_of_compilation (fndecl=0x7ffff12bd000)
    at /export/gnu/import/git/gcc/gcc/tree-optimize.c:420
#17 0x0000000000797fea in cgraph_expand_function (node=0x7ffff12b8a20)
    at /export/gnu/import/git/gcc/gcc/cgraphunit.c:1819
#18 0x000000000079a217 in cgraph_output_in_order ()
---Type <return> to continue, or q <return> to quit---
    at /export/gnu/import/git/gcc/gcc/cgraphunit.c:1984
#19 cgraph_optimize () at /export/gnu/import/git/gcc/gcc/cgraphunit.c:2194
#20 0x000000000079a4fa in cgraph_finalize_compilation_unit ()
    at /export/gnu/import/git/gcc/gcc/cgraphunit.c:1327
#21 0x00000000005cce9b in cp_write_global_declarations ()
    at /export/gnu/import/git/gcc/gcc/cp/decl2.c:4050
#22 0x0000000000a47c64 in compile_file ()
    at /export/gnu/import/git/gcc/gcc/toplev.c:581
#23 do_compile () at /export/gnu/import/git/gcc/gcc/toplev.c:1931
#24 toplev_main (argc=16, argv=0x7fffffffe258)
    at /export/gnu/import/git/gcc/gcc/toplev.c:2007
#25 0x0000003682e2165d in __libc_start_main () from /lib64/libc.so.6
#26 0x00000000004f0e09 in _start ()
(gdb) call debug_tree (type)
 <record_type 0x7ffff12b09d8 shared_count sizes-gimplified addressable
needs-constructing type_1 type_4 type_5 BLK
    size <integer_cst 0x7ffff1141480 type <integer_type 0x7ffff113e0a8
bitsizetype> constant 128>
    unit size <integer_cst 0x7ffff11414a0 type <integer_type 0x7ffff113e000
sizetype> constant 16>
    align 64 symtab 0 alias set -1 canonical type 0x7ffff12b09d8
    fields <field_decl 0x7ffff12a0a18 pi_
        type <pointer_type 0x7ffff12a4e70 type <record_type 0x7ffff12a4bd0
sp_counted_base>
            sizes-gimplified public unsigned DI
            size <integer_cst 0x7ffff1125f40 constant 64>
            unit size <integer_cst 0x7ffff1125f60 constant 8>
            align 64 symtab 0 alias set -1 canonical type 0x7ffff12a4e70>
        used private unsigned nonlocal decl_3 DI file
/export/gnu/import/git/gcc/gcc/testsuite/g++.dg/tm/pr45940-3.C line 45 col 23
size <integer_cst 0x7ffff1125f40 64> unit size <integer_cst 0x7ffff1125f60 8>
        align 64 offset_align 128
        offset <integer_cst 0x7ffff1125f80 constant 0>
        bit offset <integer_cst 0x7ffff1125fe0 constant 0> context <record_type
0x7ffff12b09d8 shared_count>
        chain <field_decl 0x7ffff12a0ab0 j type <integer_type 0x7ffff113e5e8
int>
            used nonlocal decl_3 SI file
/export/gnu/import/git/gcc/gcc/testsuite/g++.dg/tm/pr45940-3.C line 47 col 9
            size <integer_cst 0x7ffff11412c0 constant 32>
            unit size <integer_cst 0x7ffff11412e0 constant 4>
            align 32 offset_align 128 offset <integer_cst 0x7ffff1125f80 0> bit
offset <integer_cst 0x7ffff1125f40 64> context <record_type 0x7ffff12b09d8
shared_count> chain <type_decl 0x7ffff129ef18 shared_count>>> context
<translation_unit_decl 0x7ffff113b170 D.1>
    full-name "class shared_count"
    needs-constructor needs-destructor X() X(constX&) this=(X&) n_parents=0
use_template=0 interface-unknown
    pointer_to_this <pointer_type 0x7ffff12b0c78> reference_to_this
<reference_type 0x7ffff12be0a8> chain <type_decl 0x7ffff129ee60 shared_count>>
(gdb)

[Bug other/51125] FAIL: g++.dg/tm/pr45940-3.C

[patrick.marlier at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51125

Patrick Marlier <patrick.marlier at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.marlier at gmail
                   |                            |dot com

--- Comment #3 from Patrick Marlier <patrick.marlier at gmail dot com> 2011-11-17 02:34:03 UTC ---
Probably the same as http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51130 (which
include reduced testcase).

Patrick Marlier.

[Bug other/51125] FAIL: g++.dg/tm/pr45940-3.C

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51125

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011-11-18
                 CC|                            |aldyh at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #4 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2011-11-18 21:12:01 UTC ---
Michael.

This regression was caused by the following patch.  Perhaps the reason nobody
caught it was because it came 5 hours after the transactional-memory branch was
merged, perhaps too close for everyone to have re-tested their patches.

Do you mind taking a look at this?

r181172 | matz | 2011-11-08 10:47:16 -0600 (Tue, 08 Nov 2011) | 44 lines

        * gengtype.c (write_field_root): Avoid out-of-scope access of newv.

        * tree-stdarg.c (execute_optimize_stdarg): Accept clobbers.
        * tree.h (TREE_CLOBBER_P): New macro.
        * gimple.h (gimple_clobber_p): New inline function.
        * gimplify.c (gimplify_bind_expr): Add clobbers for all variables
        that go out of scope and live in memory.
        * tree-ssa-operands.c (get_expr_operands): Transfer volatility also
        for constructors.
        * cfgexpand.c (decl_to_stack_part): New static variable.
        (add_stack_var): Allocate it, and remember mapping.
        (fini_vars_expansion): Deallocate it.
        (stack_var_conflict_p): Add early outs.
        (visit_op, visit_conflict, add_scope_conflicts_1,
        add_scope_conflicts): New static functions.
        (expand_used_vars_for_block): Don't call add_stack_var_conflict, tidy.
        (expand_used_vars): Add scope conflicts.
        (expand_gimple_stmt_1): Expand clobbers to nothing.
        (expand_debug_expr): Ditto.

[Bug other/51125] FAIL: g++.dg/tm/pr45940-3.C

[patrick.marlier at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51125

--- Comment #5 from Patrick Marlier <patrick.marlier at gmail dot com> 2011-11-19 17:42:20 UTC ---
** NOT RELATED TO BUG **
In http://gcc.gnu.org/ml/gcc-patches/2011-11/msg00969.html, the patch shows
changes to tree-ssa-reassoc.c but not committed or part of Changelog.
But the problem is definitely not here.

Patrick.

Index: tree-ssa-reassoc.c
===================================================================
--- tree-ssa-reassoc.c.orig    2011-11-07 15:56:25.000000000 +0100
+++ tree-ssa-reassoc.c    2011-11-07 16:12:35.000000000 +0100
@@ -2869,6 +2869,12 @@  reassociate_bb (basic_block bb)
       rhs1 = gimple_assign_rhs1 (stmt);
       rhs2 = gimple_assign_rhs2 (stmt);

+      /* We don't want to destroy reduction like patterns
+         with reassociation, simply don't start at such
+         statements.  */
+      if (is_phi_for_stmt (stmt, rhs1) || is_phi_for_stmt (stmt, rhs2))
+        continue;
+
       /* For non-bit or min/max operations we can't associate
          all types.  Verify that here.  */
       if (rhs_code != BIT_IOR_EXPR

[Bug other/51125] FAIL: g++.dg/tm/pr45940-3.C

[matz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51125

--- Comment #6 from Michael Matz <matz at gcc dot gnu.org> 2011-11-21 13:28:08 UTC ---
Yes, the patch submission to the mailing list was incorrect and contained a
non-intended change.  The patch as committed and ChangeLogged is correct.
Aldy: yes, I'm taking a peek.

[Bug other/51125] FAIL: g++.dg/tm/pr45940-3.C

[matz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51125

Michael Matz <matz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zsojka at seznam dot cz

--- Comment #7 from Michael Matz <matz at gcc dot gnu.org> 2011-11-21 16:25:34 UTC ---
*** Bug 51130 has been marked as a duplicate of this bug. ***

[Bug other/51125] FAIL: g++.dg/tm/pr45940-3.C

[matz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51125

--- Comment #8 from Michael Matz <matz at gcc dot gnu.org> 2011-11-22 14:56:03 UTC ---
Author: matz
Date: Tue Nov 22 14:55:58 2011
New Revision: 181619

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181619
Log:
    PR other/51125
    * trans-mem.c (expand_block_tm): Ignore clobbers.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/trans-mem.c

[Bug other/51125] FAIL: g++.dg/tm/pr45940-3.C

[matz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51125

Michael Matz <matz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Michael Matz <matz at gcc dot gnu.org> 2011-11-22 14:57:54 UTC ---
Fixed.  (As per http://gcc.gnu.org/ml/gcc-patches/2011-11/msg02169.html an
optimization opportunity remains)