public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/51134] [4.7 Regression] FAIL: gfortran.fortran-torture/execute/arrayarg.f90
Date: Tue, 15 Nov 2011 14:01:00 -0000	[thread overview]
Message-ID: <bug-51134-4-PUJLjVJtxT@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-51134-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51134

--- Comment #4 from Jan Hubicka <hubicka at ucw dot cz> 2011-11-15 13:28:42 UTC ---
Hi,
the bug is loopy epilogue not being used because promoted value is not
availbale. The non-loopy epilogue does not expect alignments
greater than 16.

I am testing the following patch.
I think we might still have bugs for blocks >8 && <16. Will try to produce
testcase.

Honza

Index: config/i386/i386.c
===================================================================
--- config/i386/i386.c    (revision 181357)
+++ config/i386/i386.c    (working copy)
@@ -23073,13 +23073,13 @@ ix86_expand_setmem (rtx dst, rtx count_e
       rtx tmp;
       if (align_unknown && unroll_factor > 1
       && epilogue_size_needed >= GET_MODE_SIZE (move_mode)
-      && vec_promoted_val)
+      && (vec_promoted_val || gpr_promoted_val))
     {
       /* Reduce epilogue's size by creating not-unrolled loop.  If we won't
          do this, we can have very big epilogue - when alignment is statically
          unknown we'll have the epilogue byte by byte which may be very slow. 
*/
       loop_iter = expand_set_or_movmem_via_loop_with_iter (dst, NULL, destreg,
-          NULL, vec_promoted_val, count_exp,
+          NULL, vec_promoted_val ? vec_promoted_val : gpr_promoted_val,
count_exp,
           loop_iter, move_mode, 1,
           expected_size, false);
       dst = change_address (dst, BLKmode, destreg);


  parent reply	other threads:[~2011-11-15 13:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14 23:51 [Bug target/51134] New: " hjl.tools at gmail dot com
2011-11-15  4:15 ` [Bug target/51134] " hjl.tools at gmail dot com
2011-11-15  5:21 ` hjl.tools at gmail dot com
2011-11-15 12:40 ` hubicka at ucw dot cz
2011-11-15 14:01 ` hubicka at ucw dot cz [this message]
2011-11-15 16:44 ` hjl.tools at gmail dot com
2011-11-15 19:57 ` [Bug target/51134] [4.7 Regression] x86 memset/memcpy expansion is broken hjl.tools at gmail dot com
2011-11-16  5:15 ` hjl.tools at gmail dot com
2011-11-18  1:17 ` hubicka at gcc dot gnu.org
2011-11-18  2:23 ` hubicka at gcc dot gnu.org
2011-11-22  5:31 ` hjl.tools at gmail dot com
2011-11-22 14:19 ` michael.v.zolotukhin at gmail dot com
2011-11-22 16:43 ` hjl.tools at gmail dot com
2011-11-22 17:23 ` michael.v.zolotukhin at gmail dot com
2011-11-24 22:21 ` hjl at gcc dot gnu.org
2011-11-25  2:03 ` hjl.tools at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-51134-4-PUJLjVJtxT@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).