[Bug bootstrap/51144] New: r181279

[Bug bootstrap/51144] New: r181279

[krebbel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51144

             Bug #: 51144
           Summary: r181279
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: krebbel@gcc.gnu.org


With revision 181279 GCC stopped bootstrapping on s390 (31 bit). 

genmddeps complains about a missing [ altough it is there. The s390.md file
didn't change in that revision.

build/genmddeps /build/regtest/gcc-bisect/gcc/config/s390/s390.md > tmp-mddeps
/build/regtest/gcc-bisect/gcc/config/s390/s390.md:60: expected character `[',
found ` '
/build/regtest/gcc-bisect/gcc/config/s390/s390.md:60: following context is `['

s390.md:

60: (define_c_enum "unspec" [

Perhaps a miscompilation of genmddeps?!

[Bug bootstrap/51144] r181279

[krebbel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51144

Andreas Krebbel <krebbel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |s390-ibm-linux
           Priority|P3                          |P1
           Keywords|                            |wrong-code
                 CC|                            |jason at gcc dot gnu.org
               Host|                            |s390-ibm-linux
              Build|                            |s390-ibm-linux

[Bug middle-end/51144] r181279

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51144

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build
          Component|bootstrap                   |middle-end
   Target Milestone|---                         |4.7.0

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-11-15 19:33:18 UTC ---
IA64-hpux fails the same way according to
http://gcc.gnu.org/ml/gcc-patches/2011-11/msg01742.html .

[Bug middle-end/51144] r181279 possibly miscompilation of genmddeps

[sje at cup dot hp.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51144

Steve Ellcey <sje at cup dot hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|s390-ibm-linux              |s390-ibm-linux,ia64-hp-hpux
                   |                            |11.23
                 CC|                            |jimis at gmx dot net, sje
                   |                            |at cup dot hp.com
               Host|s390-ibm-linux              |s390-ibm-linux,ia64-hp-hpux
                   |                            |11.23
              Build|s390-ibm-linux              |s390-ibm-linux,ia64-hp-hpux
                   |                            |11.23

--- Comment #2 from Steve Ellcey <sje at cup dot hp.com> 2011-11-16 00:34:16 UTC ---
Yes, this started failing on 181279 for ia64-hp-hpux11.23 as well.
Adding Dimitrios to CC list.

[Bug middle-end/51144] r181279 possibly miscompilation of genmddeps

[sje at cup dot hp.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51144

--- Comment #3 from Steve Ellcey <sje at cup dot hp.com> 2011-11-16 00:43:15 UTC ---
I think this is a big-endian bug in fprint_whex, etc.  IA64 HP-UX is
big endian and I think s390-ibm-linux is too.

[Bug middle-end/51144] r181279 possibly miscompilation of genmddeps

[sje at cup dot hp.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51144

Steve Ellcey <sje at cup dot hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011-11-16
     Ever Confirmed|0                           |1

--- Comment #4 from Steve Ellcey <sje at cup dot hp.com> 2011-11-16 19:19:17 UTC ---
It looks like fprint_w is broken for systems where HOST_WIDE_INT is 'long long'
and that type is longer then type 'long'.

Inside fprint_w we call sprint_ul_rev and that function is defined to take a 
'unsigned long' argument instead of a 'long long' argument which can cause a
truncation of the incoming value that we are trying to print.

I am testing this patch to see if it fixes all the problems.

Index: ../src/trunk/gcc/final.c
===================================================================
--- ../src/trunk/gcc/final.c    (revision 181279)
+++ ../src/trunk/gcc/final.c    (working copy)
@@ -3585,7 +3585,7 @@ output_addr_const (FILE *file, rtx x)
       break;

     case CONST_INT:
-      fprint_w (file, INTVAL (x));
+      fprintf (file, HOST_WIDE_INT_PRINT_DEC, INTVAL (x));
       break;

     case CONST:

[Bug middle-end/51144] r181279 possibly miscompilation of genmddeps

[sje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51144

--- Comment #5 from Steve Ellcey <sje at gcc dot gnu.org> 2011-11-17 21:22:15 UTC ---
Author: sje
Date: Thu Nov 17 21:22:11 2011
New Revision: 181457

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181457
Log:
2011-11-17  Steve Ellcey  <sje@cup.hp.com>

    PR middle-end/51144
    * output.h (fprint_w): Remove.
    * final.c (fprint_w): Remove.
    (output_addr_const): Change fprint_w back to fprintf.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/final.c
    trunk/gcc/output.h

[Bug middle-end/51144] r181279 possibly miscompilation of genmddeps

[krebbel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51144

--- Comment #6 from Andreas Krebbel <krebbel at gcc dot gnu.org> 2011-11-21 10:10:31 UTC ---
(In reply to comment #5)
>     PR middle-end/51144
>     * output.h (fprint_w): Remove.
>     * final.c (fprint_w): Remove.
>     (output_addr_const): Change fprint_w back to fprintf.


This also fixed the s390 bootstrap problem:
http://gcc.gnu.org/ml/gcc-testresults/2011-11/msg01784.html

Thanks!

[Bug middle-end/51144] r181279 possibly miscompilation of genmddeps

[krebbel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51144

Andreas Krebbel <krebbel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Andreas Krebbel <krebbel at gcc dot gnu.org> 2011-12-06 12:29:55 UTC ---
Fixed per above comment.