* [Bug c++/51196] FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C
2011-11-17 17:06 [Bug c++/51196] New: FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C Greta.Yorsh at arm dot com
@ 2011-11-17 17:41 ` paolo.carlini at oracle dot com
2011-11-17 17:52 ` jason at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: paolo.carlini at oracle dot com @ 2011-11-17 17:41 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51196
--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-17 17:33:43 UTC ---
That's a pity, but personally frankly I don't think I will be able to seriously
debug for this target in the near future. Or maybe Jason has something to
suggest. Otherwise I propose to xfail on arm, for 4.7.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/51196] FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C
2011-11-17 17:06 [Bug c++/51196] New: FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C Greta.Yorsh at arm dot com
2011-11-17 17:41 ` [Bug c++/51196] " paolo.carlini at oracle dot com
@ 2011-11-17 17:52 ` jason at gcc dot gnu.org
2011-11-17 18:38 ` paolo.carlini at oracle dot com
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: jason at gcc dot gnu.org @ 2011-11-17 17:52 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51196
Jason Merrill <jason at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jason at gcc dot gnu.org
--- Comment #2 from Jason Merrill <jason at gcc dot gnu.org> 2011-11-17 17:44:54 UTC ---
(In reply to comment #1)
> I don't think I will be able to seriously
> debug for this target in the near future.
It's easy to build a cross-compiler for compile-time tests like this. Just
.../configure --target arm-none-eabi --enable-languages=c++ && make all-gcc
should get as far as building cc1plus, which is all you need to debug most PRs.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/51196] FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C
2011-11-17 17:06 [Bug c++/51196] New: FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C Greta.Yorsh at arm dot com
2011-11-17 17:41 ` [Bug c++/51196] " paolo.carlini at oracle dot com
2011-11-17 17:52 ` jason at gcc dot gnu.org
@ 2011-11-17 18:38 ` paolo.carlini at oracle dot com
2011-11-21 16:25 ` paolo.carlini at oracle dot com
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: paolo.carlini at oracle dot com @ 2011-11-17 18:38 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51196
--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-17 18:14:16 UTC ---
I'll see what I can do... At the moment really I have no idea why for this
target only we have a different behavior.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/51196] FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C
2011-11-17 17:06 [Bug c++/51196] New: FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C Greta.Yorsh at arm dot com
` (2 preceding siblings ...)
2011-11-17 18:38 ` paolo.carlini at oracle dot com
@ 2011-11-21 16:25 ` paolo.carlini at oracle dot com
2011-11-21 17:31 ` paolo.carlini at oracle dot com
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: paolo.carlini at oracle dot com @ 2011-11-21 16:25 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51196
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|Greta.Yorsh at arm dot com |
--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-21 15:53:55 UTC ---
Unexpectedly ;) I'm making progress debugging this: what happens is that, for
arm, in cp_build_binary_op, case EQ_EXPR (this is for 'if (pmf == 0)') here:
if (TARGET_PTRMEMFUNC_VBIT_LOCATION
== ptrmemfunc_vbit_in_delta)
{
tree pfn0 = pfn_from_ptrmemfunc (op0);
tree delta0 = delta_from_ptrmemfunc (op0);
tree e1 = cp_build_binary_op (location,
EQ_EXPR,
pfn0,
build_zero_cst (TREE_TYPE (pfn0)),
complain);
tree e2 = cp_build_binary_op (location,
BIT_AND_EXPR,
delta0,
integer_one_node,
complain);
e2 = cp_build_binary_op (location,
EQ_EXPR, e2, integer_zero_node,
complain);
op0 = cp_build_binary_op (location,
TRUTH_ANDIF_EXPR, e1, e2,
complain);
op1 = cp_convert (TREE_TYPE (op0), integer_one_node);
}
else
{
op0 = build_ptrmemfunc_access_expr (op0, pfn_identifier);
op1 = cp_convert (TREE_TYPE (op0), op1);
}
the condition is true, thus we don't call cp_convert with op1, which is
integer_zero_node here, instead we pass integer_one_node to cp_convert and the
warning down in cp_convert_to_pointer cannot possibly trigger (actually, for
arm we don't even reach cp_convert_to_pointer)
Thus, an idea for fixing the problem would be just warn right here for arm and
similar targets, because here we know that op1 is indeed integer_zero_node (and
that TYPE_PTRMEMFUNC_P (type0) is true of course)
Jason, can you imagine something neater?
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/51196] FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C
2011-11-17 17:06 [Bug c++/51196] New: FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C Greta.Yorsh at arm dot com
` (3 preceding siblings ...)
2011-11-21 16:25 ` paolo.carlini at oracle dot com
@ 2011-11-21 17:31 ` paolo.carlini at oracle dot com
2011-11-22 11:33 ` Greta.Yorsh at arm dot com
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: paolo.carlini at oracle dot com @ 2011-11-21 17:31 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51196
--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-21 17:04:47 UTC ---
Created attachment 25873
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=25873
Sanity checked on x86_64-linux and lightly tested arm-none-eabi
In practice, this works for me. Maybe Greta can test it more carefully.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/51196] FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C
2011-11-17 17:06 [Bug c++/51196] New: FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C Greta.Yorsh at arm dot com
` (4 preceding siblings ...)
2011-11-21 17:31 ` paolo.carlini at oracle dot com
@ 2011-11-22 11:33 ` Greta.Yorsh at arm dot com
2011-11-22 15:21 ` paolo at gcc dot gnu.org
2011-11-22 15:25 ` paolo.carlini at oracle dot com
7 siblings, 0 replies; 9+ messages in thread
From: Greta.Yorsh at arm dot com @ 2011-11-22 11:33 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51196
--- Comment #6 from Greta Yorsh <Greta.Yorsh at arm dot com> 2011-11-22 10:56:41 UTC ---
Thanks for fixing it, Paolo. Tested as follows.
Successful cross-build of the patch version for arm-none-eabi target,
configured as before. No regression on qemu for check-g++. The tests for
g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C all pass.
Can you see the patch committed to trunk, please?
Thank you,
Greta
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/51196] FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C
2011-11-17 17:06 [Bug c++/51196] New: FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C Greta.Yorsh at arm dot com
` (5 preceding siblings ...)
2011-11-22 11:33 ` Greta.Yorsh at arm dot com
@ 2011-11-22 15:21 ` paolo at gcc dot gnu.org
2011-11-22 15:25 ` paolo.carlini at oracle dot com
7 siblings, 0 replies; 9+ messages in thread
From: paolo at gcc dot gnu.org @ 2011-11-22 15:21 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51196
--- Comment #7 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-11-22 15:04:33 UTC ---
Author: paolo
Date: Tue Nov 22 15:04:27 2011
New Revision: 181620
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181620
Log:
2011-11-22 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/51196
* typeck.c (cp_build_binary_op, [case EQ_EXPR]): For targets having
TARGET_PTRMEMFUNC_VBIT_LOCATION == ptrmemfunc_vbit_in_delta, do here
the -Wzero-as-null-pointer-constant warning for pmf == 0.
Modified:
trunk/gcc/cp/ChangeLog
trunk/gcc/cp/typeck.c
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c++/51196] FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C
2011-11-17 17:06 [Bug c++/51196] New: FAIL: g++.dg/cpp0x/Wzero-as-null-pointer-constant-1.C Greta.Yorsh at arm dot com
` (6 preceding siblings ...)
2011-11-22 15:21 ` paolo at gcc dot gnu.org
@ 2011-11-22 15:25 ` paolo.carlini at oracle dot com
7 siblings, 0 replies; 9+ messages in thread
From: paolo.carlini at oracle dot com @ 2011-11-22 15:25 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51196
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.7.0
--- Comment #8 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-22 15:06:34 UTC ---
Thanks a lot Greta for testing, patch applied!
^ permalink raw reply [flat|nested] 9+ messages in thread