public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/51209] New: The template _M_find_node in hashtable.h has a bad return value
@ 2011-11-18 15:32 hartmut.brandt at dlr dot de
2011-11-18 15:53 ` [Bug libstdc++/51209] " paolo.carlini at oracle dot com
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: hartmut.brandt at dlr dot de @ 2011-11-18 15:32 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51209
Bug #: 51209
Summary: The template _M_find_node in hashtable.h has a bad
return value
Classification: Unclassified
Product: gcc
Version: 4.7.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: hartmut.brandt@dlr.de
The function starting on line 872 of bits/hashtable.c should return a pointer
but contains a 'return false;' statement. Replacing the false with a nullptr
seems the correct solution.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libstdc++/51209] The template _M_find_node in hashtable.h has a bad return value
2011-11-18 15:32 [Bug libstdc++/51209] New: The template _M_find_node in hashtable.h has a bad return value hartmut.brandt at dlr dot de
@ 2011-11-18 15:53 ` paolo.carlini at oracle dot com
2011-11-18 16:16 ` paolo at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: paolo.carlini at oracle dot com @ 2011-11-18 15:53 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51209
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2011-11-18
CC|hartmut.brandt at dlr dot |
|de |
Target Milestone|--- |4.7.0
Ever Confirmed|0 |1
--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-18 15:38:51 UTC ---
Eh, this nit is pretty old, I'll fix it momentarily, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libstdc++/51209] The template _M_find_node in hashtable.h has a bad return value
2011-11-18 15:32 [Bug libstdc++/51209] New: The template _M_find_node in hashtable.h has a bad return value hartmut.brandt at dlr dot de
2011-11-18 15:53 ` [Bug libstdc++/51209] " paolo.carlini at oracle dot com
@ 2011-11-18 16:16 ` paolo at gcc dot gnu.org
2011-11-18 16:33 ` paolo.carlini at oracle dot com
2011-11-18 16:44 ` hartmut.brandt at dlr dot de
3 siblings, 0 replies; 5+ messages in thread
From: paolo at gcc dot gnu.org @ 2011-11-18 16:16 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51209
--- Comment #2 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-11-18 16:09:36 UTC ---
Author: paolo
Date: Fri Nov 18 16:09:29 2011
New Revision: 181480
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181480
Log:
2011-11-18 Harti Brandt <hartmut.brandt@dlr.de>
PR libstdc++/51209
* include/bits/hashtable.h (_Hashtable<>::_M_find_node): Return
nullptr when no node is found.
* include/tr1/hashtable.h (_Hashtable<>::_M_find_node): Return
zero when no node is found.
Modified:
trunk/libstdc++-v3/ChangeLog
trunk/libstdc++-v3/include/bits/hashtable.h
trunk/libstdc++-v3/include/tr1/hashtable.h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libstdc++/51209] The template _M_find_node in hashtable.h has a bad return value
2011-11-18 15:32 [Bug libstdc++/51209] New: The template _M_find_node in hashtable.h has a bad return value hartmut.brandt at dlr dot de
2011-11-18 15:53 ` [Bug libstdc++/51209] " paolo.carlini at oracle dot com
2011-11-18 16:16 ` paolo at gcc dot gnu.org
@ 2011-11-18 16:33 ` paolo.carlini at oracle dot com
2011-11-18 16:44 ` hartmut.brandt at dlr dot de
3 siblings, 0 replies; 5+ messages in thread
From: paolo.carlini at oracle dot com @ 2011-11-18 16:33 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51209
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-18 16:11:43 UTC ---
Done.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libstdc++/51209] The template _M_find_node in hashtable.h has a bad return value
2011-11-18 15:32 [Bug libstdc++/51209] New: The template _M_find_node in hashtable.h has a bad return value hartmut.brandt at dlr dot de
` (2 preceding siblings ...)
2011-11-18 16:33 ` paolo.carlini at oracle dot com
@ 2011-11-18 16:44 ` hartmut.brandt at dlr dot de
3 siblings, 0 replies; 5+ messages in thread
From: hartmut.brandt at dlr dot de @ 2011-11-18 16:44 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51209
--- Comment #4 from Harti Brandt <hartmut.brandt at dlr dot de> 2011-11-18 16:16:31 UTC ---
Thanks a lot,
harti
________________________________________
From: paolo.carlini at oracle dot com [gcc-bugzilla@gcc.gnu.org]
Sent: Friday, November 18, 2011 5:11 PM
To: Brandt, Hartmut
Subject: [Bug libstdc++/51209] The template _M_find_node in hashtable.h has a
bad return value
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51209
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-18
16:11:43 UTC ---
Done.
--
Configure bugmail: http://gcc.gnu.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You reported the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-11-18 16:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-18 15:32 [Bug libstdc++/51209] New: The template _M_find_node in hashtable.h has a bad return value hartmut.brandt at dlr dot de
2011-11-18 15:53 ` [Bug libstdc++/51209] " paolo.carlini at oracle dot com
2011-11-18 16:16 ` paolo at gcc dot gnu.org
2011-11-18 16:33 ` paolo.carlini at oracle dot com
2011-11-18 16:44 ` hartmut.brandt at dlr dot de
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).