public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/51218] [4.6/4.7 Regression] Potential optimization bug due to implicit_pure?
Date: Mon, 21 Nov 2011 21:25:00 -0000 [thread overview]
Message-ID: <bug-51218-4-4d4ql4Yhwh@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-51218-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51218
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.7.0 |4.6.3
--- Comment #19 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-11-21 20:36:03 UTC ---
(In reply to comment #18)
> > @@ -3257,6 +3255,7 @@ pure_subroutine (gfc_code *c, gfc_symbol *sym)
> > + gfc_current_ns->proc_name->attr.implicit_pure = 0;
>
> Harald's example has function calls not subroutines. I would
> expect that you need to set this in pure_function as well.
Hmm, I had the feeling that such a check is already there, but I have not
really audited resolve.c
> Also, does this type of change inhibit reason why
> implicit_pure was added in the first place?
One probably should add a check whether the called procedure has
attr.implicit_pure has set - and only is not mark the current namespace as
impure. Then, I don't think it will inhibit the reason for the initial change.
And even if it does, having correct code is more important. We might be able to
mark more code as implicit none - but first we need to make sure that code
which is effectively not pure is also not marked as implicit_pure.
next prev parent reply other threads:[~2011-11-21 20:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 23:14 [Bug fortran/51218] New: [4.7 Regression] Potential optimization bug anlauf at gmx dot de
2011-11-18 23:24 ` [Bug fortran/51218] " anlauf at gmx dot de
2011-11-19 0:05 ` dominiq at lps dot ens.fr
2011-11-19 0:41 ` dominiq at lps dot ens.fr
2011-11-19 2:06 ` kargl at gcc dot gnu.org
2011-11-19 5:39 ` sgk at troutmask dot apl.washington.edu
2011-11-19 9:28 ` anlauf at gmx dot de
2011-11-19 9:29 ` tkoenig at gcc dot gnu.org
2011-11-19 10:35 ` [Bug fortran/51218] [4.7 Regression] Potential optimization bug due to implicit_pure? anlauf at gmx dot de
2011-11-19 10:58 ` burnus at gcc dot gnu.org
2011-11-19 11:31 ` anlauf at gmx dot de
2011-11-19 11:44 ` tkoenig at netcologne dot de
2011-11-19 12:11 ` anlauf at gmx dot de
2011-11-19 16:34 ` sgk at troutmask dot apl.washington.edu
2011-11-19 16:48 ` sgk at troutmask dot apl.washington.edu
2011-11-19 17:44 ` kargl at gcc dot gnu.org
2011-11-21 9:05 ` burnus at gcc dot gnu.org
2011-11-21 19:48 ` anlauf at gmx dot de
2011-11-21 20:40 ` burnus at gcc dot gnu.org
2011-11-21 21:08 ` sgk at troutmask dot apl.washington.edu
2011-11-21 21:25 ` burnus at gcc dot gnu.org [this message]
2011-11-22 23:11 ` [Bug fortran/51218] [4.6/4.7 " anlauf at gmx dot de
2011-11-24 18:31 ` burnus at gcc dot gnu.org
2011-11-24 21:54 ` burnus at gcc dot gnu.org
2011-11-24 21:57 ` burnus at gcc dot gnu.org
2011-11-25 17:42 ` tkoenig at netcologne dot de
2011-11-25 18:49 ` burnus at gcc dot gnu.org
2011-11-26 12:15 ` tkoenig at netcologne dot de
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-51218-4-4d4ql4Yhwh@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).