[Bug ada/51307] New: [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"

[Bug ada/51307] New: [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51307

             Bug #: 51307
           Summary: [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada"
                    not declared in "OS_Constants"
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: danglin@gcc.gnu.org
              Host: hppa2.0w-hp-hpux11.11
            Target: hppa2.0w-hp-hpux11.11
             Build: hppa2.0w-hp-hpux11.11


/test/gnu/gcc/objdir/./gcc/xgcc -B/test/gnu/gcc/objdir/./gcc/
-B/opt/gnu/gcc/gcc
-4.7/hppa2.0w-hp-hpux11.11/bin/
-B/opt/gnu/gcc/gcc-4.7/hppa2.0w-hp-hpux11.11/lib
/ -isystem /opt/gnu/gcc/gcc-4.7/hppa2.0w-hp-hpux11.11/include -isystem
/opt/gnu/
gcc/gcc-4.7/hppa2.0w-hp-hpux11.11/sys-include    -c -g -O2  -fPIC  -W -Wall
-gna
tpg -nostdinc   s-taprop.adb -o s-taprop.o
s-taprop.adb:53:12: warning: no entities of "Os_Constants" are referenced
s-taprop.adb:65:04: warning: no entities of "OSC" are referenced
s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"
make[7]: *** [s-taprop.o] Error 1
make[7]: Leaving directory `/test/gnu/gcc/objdir/gcc/ada/rts'
make[6]: *** [gnatlib] Error 2
make[6]: Leaving directory `/test/gnu/gcc/objdir/gcc/ada'
make[5]: *** [gnatlib-shared-default] Error 2
make[5]: Leaving directory `/test/gnu/gcc/objdir/gcc/ada'
make[4]: *** [gnatlib-shared-dual] Error 2
make[4]: Leaving directory `/test/gnu/gcc/objdir/gcc/ada'
make[3]: *** [gnatlib-shared] Error 2
make[3]: Leaving directory `/test/gnu/gcc/objdir/gcc/ada'

-bash-3.2$ ./xgcc -B./ -v
Reading specs from ./specs
COLLECT_GCC=./xgcc
COLLECT_LTO_WRAPPER=./lto-wrapper
Target: hppa2.0w-hp-hpux11.11
Configured with: ../gcc/configure --with-gnu-as --with-as=/opt/gnu/bin/as
--enable-shared --with-local-prefix=/opt/gnu --prefix=/opt/gnu/gcc/gcc-4.7
--with-gmp=/opt/gnu/gcc/gmp --enable-threads=posix --enable-debug=no
--disable-nls --disable-lto --without-cloog --without-ppl
--enable-languages=c,c++,objc,fortran,java,ada,obj-c++
Thread model: posix
gcc version 4.7.0 20111125 (experimental) [trunk revision 181706] (GCC)

[Bug ada/51307] [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51307

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2011-11-26
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org
     Ever Confirmed|0                           |1

--- Comment #1 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-11-26 23:40:37 UTC ---
Probably a missing CLOCK_REALTIME on the system (11.31 apparently has it).  You
need to add something to the Threads support section of s-oscons-tmplt.c.

[Bug ada/51307] [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51307

--- Comment #2 from dave.anglin at bell dot net 2011-11-27 21:18:46 UTC ---
On 26-Nov-11, at 6:40 PM, ebotcazou at gcc dot gnu.org wrote:

> Probably a missing CLOCK_REALTIME on the system (11.31 apparently  
> has it).  You
> need to add something to the Threads support section of s-oscons- 
> tmplt.c.


System seems to have CLOCK_REALTIME.  Even HP-UX 10.20 has it :

typedef enum __clockid_t {
         CLOCK_INVALID = 0,
         CLOCK_REALTIME = 1,     /* the system-wide "wall clock" */
         CLOCK_VIRTUAL = 2,      /* the per-process user execution  
clock */
         CLOCK_PROFILE = 4,      /* the per-process execution clock */
         RTTIMER0 = 8,
         RTTIMER1 = 16
} clockid_t;

--
John David Anglin    dave.anglin@bell.net

[Bug ada/51307] [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51307

--- Comment #3 from dave.anglin at bell dot net 2011-11-27 21:30:07 UTC ---
On 27-Nov-11, at 4:18 PM, John David Anglin wrote:

> typedef enum __clockid_t {
>        CLOCK_INVALID = 0,
>        CLOCK_REALTIME = 1,     /* the system-wide "wall clock" */
>        CLOCK_VIRTUAL = 2,      /* the per-process user execution  
> clock */
>        CLOCK_PROFILE = 4,      /* the per-process execution clock */
>        RTTIMER0 = 8,
>        RTTIMER1 = 16
> } clockid_t;


Problem is the clockid_t is an enum.

--
John David Anglin    dave.anglin@bell.net

[Bug ada/51307] [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"

[charlet at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51307

Arnaud Charlet <charlet at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
                 CC|                            |charlet at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |charlet at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #4 from Arnaud Charlet <charlet at gcc dot gnu.org> 2011-11-28 09:48:39 UTC ---
Here is the patch from Thomas Quinot fixing this issue, I'll commit it
when I get a chance, feel free to use it/test it in the mean time:

Modified: trunk/gnat/s-oscons-tmplt.c
===================================================================
--- trunk/gnat/s-oscons-tmplt.c 2011-11-28 09:36:54 UTC (rev 180967)
+++ trunk/gnat/s-oscons-tmplt.c 2011-11-28 09:42:49 UTC (rev 180968)
@@ -1343,7 +1343,9 @@

 */

-#ifdef CLOCK_REALTIME
+/* Note: On HP-UX, CLOCK_REALTIME is an enum, not a macro. */
+
+#if defined(CLOCK_REALTIME) || defined (__hpux__)
 CND(CLOCK_REALTIME, "System realtime clock")
 #endif

@@ -1377,7 +1379,7 @@
 # define CLOCK_RT_Ada "CLOCK_MONOTONIC"
 # define NEED_PTHREAD_CONDATTR_SETCLOCK

-#elif defined(CLOCK_REALTIME)
+#elif defined(CLOCK_REALTIME) || defined (__hpux__)
 /* By default use CLOCK_REALTIME */
 # define CLOCK_RT_Ada "CLOCK_REALTIME"
 #endif

[Bug ada/51307] [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51307

--- Comment #5 from dave.anglin at bell dot net 2011-11-29 00:16:11 UTC ---
On 28-Nov-11, at 4:48 AM, charlet at gcc dot gnu.org wrote:

> Here is the patch from Thomas Quinot fixing this issue, I'll commit it
> when I get a chance, feel free to use it/test it in the mean time:


I took a slightly different approach, namely to provide an appropriate
define for CLOCK_REALTIME.  This seems to have worked as my build
was successful and there were no errors in the testsuite.

Thomas' patch looks as if it will work as well.  I'll give it a try.

Dave
--
John David Anglin    dave.anglin@bell.net

[Bug ada/51307] [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51307

--- Comment #6 from dave.anglin at bell dot net 2011-12-03 02:12:44 UTC ---
On 28-Nov-11, at 4:48 AM, charlet at gcc dot gnu.org wrote:

> Here is the patch from Thomas Quinot fixing this issue, I'll commit it
> when I get a chance, feel free to use it/test it in the mean time:


Patch doesn't work.

--
John David Anglin    dave.anglin@bell.net

[Bug ada/51307] [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"

[charlet at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51307

--- Comment #7 from Arnaud Charlet <charlet at gcc dot gnu.org> 2011-12-05 10:32:03 UTC ---
Author: charlet
Date: Mon Dec  5 10:31:58 2011
New Revision: 182004

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182004
Log:
2011-12-05  Bob Duff  <duff@adacore.com>

    * sem_ch3.adb (Derive_Progenitor_Subprograms): Add Ultimate_Alias
    to the Comes_From_Source check, to deal properly with the case
    of indirect inheritance of "=".

2011-12-05  Thomas Quinot  <quinot@adacore.com>

    PR ada/51307
    * s-oscons-tmplt.c: On HP-UX, CLOCK_REALTIME is an enum literal,
    not a macro.

2011-12-05  Thomas Quinot  <quinot@adacore.com>

    * par_sco.adb, scos.ads, put_scos.adb, get_scos.adb: Generate dominance
    information in SCOs.


Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/get_scos.adb
    trunk/gcc/ada/par_sco.adb
    trunk/gcc/ada/put_scos.adb
    trunk/gcc/ada/s-oscons-tmplt.c
    trunk/gcc/ada/scos.ads
    trunk/gcc/ada/sem_ch3.adb

[Bug ada/51307] [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"

[charlet at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51307

Arnaud Charlet <charlet at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

--- Comment #8 from Arnaud Charlet <charlet at gcc dot gnu.org> 2011-12-05 10:33:42 UTC ---
Dave, let me know if the current trunk solves the issue or not, thanks.

Arno

[Bug ada/51307] [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51307

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.7.0

[Bug ada/51307] [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51307

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
                 CC|                            |jakub at gcc dot gnu.org

[Bug ada/51307] [4.7 Regression] s-taprop.adb:676:25: "CLOCK_RT_Ada" not declared in "OS_Constants"

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51307

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from John David Anglin <danglin at gcc dot gnu.org> 2011-12-07 13:01:49 UTC ---
Fixed.