[Bug bootstrap/51346] New: [4.7 Regression] LTO bootstrap failed with bootstrap-profiled

[Bug bootstrap/51346] New: [4.7 Regression] LTO bootstrap failed with bootstrap-profiled

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346

             Bug #: 51346
           Summary: [4.7 Regression] LTO bootstrap failed with
                    bootstrap-profiled
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com


On Linux/x86-64, revision 181803 failed to bootstrap-profiled when
configured with:

--prefix=/usr/local --enable-clocale=gnu --with-system-zlib --enable-shared
--with-demangler-in-ld --with-build-config=bootstrap-lto --with-fpmath=sse
--enable-languages=c,c++,fortran,java,lto,objc

In function 'objc_finish_foreach_loop':
lto1: internal compiler error: in cgraph_add_edge_to_call_site_hash, at
cgraph.c:765
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
make[7]: *** [/tmp/cc1texoz.ltrans0.ltrans.o] Error 1
lto-wrapper: make returned 2 exit status
/usr/local/x86_64-unknown-linux-gnu/bin/ld: lto-wrapper failed
collect2: error: ld returned 1 exit status
make[6]: *** [cc1obj] Error 1

Revision 181801 is OK.

[Bug bootstrap/51346] [4.7 Regression] LTO bootstrap failed with bootstrap-profiled

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2011-11-29 17:47:40 UTC ---
It is caused by revision 181803:

http://gcc.gnu.org/ml/gcc-cvs/2011-11/msg01097.html

[Bug bootstrap/51346] [4.7 Regression] LTO bootstrap failed with bootstrap-profiled

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.7.0

[Bug bootstrap/51346] [4.7 Regression] LTO bootstrap failed with bootstrap-profiled

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346

--- Comment #2 from Diego Novillo <dnovillo at gcc dot gnu.org> 2011-11-29 17:50:01 UTC ---
Investigating.

[Bug bootstrap/51346] [4.7 Regression] LTO bootstrap failed with bootstrap-profiled

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346

Diego Novillo <dnovillo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011-11-29
     Ever Confirmed|0                           |1

[Bug bootstrap/51346] [4.7 Regression] LTO bootstrap failed with bootstrap-profiled

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346

Diego Novillo <dnovillo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org

--- Comment #3 from Diego Novillo <dnovillo at gcc dot gnu.org> 2011-11-30 20:17:08 UTC ---
The reason we get into this ICE is because the call to cgraph_edge() has the
side effect of adding entries to e->caller->call_site_hash:

  if (n > 100)
    { 
      node->call_site_hash = htab_create_ggc (120, edge_hash, edge_eq, NULL);
      for (e2 = node->callees; e2; e2 = e2->next_callee)
        cgraph_add_edge_to_call_site_hash (e2);
      for (e2 = node->indirect_calls; e2; e2 = e2->next_callee)
        cgraph_add_edge_to_call_site_hash (e2);
    }

When cgraph_edge is called with n > 100, the call to
cgraph_add_edge_to_call_site_hash asserts because e->call_stmt is already in
the hash table.

Honza, why is this a problem?  The code is expecting to find the slot empty,
but I'm not sure why it expects that.  Any pointers?


Thanks.  Diego.

[Bug bootstrap/51346] [4.7 Regression] LTO bootstrap failed with bootstrap-profiled

[markus at trippelsdorf dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346

Markus Trippelsdorf <markus at trippelsdorf dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |markus at trippelsdorf dot
                   |                            |de

--- Comment #4 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2011-12-01 15:06:11 UTC ---
With the assert in cgraph_add_edge_to_call_site_hash commented out I get:

../../gcc/gcc/c-parser.c: In function ‘c_parser_declaration_or_fndef’:
../../gcc/gcc/c-parser.c:1449:48: internal compiler error: Segmentation fault

[Bug bootstrap/51346] [4.7 Regression] LTO bootstrap failed with bootstrap-profiled

[Joost.VandeVondele at mat dot ethz.ch]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346

Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Joost.VandeVondele at mat
                   |                            |dot ethz.ch

--- Comment #5 from Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> 2011-12-01 15:10:25 UTC ---
*** Bug 51355 has been marked as a duplicate of this bug. ***

[Bug bootstrap/51346] [4.7 Regression] LTO bootstrap failed with bootstrap-profiled

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346

Jack Howarth <howarth at nitro dot med.uc.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |howarth at nitro dot
                   |                            |med.uc.edu

--- Comment #6 from Jack Howarth <howarth at nitro dot med.uc.edu> 2011-12-01 18:12:35 UTC ---
On x86_64-apple-darwin11, this failure occurs for a simple lto-bootstrap and
doesn't require bootstrap-profiled to trigger the problem.

[Bug bootstrap/51346] [4.7 Regression] LTO bootstrap failed with bootstrap-profiled

[dnovillo at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346

--- Comment #7 from dnovillo at google dot com <dnovillo at google dot com> 2011-12-01 18:20:37 UTC ---
On Thu, Dec 1, 2011 at 13:12, howarth at nitro dot med.uc.edu
<gcc-bugzilla@gcc.gnu.org> wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346
>
> Jack Howarth <howarth at nitro dot med.uc.edu> changed:
>
>           What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                 CC|                            |howarth at nitro dot
>                   |                            |med.uc.edu
>
> --- Comment #6 from Jack Howarth <howarth at nitro dot med.uc.edu> 2011-12-01 18:12:35 UTC ---
> On x86_64-apple-darwin11, this failure occurs for a simple lto-bootstrap and
> doesn't require bootstrap-profiled to trigger the problem.

I'm about to commit a patch that should fix this bug.


Diego.

[Bug bootstrap/51346] [4.7 Regression] LTO bootstrap failed with bootstrap-profiled

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346

--- Comment #8 from Diego Novillo <dnovillo at gcc dot gnu.org> 2011-12-01 21:05:14 UTC ---
Author: dnovillo
Date: Thu Dec  1 21:05:10 2011
New Revision: 181894

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181894
Log:
    PR bootstrap/51346
    * ipa-inline.c (can_inline_edge_p): If the edge E has a
    statement, use the statement's inline indicator instead
    of E's.
    Remove consistency check.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-inline.c

[Bug bootstrap/51346] [4.7 Regression] LTO bootstrap failed with bootstrap-profiled

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346

Diego Novillo <dnovillo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Diego Novillo <dnovillo at gcc dot gnu.org> 2011-12-01 21:11:22 UTC ---
Fixed.  http://gcc.gnu.org/ml/gcc-patches/2011-12/msg00107.html.