From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8130 invoked by alias); 5 Dec 2011 09:50:42 -0000 Received: (qmail 8122 invoked by uid 22791); 5 Dec 2011 09:50:42 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Dec 2011 09:50:29 +0000 From: "rguenth at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug c/51391] Differences between setting Winline in command-line and through pragma GCC diagnostic Date: Mon, 05 Dec 2011 09:50:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: rguenth at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC Severity Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2011-12/txt/msg00371.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D51391 Richard Guenther changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hubicka at gcc dot gnu.org, | |jsm28 at gcc dot gnu.org Severity|normal |enhancement --- Comment #16 from Richard Guenther 2011-12-= 05 09:49:20 UTC --- I think a more appropriate "fix" today is to drop the x_flag_no_inline setting (it should not be necessary these days) but keep ignoring -Winline at -O0 (there is probably a better central place to do this, supposedly at the point we emit the warning, instead of in the option code). In fact, the warning inlineBug.h:16:8: warning: function =E2=80=98inlineBug::inlineBug()=E2=80= =99 can never be inlined because it is suppressed using -fno-inline does not seem useful to me at all (see tree-inline.c:tree_inlinable_functio= n_p, warning in a predicate seems questionable to me at best, warning during expand_call_inline isn't better either. A pass over remaining inline-decla= red edges after IPA inline transform sounds more appropriate to me, also enabled when IPA inline is disabled itself)