public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug c++/51397] New: static_assert message formatting
@ 2011-12-03 22:07 dave@boost-consulting.com
2011-12-04 0:42 ` [Bug c++/51397] " redi at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: dave@boost-consulting.com @ 2011-12-03 22:07 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51397
Bug #: 51397
Summary: static_assert message formatting
Classification: Unclassified
Product: gcc
Version: 4.7.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c++
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: dave@boost-consulting.com
I just noticed that GCC can be overly-helpful ;-) when formatting a
static assertion message:
static_assert('X' != '\130',"'X' has the wrong value");
gives me
error: static assertion failed: "\'X\' has the wrong value"
I suggest that GCC should drop the surrounding quotes and not try to
escape any characters in the message. Otherwise, things like
#define static_assert_(x) static_assert(x, #x)
static_assert_('X' != '\130')
turn out quite badly.
The point of this facility is, after all, to help programmers report legible
errors!
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug c++/51397] static_assert message formatting 2011-12-03 22:07 [Bug c++/51397] New: static_assert message formatting dave@boost-consulting.com @ 2011-12-04 0:42 ` redi at gcc dot gnu.org 2011-12-31 11:41 ` paolo.carlini at oracle dot com ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: redi at gcc dot gnu.org @ 2011-12-04 0:42 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51397 Jonathan Wakely <redi at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Last reconfirmed| |2011-12-04 Ever Confirmed|0 |1 --- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-12-04 00:42:23 UTC --- Indeed, I spotted this two days ago, thanks for reporting it ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/51397] static_assert message formatting 2011-12-03 22:07 [Bug c++/51397] New: static_assert message formatting dave@boost-consulting.com 2011-12-04 0:42 ` [Bug c++/51397] " redi at gcc dot gnu.org @ 2011-12-31 11:41 ` paolo.carlini at oracle dot com 2011-12-31 12:23 ` paolo.carlini at oracle dot com ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: paolo.carlini at oracle dot com @ 2011-12-31 11:41 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51397 --- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-12-31 11:28:49 UTC --- The escaping happens in pp_c_char. Of course the problem is in principle easy to fix but I wonder how much special casing we are going to need... ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/51397] static_assert message formatting 2011-12-03 22:07 [Bug c++/51397] New: static_assert message formatting dave@boost-consulting.com 2011-12-04 0:42 ` [Bug c++/51397] " redi at gcc dot gnu.org 2011-12-31 11:41 ` paolo.carlini at oracle dot com @ 2011-12-31 12:23 ` paolo.carlini at oracle dot com 2011-12-31 17:31 ` paolo at gcc dot gnu.org 2011-12-31 17:58 ` paolo.carlini at oracle dot com 4 siblings, 0 replies; 6+ messages in thread From: paolo.carlini at oracle dot com @ 2011-12-31 12:23 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51397 Paolo Carlini <paolo.carlini at oracle dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|unassigned at gcc dot |paolo.carlini at oracle dot |gnu.org |com --- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-12-31 11:40:21 UTC --- Uhm, but the message should be always a STRING_CST. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/51397] static_assert message formatting 2011-12-03 22:07 [Bug c++/51397] New: static_assert message formatting dave@boost-consulting.com ` (2 preceding siblings ...) 2011-12-31 12:23 ` paolo.carlini at oracle dot com @ 2011-12-31 17:31 ` paolo at gcc dot gnu.org 2011-12-31 17:58 ` paolo.carlini at oracle dot com 4 siblings, 0 replies; 6+ messages in thread From: paolo at gcc dot gnu.org @ 2011-12-31 17:31 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51397 --- Comment #4 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-12-31 17:29:35 UTC --- Author: paolo Date: Sat Dec 31 17:29:30 2011 New Revision: 182757 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182757 Log: /cp 2011-12-31 Paolo Carlini <paolo.carlini@oracle.com> PR c++/51397 * semantics.c (finish_static_assert): Use %s instead of %E for the error message. /testsuite 2011-12-31 Paolo Carlini <paolo.carlini@oracle.com> PR c++/51397 * g++.dg/cpp0x/static_assert6.C: New. Added: trunk/gcc/testsuite/g++.dg/cpp0x/static_assert6.C Modified: trunk/gcc/cp/ChangeLog trunk/gcc/cp/semantics.c trunk/gcc/testsuite/ChangeLog ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/51397] static_assert message formatting 2011-12-03 22:07 [Bug c++/51397] New: static_assert message formatting dave@boost-consulting.com ` (3 preceding siblings ...) 2011-12-31 17:31 ` paolo at gcc dot gnu.org @ 2011-12-31 17:58 ` paolo.carlini at oracle dot com 4 siblings, 0 replies; 6+ messages in thread From: paolo.carlini at oracle dot com @ 2011-12-31 17:58 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51397 Paolo Carlini <paolo.carlini at oracle dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED Target Milestone|--- |4.7.0 --- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-12-31 17:30:52 UTC --- Fixed for 4.7.0. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-31 17:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2011-12-03 22:07 [Bug c++/51397] New: static_assert message formatting dave@boost-consulting.com 2011-12-04 0:42 ` [Bug c++/51397] " redi at gcc dot gnu.org 2011-12-31 11:41 ` paolo.carlini at oracle dot com 2011-12-31 12:23 ` paolo.carlini at oracle dot com 2011-12-31 17:31 ` paolo at gcc dot gnu.org 2011-12-31 17:58 ` paolo.carlini at oracle dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).