[Bug c++/51397] New: static_assert message formatting

[Bug c++/51397] New: static_assert message formatting

[dave@boost-consulting.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51397

             Bug #: 51397
           Summary: static_assert message formatting
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dave@boost-consulting.com


I just noticed that GCC can be overly-helpful ;-) when formatting a
static assertion message:

    static_assert('X' != '\130',"'X' has the wrong value");

gives me

    error: static assertion failed: "\'X\' has the wrong value"

I suggest that GCC should drop the surrounding quotes and not try to
escape any characters in the message.  Otherwise, things like

    #define static_assert_(x) static_assert(x, #x)
    static_assert_('X' != '\130')

turn out quite badly.

The point of this facility is, after all, to help programmers report legible
errors!

[Bug c++/51397] static_assert message formatting

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51397

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011-12-04
     Ever Confirmed|0                           |1

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-12-04 00:42:23 UTC ---
Indeed, I spotted this two days ago, thanks for reporting it

[Bug c++/51397] static_assert message formatting

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51397

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-12-31 11:28:49 UTC ---
The escaping happens in pp_c_char. Of course the problem is in principle easy
to fix but I wonder how much special casing we are going to need...

[Bug c++/51397] static_assert message formatting

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51397

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |paolo.carlini at oracle dot
                   |gnu.org                     |com

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-12-31 11:40:21 UTC ---
Uhm, but the message should be always a STRING_CST.

[Bug c++/51397] static_assert message formatting

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51397

--- Comment #4 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-12-31 17:29:35 UTC ---
Author: paolo
Date: Sat Dec 31 17:29:30 2011
New Revision: 182757

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182757
Log:
/cp
2011-12-31  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/51397
    * semantics.c (finish_static_assert): Use %s instead of %E for
    the error message.

/testsuite
2011-12-31  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/51397
    * g++.dg/cpp0x/static_assert6.C: New.


Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/static_assert6.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/semantics.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/51397] static_assert message formatting

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51397

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.7.0

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-12-31 17:30:52 UTC ---
Fixed for 4.7.0.