[Bug middle-end/51516] New: [trans-mem] problem with TM clone aliases

[Bug middle-end/51516] New: [trans-mem] problem with TM clone aliases

[patrick.marlier at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51516

             Bug #: 51516
           Summary: [trans-mem] problem with TM clone aliases
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: patrick.marlier@gmail.com
                CC: aldyh@gcc.gnu.org, rth@gcc.gnu.org


Created attachment 26060
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26060
patch for trans-mem.c

PR51347 shows up a problem due to the TM IPA rework.
Indeed, an alias can get called but tm cg data are in the parent of the alias.
So it ends up to calls _ITM_getTMCloneOrIrrevocable for the alias which is
wrong.

Patch attached with testcase.
Bootstrapped and regtested.

http://gcc.gnu.org/ml/gcc-patches/2011-12/msg00225.html

Patrick Marlier.

[Bug middle-end/51516] [trans-mem] problem with TM clone aliases

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51516

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-01-06
         AssignedTo|unassigned at gcc dot       |aldyh at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

[Bug middle-end/51516] [trans-mem] problem with TM clone aliases

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51516

--- Comment #1 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-01-10 16:50:56 UTC ---
Author: aldyh
Date: Tue Jan 10 16:50:41 2012
New Revision: 183070

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183070
Log:
        PR middle-end/51516
        * trans-mem.c (get_cg_data): Traverse aliases if requested.
        (ipa_tm_scan_calls_block): Update parameters to get_cg_data.
        (ipa_tm_note_irrevocable): Same.
        (ipa_tm_scan_irr_block): Same.
        (ipa_tm_decrement_clone_counts): Same.
        (ipa_tm_scan_irr_function): Same.
        (ipa_tm_create_version_alias): Same.
        (ipa_tm_create_version): Same.
        (ipa_tm_transform_calls_redirect): Same.
        (ipa_tm_transform_calls): Same.
        (ipa_tm_transform_transaction): Same.
        (ipa_tm_execute): Same.


Added:
    trunk/gcc/testsuite/g++.dg/tm/pr51516.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/trans-mem.c

[Bug middle-end/51516] [trans-mem] problem with TM clone aliases

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51516

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-01-10 16:52:52 UTC ---
fixed