[Bug tree-optimization/51583] New: One more missing force_gimple_operand in SRA

[Bug tree-optimization/51583] New: One more missing force_gimple_operand in SRA

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51583

             Bug #: 51583
           Summary: One more missing force_gimple_operand in SRA
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: jamborm@gcc.gnu.org
        ReportedBy: jamborm@gcc.gnu.org


Created attachment 26113
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26113
Testcase

I noticed that part of my fix to PR 50622 somehow got lost which can
lead to ICEs in some obscure cases, for example when compiling the
attached testcase.  It fails on i686 and x86_64, on both the trunk and
the 4.6 branch with:

test.c: In function ‘foo’:
test.c:34:1: error: invalid rhs for gimple memory store
s$u$v

t.u.v;

# .MEM_20 = VDEF <.MEM_14>
s$u$v = t.u.v;

test.c:34:1: internal compiler error: verify_stmts failed

I am about to bootstrap and test a fix.

[Bug tree-optimization/51583] One more missing force_gimple_operand in SRA

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51583

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2011-12/msg01295.htm
                   |                            |l
   Last reconfirmed|                            |2011-12-17
     Ever Confirmed|0                           |1

--- Comment #1 from Martin Jambor <jamborm at gcc dot gnu.org> 2011-12-17 01:17:47 UTC ---
Patch posted to the mailing list:
http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01295.html

[Bug tree-optimization/51583] One more missing force_gimple_operand in SRA

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51583

--- Comment #2 from Martin Jambor <jamborm at gcc dot gnu.org> 2011-12-19 14:33:21 UTC ---
Author: jamborm
Date: Mon Dec 19 14:33:18 2011
New Revision: 182483

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182483
Log:
2011-12-19  Martin Jambor  <mjambor@suse.cz>

    PR tree-optimization/51583
    * tree-sra.c (load_assign_lhs_subreplacements): Call
    force_gimple_operand_gsi when necessary also in case of no
    corresponding replacement on the RHS.

    * testsuite/gcc.dg/tree-ssa/pr51583.c: New test.


Added:
    trunk/gcc/testsuite/gcc.dg/tree-ssa/pr51583.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-sra.c

[Bug tree-optimization/51583] One more missing force_gimple_operand in SRA

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51583

--- Comment #3 from Martin Jambor <jamborm at gcc dot gnu.org> 2011-12-19 16:47:35 UTC ---
Author: jamborm
Date: Mon Dec 19 16:47:28 2011
New Revision: 182488

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182488
Log:
2011-12-19  Martin Jambor  <mjambor@suse.cz>

    PR tree-optimization/51583
    * tree-sra.c (load_assign_lhs_subreplacements): Call
    force_gimple_operand_gsi when necessary also in case of no
    corresponding replacement on the RHS.

    * testsuite/gcc.dg/tree-ssa/pr51583.c: New test.


Added:
    branches/gcc-4_6-branch/gcc/testsuite/gcc.dg/tree-ssa/pr51583.c
Modified:
    branches/gcc-4_6-branch/gcc/ChangeLog
    branches/gcc-4_6-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_6-branch/gcc/tree-sra.c

[Bug tree-optimization/51583] One more missing force_gimple_operand in SRA

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51583

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Martin Jambor <jamborm at gcc dot gnu.org> 2011-12-20 11:20:52 UTC ---
Fixed.