[Bug tree-optimization/51606] New: [4.7 Regression] FAIL: gcc.dg/vect/pr51015.c (internal compiler error) on ppc*-*-*

[Bug tree-optimization/51606] New: [4.7 Regression] FAIL: gcc.dg/vect/pr51015.c (internal compiler error) on ppc*-*-*

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51606

             Bug #: 51606
           Summary: [4.7 Regression] FAIL: gcc.dg/vect/pr51015.c (internal
                    compiler error) on ppc*-*-*
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dominiq@lps.ens.fr
                CC: iains@gcc.gnu.org, irar@gcc.gnu.org, jakub@redhat.com,
                    pthaugen@us.ibm.com
              Host: ppc*-*-*
            Target: ppc*-*-*
             Build: ppc*-*-*


Between revisions 182355 (OK, see
http://gcc.gnu.org/ml/gcc-testresults/2011-12/msg01667.html) and 182398 the
following tests have started to fail (see
http://gcc.gnu.org/ml/gcc-testresults/2011-12/msg01781.html )

FAIL: gcc.dg/vshift-1.c (internal compiler error)
FAIL: gcc.dg/vshift-1.c (test for excess errors)
WARNING: gcc.dg/vshift-1.c compilation failed to produce executable
FAIL: gcc.dg/vect/pr51015.c (internal compiler error)
FAIL: gcc.dg/vect/pr51015.c (test for excess errors)
FAIL: gcc.dg/vect/pr51015.c -flto (internal compiler error)
FAIL: gcc.dg/vect/pr51015.c -flto (test for excess errors)

AFAICT gcc.dg/vshift-1.c fails on powerpc-apple-darwin9 only.

The backtrace is

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_PROTECTION_FAILURE at address: 0x0000000c
flow_bb_inside_loop_p (loop=0x4288eb64, bb=0x0) at ../../work/gcc/cfgloop.c:776
776      source_loop = bb->loop_father;
(gdb) bt
#0  flow_bb_inside_loop_p (loop=0x4288eb64, bb=0x0) at
../../work/gcc/cfgloop.c:776
#1  0x00808d40 in vect_stmt_relevant_p (stmt=<value temporarily unavailable,
due to optimizations>, relevant=0xbfffd318, live_p=0xbfffd31c) at
../../work/gcc/tree-vect-stmts.c:260
#2  0x0080eae4 in vect_mark_stmts_to_be_vectorized (loop_vinfo=0x0) at
../../work/gcc/tree-vect-stmts.c:552
#3  0x00827260 in vect_analyze_loop (loop=0x993360) at
../../work/gcc/tree-vect-loop.c:1521
#4  0x008389b8 in vectorize_loops () at ../../work/gcc/tree-vectorizer.c:203
#5  0x005734d0 in execute_one_pass (pass=0x428d6144) at
../../work/gcc/passes.c:2079
#6  0x005738a8 in execute_pass_list (pass=0x428d6144) at
../../work/gcc/passes.c:2134
#7  execute_pass_list (pass=0xbb64c0) at ../../work/gcc/passes.c:2136
#8  execute_pass_list (pass=0xbb5d70) at ../../work/gcc/passes.c:2136
#9  0x006c85c8 in tree_rest_of_compilation (fndecl=0x428bbe00) at
../../work/gcc/tree-optimize.c:421
#10 0x00278e28 in cgraph_expand_function (node=0x428bbe00) at
../../work/gcc/cgraphunit.c:1818
#11 0x0027ae4c in cgraph_optimize () at ../../work/gcc/cgraphunit.c:1885
#12 0x0027b684 in cgraph_finalize_compilation_unit () at
../../work/gcc/cgraphunit.c:1327
#13 0x0001fdd4 in c_write_global_declarations () at
../../work/gcc/c-decl.c:10026
#14 0x00635cf4 in toplev_main (argc=3, argv=0x4288e6c0) at
../../work/gcc/toplev.c:573
#15 0x00001c34 in start ()

[Bug tree-optimization/51606] [4.7 Regression] FAIL: gcc.dg/vect/pr51015.c (internal compiler error) on ppc*-*-*

[irar at il dot ibm.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51606

Ira Rosen <irar at il dot ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011-12-18
                 CC|                            |irar at il dot ibm.com
     Ever Confirmed|0                           |1

--- Comment #1 from Ira Rosen <irar at il dot ibm.com> 2011-12-18 11:41:41 UTC ---
Caused by 
r182388 | jakub | 2011-12-15 22:47:29 +0200 (Thu, 15 Dec 2011) | 27 lines

        * tree-vectorizer.h (struct _stmt_vec_info): Remove pattern_def_stmt
        field, add pattern_def_seq.
        (STMT_VINFO_PATTERN_DEF_STMT): Remove.
        (STMT_VINFO_PATTERN_DEF_SEQ): Define.
        (NUM_PATTERNS): Bump to 10.
        * tree-vect-loop.c (vect_determine_vectorization_factor,
        vect_transform_loop): Adjust for pattern def changing from a single
        gimple stmt to gimple_seq.
        * tree-vect-stmts.c (vect_analyze_stmt, new_stmt_vec_info,
        free_stmt_vec_info): Likewise.
        * tree-vect-patterns.c (vect_recog_over_widening_pattern,
        vect_recog_vector_vector_shift_pattern,
        vect_recog_mixed_size_cond_pattern, adjust_bool_pattern_cast,
        adjust_bool_pattern, vect_mark_pattern_stmts): Likewise.
        (vect_recog_sdivmod_pow2_pattern): New function.
        (vect_vect_recog_func_ptrs): Add it.
         ...

And probably PR 51580 is the same problem.

Looking at pr51015.c, vect_recog_vector_vector_shift_pattern is detected and a
new def stmt is created during the detection: 
patt.23_33 = (long long unsigned int) D.2004_3; 
The pattern detection fails later (on the vector type checks probably), but
this stmt remains a use stmt of D.2004_3 = i_25 + -2;.  Therefore, we check
whether it's inside the loop, but get segfault while trying to check its not
existing BB.

Before the use of gimple_seq, this didn't happen, i.e., patt.23_33 = (long long
unsigned int) D.2004_3; wasn't a use of D.2004_3 = i_25 + -2;.

[Bug tree-optimization/51606] [4.7 Regression] FAIL: gcc.dg/vect/pr51015.c (internal compiler error) on ppc*-*-*

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51606

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org
   Target Milestone|---                         |4.7.0

[Bug tree-optimization/51606] [4.7 Regression] FAIL: gcc.dg/vect/pr51015.c (internal compiler error) on ppc*-*-*

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51606

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-12-19 09:23:00 UTC ---
Dup (and PR51580 likely too).

*** This bug has been marked as a duplicate of bug 51590 ***

[Bug tree-optimization/51606] [4.7 Regression] FAIL: gcc.dg/vect/pr51015.c (internal compiler error) on ppc*-*-*

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51606

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-12-19 14:22:36 UTC ---
Author: jakub
Date: Mon Dec 19 14:22:29 2011
New Revision: 182480

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182480
Log:
    PR middle-end/51590
    PR tree-optimization/51606
    * tree-vect-patterns.c (append_pattern_def_seq, new_pattern_def_seq):
    New inline functions.
    (vect_recog_over_widening_pattern,
    vect_recog_vector_vector_shift_pattern,
    vect_recog_sdivmod_pow2_pattern, vect_recog_mixed_size_cond_pattern,
    adjust_bool_pattern_cast, vect_recog_bool_pattern): Use them.

    * gcc.dg/vect/pr51590.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/vect/pr51590.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-vect-patterns.c