[Bug c++/51641] New: Lookup finds enclosing class member instead of template parameter

[Bug c++/51641] New: Lookup finds enclosing class member instead of template parameter

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51641

             Bug #: 51641
           Summary: Lookup finds enclosing class member instead of
                    template parameter
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Keywords: accepts-invalid
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: jason@gcc.gnu.org
                CC: dodji@gcc.gnu.org
        Depends on: 36019, 45625


Another case of the lookup problem you fixed previously has come up on the core
mailing list:

struct A {
    struct B { typedef int X; };
};

template<class B> struct C : A {
    B::X q; // Ok: A::B.                                                        
    struct U { typedef int X; };
    template<class U>
        struct D;
};

template<class B>
template<class U>
struct C<B>::D {
    typename U::X r; // { dg-error "" }

C<int>::D<double> y;

The use of U in D should find the template parameter, leading to an error on
instantiation.

[Bug c++/51641] Lookup finds enclosing class member instead of template parameter

[dodji at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51641

Dodji Seketeli <dodji at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-01-25
         AssignedTo|unassigned at gcc dot       |dodji at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

[Bug c++/51641] Lookup finds enclosing class member instead of template parameter

[dodji at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51641

--- Comment #1 from Dodji Seketeli <dodji at gcc dot gnu.org> 2012-01-26 12:36:25 UTC ---
I candidate patch was sent to
http://gcc.gnu.org/ml/gcc-patches/2012-01/msg01371.html

[Bug c++/51641] Lookup finds enclosing class member instead of template parameter

[dodji at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51641

--- Comment #2 from Dodji Seketeli <dodji at gcc dot gnu.org> 2012-01-30 14:26:19 UTC ---
Author: dodji
Date: Mon Jan 30 14:26:12 2012
New Revision: 183726

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183726
Log:
PR c++/51641 - Lookup finds enclosing class member instead of template
parameter

gcc/cp/

    PR c++/51641
    * cp-tree.h (template_type_parameter_p): Declare new function.
    (parameter_of_template_p): Remove
    * pt.c (template_type_parameter_p): Define new function.
    (parameter_of_template_p): Remove.
    * name-lookup.c (binding_to_template_parms_of_scope_p): Don't rely
    on parameter_of_template_p anymore.  Compare the level of the
    template parameter to the depth of the template.

gcc/testsuite/

    PR c++/51641
    * g++.dg/lookup/hidden-class17.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/lookup/hidden-class17.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/name-lookup.c
    trunk/gcc/cp/pt.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/51641] Lookup finds enclosing class member instead of template parameter

[dodji at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51641

--- Comment #3 from Dodji Seketeli <dodji at gcc dot gnu.org> 2012-01-30 14:55:50 UTC ---
I have inadvertently committed this in trunk (4.7) even though it wasn't a
regression.  I have now reverted it, and queuing it for 4.8 when stage 1 opens
again.  Sorry.

[Bug c++/51641] Lookup finds enclosing class member instead of template parameter

[dodji at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51641

--- Comment #4 from Dodji Seketeli <dodji at gcc dot gnu.org> 2012-03-13 21:25:26 UTC ---
Author: dodji
Date: Tue Mar 13 21:25:22 2012
New Revision: 185357

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=185357
Log:
PR c++/51641 - Lookup finds enclosing class member instead of template
parameter

gcc/cp/

    PR c++/51641
    * cp-tree.h (template_type_parameter_p): Declare new function.
    (parameter_of_template_p): Remove
    * pt.c (template_type_parameter_p): Define new function.
    (parameter_of_template_p): Remove.
    * name-lookup.c (binding_to_template_parms_of_scope_p): Don't rely
    on parameter_of_template_p anymore.  Compare the level of the
    template parameter to the depth of the template.

gcc/testsuite/

    PR c++/51641
    * g++.dg/lookup/hidden-class17.C: New test.


Conflicts:

    gcc/cp/pt.c

Added:
    trunk/gcc/testsuite/g++.dg/lookup/hidden-class17.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/name-lookup.c
    trunk/gcc/cp/pt.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/51641] Lookup finds enclosing class member instead of template parameter

[dodji at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51641

Dodji Seketeli <dodji at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Dodji Seketeli <dodji at gcc dot gnu.org> 2012-03-13 21:37:48 UTC ---
Fixed in trunk (4.8)