From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-377762-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 6372 invoked by alias); 21 Dec 2011 09:52:16 -0000
Received: (qmail 6359 invoked by uid 22791); 21 Dec 2011 09:52:15 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00,SARE_HEAD_8BIT_SPAM,SARE_SUB_ENC_UTF8,TW_TM
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Dec 2011 09:52:03 +0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/51644] [4.7 Regression] va_list vs. warning:=?UTF-8?Q?=20=E2=80=98noreturn=E2=80=99=20function=20does=20return=20is=20not=20fixable?=
Date: Wed, 21 Dec 2011 09:53:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.7.0
X-Bugzilla-Changed-Fields:
Message-ID: <bug-51644-4-1iFBYrdsu9@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-51644-4@http.gcc.gnu.org/bugzilla/>
References: <bug-51644-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2011-12/txt/msg02328.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51644

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-12-21 09:51:45 UTC ---
Caused by r181172 aka TREE_CLOBBER_P.  The problem is that we have before
*.cfg:
  __builtin_va_start (&args, 0);
  b (s, &args);
  __builtin_va_end (&args);
  finally_tmp.0 = 1;
  <D.2917>:
  args = {CLOBBER};
  switch (finally_tmp.0) <default: <D.2921>, default: <D.2921>, case 1:
<D.2918>>
  <D.2918>:
  goto <D.2919>;
  <D.2919>:
  return;
  <D.2920>:
  finally_tmp.0 = 0;
  goto <D.2917>;
  <D.2921>:
  resx 1
and *.cfg pass obviously optimizes away anything after the noreturn call:
<bb 2>:
  __builtin_va_start (&args, 0);
  b (s, &args);
<L5>:
  return;
<L3>:
  finally_tmp.0 = 0;
  args = {CLOBBER};
  switch (finally_tmp.0) <default: <L4>, case 1: <L5>>
<L4>:
  resx 1
but the warn_function_return pass is immediately after that (and, this is -O0
anyway), so nothing optimizes the switch away into simple fall through into the
resx 1 block.  At -O and above we don't warn, because the *.eh pass before
*.cfg pass optimizes this.

So, IMHO to fix this, we need to do 2 things:
1) in decide_copy_try_finally reconsider
     if (!optimize)
    return ndests == 1;
   if finally contains only gimple_clobber_p stmts
2) estimate_num_insns should return 0 for gimple_clobber_p stmts