[Bug tree-optimization/51684] New: [4.7 Regression]: ICE in gfortran.dg/maxloc_bounds_5 on ia64

[Bug tree-optimization/51684] New: [4.7 Regression]: ICE in gfortran.dg/maxloc_bounds_5 on ia64

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51684

             Bug #: 51684
           Summary: [4.7 Regression]: ICE in gfortran.dg/maxloc_bounds_5
                    on ia64
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ubizjak@gmail.com


A problem in SLP vectorizer, can be triggered with a cross:

$ ~/gcc-build-xxx/gcc/f951 -O3 -quiet maxloc_bounds_5.f90
maxloc_bounds_5.f90: In function ‘foo’:
maxloc_bounds_5.f90:6:0: internal compiler error: in gsi_for_stmt, at
gimple-iterator.c:560
Please submit a full bug report,
[...]

(gdb) bt
#0  internal_error (gmsgid=0xdfea45 "in %s, at %s:%d") at
../../gcc-svn/trunk/gcc/diagnostic.c:839
#1  0x0000000000c462f4 in fancy_abort (file=<optimized out>, line=560,
function=0xcf3913 "gsi_for_stmt")
    at ../../gcc-svn/trunk/gcc/diagnostic.c:899
#2  0x000000000074885c in gsi_for_stmt (stmt=0x7ffff14724b0) at
../../gcc-svn/trunk/gcc/gimple-iterator.c:560
#3  0x0000000000a62372 in vect_schedule_slp_instance (node=0x13ad400,
instance=0x13b71e0, vectorization_factor=<optimized out>)
    at ../../gcc-svn/trunk/gcc/tree-vect-slp.c:2888
#4  0x0000000000a68fa9 in vect_schedule_slp (loop_vinfo=<optimized out>,
bb_vinfo=<optimized out>)
    at ../../gcc-svn/trunk/gcc/tree-vect-slp.c:2970
#5  0x0000000000a5bc24 in vect_transform_loop (loop_vinfo=0x13b97d0) at
../../gcc-svn/trunk/gcc/tree-vect-loop.c:5395
#6  0x0000000000a69acb in vectorize_loops () at
../../gcc-svn/trunk/gcc/tree-vectorizer.c:214
#7  0x000000000081f8a7 in execute_one_pass (pass=0x10dad40) at
../../gcc-svn/trunk/gcc/passes.c:2080

(gdb) f 2
#2  0x000000000074885c in gsi_for_stmt (stmt=0x7ffff14724b0) at
../../gcc-svn/trunk/gcc/gimple-iterator.c:560
560       gcc_unreachable ();
(gdb) p debug_gimple_stmt (stmt)
VIEW_CONVERT_EXPR<<unnamed-unsigned:8>>(MEM[(logical(kind=1)[0:]
*)D.900_81][D.987_168]) = patt.40_106;

$3 = void

[Bug tree-optimization/51684] [4.7 Regression]: ICE in gfortran.dg/maxloc_bounds_5 on ia64

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51684

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org
   Target Milestone|---                         |4.7.0

[Bug tree-optimization/51684] [4.7 Regression]: ICE in gfortran.dg/maxloc_bounds_5 on ia64

[irar at il dot ibm.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51684

Ira Rosen <irar at il dot ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011-12-27
                 CC|                            |irar at il dot ibm.com
         AssignedTo|unassigned at gcc dot       |irar at il dot ibm.com
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #1 from Ira Rosen <irar at il dot ibm.com> 2011-12-27 13:53:13 UTC ---
Untested patch:

Index: tree-vect-slp.c
===================================================================
--- tree-vect-slp.c     (revision 182692)
+++ tree-vect-slp.c     (working copy)
@@ -2885,6 +2885,8 @@ vect_schedule_slp_instance (slp_tree nod
       && REFERENCE_CLASS_P (gimple_get_lhs (stmt)))
     {
       gimple last_store = vect_find_last_store_in_slp_instance (instance);
+      if (is_pattern_stmt_p (vinfo_for_stmt (last_store)))
+       last_store = STMT_VINFO_RELATED_STMT (vinfo_for_stmt (last_store));
       si = gsi_for_stmt (last_store);
     }

@@ -2989,6 +2991,8 @@ vect_schedule_slp (loop_vec_info loop_vi
           if (!STMT_VINFO_DATA_REF (vinfo_for_stmt (store)))
             break;

+         if (is_pattern_stmt_p (vinfo_for_stmt (store)))
+           store = STMT_VINFO_RELATED_STMT (vinfo_for_stmt (store));
           /* Free the attached stmt_vec_info and remove the stmt.  */
           gsi = gsi_for_stmt (store);
           gsi_remove (&gsi, true);

[Bug tree-optimization/51684] [4.7 Regression]: ICE in gfortran.dg/maxloc_bounds_5 on ia64

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51684

--- Comment #2 from Uros Bizjak <ubizjak at gmail dot com> 2011-12-28 09:06:45 UTC ---
(In reply to comment #1)
> Untested patch:

I have bootstrapped and regression tested the patch on ia64-unknown-linux-gnu
[1], where it fixes all mentioned failures.

[1] http://gcc.gnu.org/ml/gcc-testresults/2011-12/msg02709.html

[Bug tree-optimization/51684] [4.7 Regression]: ICE in gfortran.dg/maxloc_bounds_5 on ia64

[irar at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51684

--- Comment #3 from irar at gcc dot gnu.org 2011-12-28 09:20:20 UTC ---
Author: irar
Date: Wed Dec 28 09:20:16 2011
New Revision: 182705

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182705
Log:

        PR tree-optimization/51684
        * tree-vect-slp.c (vect_schedule_slp_instance): Get gsi of
        original statement in case of a pattern.
        (vect_schedule_slp): Likewise.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-vect-slp.c

[Bug tree-optimization/51684] [4.7 Regression]: ICE in gfortran.dg/maxloc_bounds_5 on ia64

[irar at il dot ibm.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51684

Ira Rosen <irar at il dot ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Ira Rosen <irar at il dot ibm.com> 2011-12-28 10:22:07 UTC ---
Fixed.