[Bug c/51696] New: [trans-mem] unsafe indirect function call in struct not properly displayed

[Bug c/51696] New: [trans-mem] unsafe indirect function call in struct not properly displayed

[patrick.marlier at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51696

             Bug #: 51696
           Summary: [trans-mem] unsafe indirect function call in struct
                    not properly displayed
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: c
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: patrick.marlier@gmail.com
                CC: aldyh@gcc.gnu.org, torvald@gcc.gnu.org


Created attachment 26196
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26196
Attached testcase

With an unsafe indirect function call, the error message is not clear. I don't
know if it can display the declaration. In the worst case, "unsafe indirect
function call within ‘transaction_safe’ function" should be ok.

$ ./gcc/xgcc -B./gcc/ -fgnu-tm -O0 testcase.i
testcase.i: In function ‘func’:
testcase.i:7:21: error: unsafe function call ‘<Uf3c0>’ within
‘transaction_safe’ function
testcase.i:8:12: error: unsafe function call ‘compare.1’ within
‘transaction_safe’ function

Patrick Marlier.

[Bug middle-end/51696] [trans-mem] unsafe indirect function call in struct not properly displayed

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51696

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
           Keywords|                            |diagnostic, trans-mem
   Last reconfirmed|                            |2011-12-30
          Component|c                           |middle-end
     Ever Confirmed|0                           |1
           Severity|enhancement                 |normal

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-12-30 23:42:50 UTC ---
Confirmed.

[Bug middle-end/51696] [trans-mem] unsafe indirect function call in struct not properly displayed

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51696

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot       |aldyh at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #2 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-01-03 17:20:43 UTC ---
Proposed,
http://gcc.gnu.org/ml/gcc-patches/2012-01/msg00130.html

[Bug middle-end/51696] [trans-mem] unsafe indirect function call in struct not properly displayed

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51696

--- Comment #3 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-01-04 14:32:59 UTC ---
Author: aldyh
Date: Wed Jan  4 14:32:54 2012
New Revision: 182876

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182876
Log:
        PR middle-end/51696
        * trans-mem.c (diagnose_tm_1): Display indirect calls with no name
        correctly.


Added:
    trunk/gcc/testsuite/gcc.dg/tm/pr51696.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/trans-mem.c

[Bug middle-end/51696] [trans-mem] unsafe indirect function call in struct not properly displayed

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51696

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-01-04 14:34:39 UTC ---
fixed