public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tobi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/51727] Changing module files
Date: Sat, 13 Oct 2012 08:31:00 -0000	[thread overview]
Message-ID: <bug-51727-4-MxwJE0AzMk@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-51727-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51727

--- Comment #19 from Tobias Schlüter <tobi at gcc dot gnu.org> 2012-10-13 08:31:39 UTC ---
Simon,
I don't think the 'integer's are functions of the pointers once you process the
symbols in a defined order.  The non-determinism was caused by traversing the
pointer_info tree based on the non-deterministic pointers.  With the patch, the
tree is copied to a map sorted by the integers.  In the first iteration of
write_symbol1 these are given by the traversal of the namespace, which is
deterministic.  Since we now process these symbols in a deterministic order,
the integers of the symbols added during each iteration are also deterministic.
 I might be missing something, of course.

Joost,
it wouldn't be much work to implement the same thing using GFC_BBT instead of a
std::map.  It would require a typedef and one would have to cleanup the tree
manually, but if fixing old versions of gcc is valuable, I can do it.  I might
have to do this anyway, as I don't know if gfortran maintainers like C++isms
(even though in this particular case it's probably non-controversial).


  parent reply	other threads:[~2012-10-13  8:31 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-02  0:20 [Bug fortran/51727] New: " mikael at gcc dot gnu.org
2012-10-05 18:16 ` [Bug fortran/51727] " Joost.VandeVondele at mat dot ethz.ch
2012-10-05 19:35 ` tobi at gcc dot gnu.org
2012-10-06 11:41 ` tobi at gcc dot gnu.org
2012-10-06 12:42 ` Joost.VandeVondele at mat dot ethz.ch
2012-10-06 12:46 ` Joost.VandeVondele at mat dot ethz.ch
2012-10-06 12:47 ` Joost.VandeVondele at mat dot ethz.ch
2012-10-06 12:48 ` Joost.VandeVondele at mat dot ethz.ch
2012-10-06 12:52 ` Joost.VandeVondele at mat dot ethz.ch
2012-10-08  9:33 ` simonb at google dot com
2012-10-10  9:11 ` tobi at gcc dot gnu.org
2012-10-10  9:48 ` tobi at gcc dot gnu.org
2012-10-11 12:37 ` tobi at gcc dot gnu.org
2012-10-11 13:03 ` tobi at gcc dot gnu.org
2012-10-11 13:30 ` tobi at gcc dot gnu.org
2012-10-11 14:02 ` tobi at gcc dot gnu.org
2012-10-13  8:08 ` simonb at google dot com
2012-10-13  8:09 ` aaw at gcc dot gnu.org
2012-10-13  8:13 ` Joost.VandeVondele at mat dot ethz.ch
2012-10-13  8:31 ` tobi at gcc dot gnu.org [this message]
2012-10-13  9:26 ` simonb at google dot com
2012-10-13  9:32 ` tobi at gcc dot gnu.org
2012-10-13 11:30 ` tobi at gcc dot gnu.org
2012-10-13 12:28 ` Joost.VandeVondele at mat dot ethz.ch
2012-10-13 12:45 ` Joost.VandeVondele at mat dot ethz.ch
2012-10-15 14:14 ` Joost.VandeVondele at mat dot ethz.ch
2012-10-28 11:11 ` Joost.VandeVondele at mat dot ethz.ch
2012-10-28 11:15 ` tobi at gcc dot gnu.org
2012-11-08 15:46 ` tobi at gcc dot gnu.org
2012-11-08 22:22 ` tobi at gcc dot gnu.org
2012-11-09  7:31 ` Joost.VandeVondele at mat dot ethz.ch
2012-11-09  9:44 ` tobi at gcc dot gnu.org
2012-11-09 10:05 ` Joost.VandeVondele at mat dot ethz.ch
2012-11-29  7:31 ` Joost.VandeVondele at mat dot ethz.ch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-51727-4-MxwJE0AzMk@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).