public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/51752] trans-mem: publication safety violated
Date: Thu, 09 Feb 2012 16:44:00 -0000	[thread overview]
Message-ID: <bug-51752-4-uJixf5Q61g@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-51752-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51752

--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-02-09 16:43:40 UTC ---
But isn't with

  __transaction_atomic
    {
      for (i = 0; i < 10; i++)
        if (x[i])
          x[i] += data;
    }

and

  __transaction_atomic { x[9] = 1; }

occuring concurrently the loop transaction terminated?  Thus,

  __transaction_atomic
    {
      tem = data;
      for (i = 0; i < 10; i++)
        if (x[i])
          x[i] += tem;
    }

equivalent?  We don't hoist out of the transaction region (well, as far
as I can see - the transaction region seems to be specified in a very
weak way, without virtual operands or any IL barrier or such).

<bb 2>:
  # .MEM_2 = VDEF <.MEM_1(D)>
  data = 23;
  __transaction_atomic  // SUBCODE=[ GTMA_HAVE_STORE ]

<bb 3>:
  # .MEM_3 = VDEF <.MEM_2>
  x[9] = 1;
  # .MEM_4 = VDEF <.MEM_3>
  __builtin__ITM_commitTransaction ();

<bb 4>:
  # VUSE <.MEM_4>
  return;

the __transaction_atomic  // SUBCODE=[ GTMA_HAVE_STORE ] statement
looks like an overly optimistic way to start a transaction in my quick view.


  parent reply	other threads:[~2012-02-09 16:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04 14:18 [Bug middle-end/51752] New: " torvald at gcc dot gnu.org
2012-01-04 19:18 ` [Bug middle-end/51752] " torvald at gcc dot gnu.org
2012-01-05 14:30 ` aldyh at gcc dot gnu.org
2012-01-06 14:03 ` torvald at gcc dot gnu.org
2012-02-09 16:24 ` aldyh at gcc dot gnu.org
2012-02-09 16:44 ` rguenth at gcc dot gnu.org [this message]
2012-02-09 17:40 ` rth at gcc dot gnu.org
2012-02-09 18:41 ` torvald at gcc dot gnu.org
2012-02-28 20:10 ` aldyh at gcc dot gnu.org
2012-03-16 19:15 ` aldyh at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-51752-4-uJixf5Q61g@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).