* [Bug libstdc++/51772] --enable-clocale=generic makes unsafe assumptions about ctype_base::mask
2012-01-06 0:08 [Bug libstdc++/51772] New: --enable-clocale=generic makes unsafe assumptions about ctype_base::mask redi at gcc dot gnu.org
@ 2012-01-06 13:20 ` paolo.carlini at oracle dot com
2012-01-06 14:01 ` redi at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: paolo.carlini at oracle dot com @ 2012-01-06 13:20 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51772
--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-01-06 13:20:33 UTC ---
Maybe I'm misunderstanding the tone of your PR, and certainly Benjamin knows
better than me because he invented this stuff, but I don't think the blame
should be on the generic configuration per se, in other terms it isn't supposed
to be fully generic and covering all possible situations. I think the general
idea was providing something covering a good range of cases and then making
easy addind new ones covering the special needs of the various targets. I think
that, for now at least, should. E done for netbsd too.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libstdc++/51772] --enable-clocale=generic makes unsafe assumptions about ctype_base::mask
2012-01-06 0:08 [Bug libstdc++/51772] New: --enable-clocale=generic makes unsafe assumptions about ctype_base::mask redi at gcc dot gnu.org
2012-01-06 13:20 ` [Bug libstdc++/51772] " paolo.carlini at oracle dot com
@ 2012-01-06 14:01 ` redi at gcc dot gnu.org
2012-01-06 18:10 ` redi at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2012-01-06 14:01 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51772
--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-01-06 14:00:52 UTC ---
Sorry for the tone, it might be that this is only really broken on netbsd, and
maybe using the ieee model there would fix the test failure - I need to
investigate further
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libstdc++/51772] --enable-clocale=generic makes unsafe assumptions about ctype_base::mask
2012-01-06 0:08 [Bug libstdc++/51772] New: --enable-clocale=generic makes unsafe assumptions about ctype_base::mask redi at gcc dot gnu.org
2012-01-06 13:20 ` [Bug libstdc++/51772] " paolo.carlini at oracle dot com
2012-01-06 14:01 ` redi at gcc dot gnu.org
@ 2012-01-06 18:10 ` redi at gcc dot gnu.org
2014-10-17 9:09 ` redi at gcc dot gnu.org
2024-07-28 5:56 ` Stromeko at nexgo dot de
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2012-01-06 18:10 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51772
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2012-01-06
Ever Confirmed|0 |1
Severity|normal |minor
--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-01-06 18:10:04 UTC ---
I see the actual problem now, it's not as bad as I initially thought (it was
late at night when I started debugging this!)
The code in generic/ctype_members.cc assumes that each ctype_base::mask
constant will either be a single bit, or be the bitwise-or of other
ctype_base::mask constants, which works because e.g. if alnum is
upper|lower|digit, then do_is(alnum, L'c') will match on lower.
But netbsd defines ctype_base::xdigit as _N|_X where _N is ctype_base::digit
but _X corresponds to [A-Fa-f] and is not used in any other ctype_base::mask
constant, so the wide characters [A-Fa-f] cannot be matched by xdigit.
newlib similarly uses _X|_N for xdigit, but has --enable-clocale=newlib so
doesn't use the generic code.
bionic uses _X|_N but I don't think it supports wchar_t anyway
I believe vxworks and qnx would fail to match is(ctype::space, L' ') and
is(ctype::print, L' ') for similar reasons, if they support wchar_t
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libstdc++/51772] --enable-clocale=generic makes unsafe assumptions about ctype_base::mask
2012-01-06 0:08 [Bug libstdc++/51772] New: --enable-clocale=generic makes unsafe assumptions about ctype_base::mask redi at gcc dot gnu.org
` (2 preceding siblings ...)
2012-01-06 18:10 ` redi at gcc dot gnu.org
@ 2014-10-17 9:09 ` redi at gcc dot gnu.org
2024-07-28 5:56 ` Stromeko at nexgo dot de
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2014-10-17 9:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51772
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
In config/locale/newlib/ctype_members.cc:
default:
// Different from the generic version, xdigit and print in
// newlib are defined as bitwise-OR result of bitmasks:
// xdigit = _X | _N;
// print = _P | _U | _L | _N | _B;
// in which _X and _B don't correspond to any ctype mask.
// In order to get the wmask correctly converted when __m is
// equal to _X or _B, the two cases are specifically handled
// here.
if (__m & xdigit)
__ret = wctype("xdigit");
else if (__m & print)
__ret = wctype("print");
else
__ret = __wmask_type();
}
This doesn't only apply to the masks defined in config/os/newlib/ctype_base.h,
but also netbsd and openbsd and bionic.
Something similar is also needed for qnx, as config/os/qnx/qnx6.1/ctype_base.h
uses several bitmasks that do not correspond to any ctype, e.g. _XA, _SP, _XS,
_XB
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libstdc++/51772] --enable-clocale=generic makes unsafe assumptions about ctype_base::mask
2012-01-06 0:08 [Bug libstdc++/51772] New: --enable-clocale=generic makes unsafe assumptions about ctype_base::mask redi at gcc dot gnu.org
` (3 preceding siblings ...)
2014-10-17 9:09 ` redi at gcc dot gnu.org
@ 2024-07-28 5:56 ` Stromeko at nexgo dot de
4 siblings, 0 replies; 6+ messages in thread
From: Stromeko at nexgo dot de @ 2024-07-28 5:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51772
ASSI <Stromeko at nexgo dot de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Stromeko at nexgo dot de
--- Comment #5 from ASSI <Stromeko at nexgo dot de> ---
Related bugs on Cygwin (and other newlib platforms):
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115524
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104587
Building gcc using '--with-clocale=newlib' for Cygwin (and presumably other
newlib platforms) fixes it, but the configury should recognize this need
automatically.
^ permalink raw reply [flat|nested] 6+ messages in thread