From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7366 invoked by alias); 1 Mar 2012 00:23:08 -0000 Received: (qmail 7357 invoked by uid 22791); 1 Mar 2012 00:23:07 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Mar 2012 00:22:54 +0000 From: "bkoz at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/51785] gets not anymore declared Date: Thu, 01 Mar 2012 00:23:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libstdc++ X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: bkoz at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-03/txt/msg00000.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51785 --- Comment #19 from Benjamin Kosnik 2012-03-01 00:21:11 UTC --- Created attachment 26794 --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26794 gets conditionally declared/used Here's a way to deal with gets that is pretty simple. If it's around at configure time, it's used. If not, it's dropped from . This uses the same configure bits and approach used for math. This should prevent any compile error at bootstrap time. That seems sufficient for gcc-4.7 release. RMs? Note, I'm on f17 and I'm not running into this during make/check of trunk gcc. If somebody can give me self-contained sources that fail on f17 it would be appreciated. Please don't put in GLIBC macros to cstdio. Boo. Instead, if you need to layer on a glibc part to this, you should start with this patch, and then conditionally define/undefine _GLIBCXX_HAVE_GETS in libstdc++-v3/config/os/gnu-linux/os_defines.h based on the glibc prerequisites and version checks. -benjamin