From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-381366-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 13038 invoked by alias); 26 Jan 2012 13:59:35 -0000
Received: (qmail 13026 invoked by uid 22791); 26 Jan 2012 13:59:34 -0000
X-SWARE-Spam-Status: No, hits=-2.9 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Jan 2012 13:59:21 +0000
From: "amacleod at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/51798] [4.7 regression] libstdc++ atomicity performance regression due to __sync_fetch_and_add
Date: Thu, 26 Jan 2012 14:38:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: amacleod at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.7.0
X-Bugzilla-Changed-Fields:
Message-ID: <bug-51798-4-UI2ZgyVBrn@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-51798-4@http.gcc.gnu.org/bugzilla/>
References: <bug-51798-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2012-01/txt/msg03041.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51798

--- Comment #12 from Andrew Macleod <amacleod at redhat dot com> 2012-01-26 13:57:56 UTC ---
(In reply to comment #11)
> What about the other files that use __sync_* in libstdc++?

I would change the bare minimum... Every change is a risk of some sort this
late n the game.   The only reason to consider this change was the unacceptable
performance regression on power which was reported.   If it hasn't been
reported, I'd leave it alone personally :-)

I hope to replace *all* __sync calls everywhere in the toolchain with __atomic
for 4.8. That way there is also time to evaluate the proper model for each one
and test it.