[Bug target/51819] New: [4.7 Regression ]Neon wrong code generation, Error: unsupported alignment for instruction -- `vst1.32 {d2[0]},[r0:64]'

[Bug target/51819] New: [4.7 Regression ]Neon wrong code generation, Error: unsupported alignment for instruction -- `vst1.32 {d2[0]},[r0:64]'

[thejes.k at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51819

             Bug #: 51819
           Summary: [4.7 Regression ]Neon wrong code generation, Error:
                    unsupported alignment for instruction -- `vst1.32
                    {d2[0]},[r0:64]'
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: thejes.k@gmail.com
            Target: arm


With the gcc,
xgcc (4.7.0 20111217 (experimental) 

I tried to compile the code "gcc/testsuite/gcc.dg/vect/vect-double-reduc-6.c"
with neon options as shown below,

Command Line:

$ gcc-4.7-20111217/host-i686-pc-linux-gnu/gcc/xgcc
-B./gcc-4.7-20111217/host-i686-pc-linux-gnu/gcc vect-double-reduc-6.c
-ftree-vectorize -fno-vect-cost-model -ffast-math -O2 -funroll-loops
-fdump-tree-vect-details  -lm  -march=armv7-a -mthumb -mfpu=neon
-mfloat-abi=softfp  -o ./vect-double-reduc-6.exe 

/tmp/ccsaDvPz.s: Assembler messages: 
/tmp/ccsaDvPz.s:132: Error: unsupported alignment for instruction -- `vst1.32
{d2[0]},[r0:64]' 

I could not reproduce this issue with gcc-4.5-20111215 or  gcc-4.6-20111216 .
It seems this issue is caused by the revision 172314
http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01996.html.

This patch is not merged to gcc 4.5 or 4.6 also.

[Bug target/51819] [4.7 Regression] Neon wrong code generation, Error: unsupported alignment for instruction -- `vst1.32 {d2[0]},[r0:64]'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51819

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.7.0
            Summary|[4.7 Regression ]Neon wrong |[4.7 Regression] Neon wrong
                   |code generation, Error:     |code generation, Error:
                   |unsupported alignment for   |unsupported alignment for
                   |instruction -- `vst1.32     |instruction -- `vst1.32
                   |{d2[0]},[r0:64]'            |{d2[0]},[r0:64]'

[Bug target/51819] [4.7 Regression] Neon wrong code generation, Error: unsupported alignment for instruction -- `vst1.32 {d2[0]},[r0:64]'

[ramana at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51819

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-01-11
                 CC|                            |ramana at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #1 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> 2012-01-11 14:51:37 UTC ---

Completely untested but I think this is the correct fix for this problem. 




diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
index 4c310d4..31f03cc 100644
--- a/gcc/config/arm/arm.c
+++ b/gcc/config/arm/arm.c
@@ -17720,7 +17720,7 @@ arm_print_operand (FILE *stream, rtx x, int code)
          align_bits = 256;
        else if ((memsize == 8 || memsize == 16) && (align % 16) == 0)
          align_bits = 128;
-       else if ((align % 8) == 0)
+       else if ((memsize >= 8) && (align % 8) == 0)
          align_bits = 64;
        else
          align_bits = 0;

[Bug target/51819] [4.7 Regression] Neon wrong code generation, Error: unsupported alignment for instruction -- `vst1.32 {d2[0]},[r0:64]'

[thejes.k at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51819

--- Comment #2 from Thejes Kuttian <thejes.k at gmail dot com> 2012-01-13 05:32:48 UTC ---
(In reply to comment #1)
> Completely untested but I think this is the correct fix for this problem. 
> 
> 
> 
> 
> diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
> index 4c310d4..31f03cc 100644
> --- a/gcc/config/arm/arm.c
> +++ b/gcc/config/arm/arm.c
> @@ -17720,7 +17720,7 @@ arm_print_operand (FILE *stream, rtx x, int code)
>           align_bits = 256;
>         else if ((memsize == 8 || memsize == 16) && (align % 16) == 0)
>           align_bits = 128;
> -       else if ((align % 8) == 0)
> +       else if ((memsize >= 8) && (align % 8) == 0)
>           align_bits = 64;
>         else
>           align_bits = 0;

Confirmed. This patch fixes the issue for me .

[Bug target/51819] [4.7 Regression] Neon wrong code generation, Error: unsupported alignment for instruction -- `vst1.32 {d2[0]},[r0:64]'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51819

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|arm                         |arm-*-*
           Priority|P3                          |P1

--- Comment #3 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-01-19 12:51:33 UTC ---
Ping?

[Bug target/51819] [4.7 Regression] Neon wrong code generation, Error: unsupported alignment for instruction -- `vst1.32 {d2[0]},[r0:64]'

[ramana at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51819

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug target/51819] [4.7 Regression] Neon wrong code generation, Error: unsupported alignment for instruction -- `vst1.32 {d2[0]},[r0:64]'

[ramana at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51819

--- Comment #4 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> 2012-01-20 13:24:53 UTC ---
Author: ramana
Date: Fri Jan 20 13:24:47 2012
New Revision: 183338

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183338
Log:

Fix PR target/51819 


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/arm.c

[Bug target/51819] [4.7 Regression] Neon wrong code generation, Error: unsupported alignment for instruction -- `vst1.32 {d2[0]},[r0:64]'

[ramana at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51819

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> 2012-01-20 13:26:14 UTC ---
Fixed. .

[Bug target/51819] [4.7 Regression] Neon wrong code generation, Error: unsupported alignment for instruction -- `vst1.32 {d2[0]},[r0:64]'

[uweigand at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51819

--- Comment #6 from Ulrich Weigand <uweigand at gcc dot gnu.org> 2012-04-16 15:19:47 UTC ---
Author: uweigand
Date: Mon Apr 16 15:19:43 2012
New Revision: 186498

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186498
Log:
2012-04-16  Ulrich Weigand  <ulrich.weigand@linaro.org>

    PR target/51819
    * config/arm/arm.c (arm_print_operand): Fix invalid alignment
    hints for 'A' operand types.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/arm.c