public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "amker.cheng at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/51835] ARM EABI violation when passing arguments to helper floating functions like __aeabi_d2iz
Date: Mon, 06 Feb 2012 05:52:00 -0000	[thread overview]
Message-ID: <bug-51835-4-leCoRURa3h@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-51835-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51835

--- Comment #6 from amker.cheng <amker.cheng at gmail dot com> 2012-02-06 05:51:25 UTC ---
(In reply to comment #5)
> (In reply to comment #2)
> > This is only applicable to the 4.6 branch and trunk since support for the
> > Cortex M4 wasn't added till 4.6. 
> > 
> > cheers
> > Ramana
> 
> Maybe the Cortex M4 wasn't added until 4.6, but the other options are permitted
> by 4.5 and I can easily get 4.5 to produce wrong-looking code.  With -O2
> -mfloat-abi=hard -mfpu=fpv4-sp-d16 -march=armv7-a -marm I see the following
> code generation difference between 4.5 and 4.6:
> 
> @@ -22,8 +22,9 @@
>         @ frame_needed = 0, uses_anonymous_args = 0
>         stmfd   sp!, {r3, lr}
>         bl      __aeabi_f2d
> +       fmrrd   r0, r1, d0
>         bl      __aeabi_d2iz
>         ldmfd   sp!, {r3, pc}
>         .size   func, .-func
> -       .ident  "GCC: (GNU) 4.5.4 20120126 (prerelease)"
> +       .ident  "GCC: (GNU) 4.6.3 20120203 (prerelease)"
>         .section        .note.GNU-stack,"",%progbits
> 
> Backporting r183734 from 4.6 to 4.5 makes 4.5 generate the same code as 4.6,
> i.e., with the fmrrd between the two calls.

beside this patch, Julian Brown's patch r174803 is necessary too.

For now,
1, arguments for both __aeabi_f2d and __aeabi_d2iz are wrong in 4.5;
2, arguments for __aeabi_f2d is wrong in 4.6
To solve this, have to:
1, backport r183734 and r174803 to 4.5;
2, backport r174803 to 4.6;


  parent reply	other threads:[~2012-02-06  5:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-12  8:01 [Bug target/51835] New: " amker.cheng at gmail dot com
2012-01-16  9:50 ` [Bug target/51835] " rearnsha at gcc dot gnu.org
2012-01-19 23:08 ` ramana at gcc dot gnu.org
2012-01-30 18:05 ` jye2 at gcc dot gnu.org
2012-01-30 18:35 ` jye2 at gcc dot gnu.org
2012-02-05 14:08 ` mikpe at it dot uu.se
2012-02-06  5:52 ` amker.cheng at gmail dot com [this message]
2012-02-10  3:15 ` amker at gcc dot gnu.org
2012-02-14  7:43 ` amker at gcc dot gnu.org
2012-02-23  2:43 ` ramana at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-51835-4-leCoRURa3h@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).