public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug libitm/51855] New: improve calculation of stack bottom in libitm's undolog
@ 2012-01-13 23:36 torvald at gcc dot gnu.org
2012-01-13 23:38 ` [Bug libitm/51855] " torvald at gcc dot gnu.org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: torvald at gcc dot gnu.org @ 2012-01-13 23:36 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51855
Bug #: 51855
Summary: improve calculation of stack bottom in libitm's
undolog
Classification: Unclassified
Product: gcc
Version: 4.7.0
Status: UNCONFIRMED
Severity: minor
Priority: P3
Component: libitm
AssignedTo: torvald@gcc.gnu.org
ReportedBy: torvald@gcc.gnu.org
CC: aldyh@gcc.gnu.org, rth@gcc.gnu.org
It would be good to improve how libitm calculates the bottom of the stack space
of the current thread. It needs to do that to prevent rolling back
transactional writes to this space because this would corrupt the stack frames
of the transaction rollback functions. For 4.7, we handle this with
__builtin_dwarf_cfa() and an additional buffer zone of 256 bytes to deal with
another __builtin_memcpy() call that we need during rollback and whose stack
frame size we can't measure at runtime. For 4.8, we should think about
improving that, perhaps based on the existing boehm-gc code for this
(GC_get_stack_base() in os_dep.c).
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libitm/51855] improve calculation of stack bottom in libitm's undolog 2012-01-13 23:36 [Bug libitm/51855] New: improve calculation of stack bottom in libitm's undolog torvald at gcc dot gnu.org @ 2012-01-13 23:38 ` torvald at gcc dot gnu.org 2012-01-13 23:47 ` pinskia at gcc dot gnu.org ` (5 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: torvald at gcc dot gnu.org @ 2012-01-13 23:38 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51855 torvald at gcc dot gnu.org changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 |P4 Status|UNCONFIRMED |ASSIGNED Last reconfirmed| |2012-01-13 Target Milestone|--- |4.8.0 Ever Confirmed|0 |1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libitm/51855] improve calculation of stack bottom in libitm's undolog 2012-01-13 23:36 [Bug libitm/51855] New: improve calculation of stack bottom in libitm's undolog torvald at gcc dot gnu.org 2012-01-13 23:38 ` [Bug libitm/51855] " torvald at gcc dot gnu.org @ 2012-01-13 23:47 ` pinskia at gcc dot gnu.org 2012-01-13 23:53 ` torvald at gcc dot gnu.org ` (4 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: pinskia at gcc dot gnu.org @ 2012-01-13 23:47 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51855 --- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-01-13 23:41:44 UTC --- Hmm, do you know if this works with a split stack? ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libitm/51855] improve calculation of stack bottom in libitm's undolog 2012-01-13 23:36 [Bug libitm/51855] New: improve calculation of stack bottom in libitm's undolog torvald at gcc dot gnu.org 2012-01-13 23:38 ` [Bug libitm/51855] " torvald at gcc dot gnu.org 2012-01-13 23:47 ` pinskia at gcc dot gnu.org @ 2012-01-13 23:53 ` torvald at gcc dot gnu.org 2013-03-22 14:45 ` jakub at gcc dot gnu.org ` (3 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: torvald at gcc dot gnu.org @ 2012-01-13 23:53 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51855 --- Comment #2 from torvald at gcc dot gnu.org 2012-01-13 23:45:12 UTC --- Author: torvald Date: Fri Jan 13 23:45:06 2012 New Revision: 183172 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183172 Log: libitm: Filter out undo writes that overlap with the libitm stack. PR libitm/51855 * config/generic/tls.h (GTM::mask_stack_top): New. (GTM::mask_stack_bottom): Declare. * config/generic/tls.c (GTM::mask_stack_bottom): New. * local.cc (gtm_undolog::rollback): Filter out any updates that overlap the libitm stack. Add current transaction as parameter. * libitm_i.h (GTM::gtm_undolog::rollback): Adapt. * beginend.cc (GTM::gtm_thread::rollback): Adapt. * testsuite/libitm.c/stackundo.c: New test. Added: trunk/libitm/testsuite/libitm.c/stackundo.c Modified: trunk/libitm/ChangeLog trunk/libitm/beginend.cc trunk/libitm/config/generic/tls.cc trunk/libitm/config/generic/tls.h trunk/libitm/libitm_i.h trunk/libitm/local.cc ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libitm/51855] improve calculation of stack bottom in libitm's undolog 2012-01-13 23:36 [Bug libitm/51855] New: improve calculation of stack bottom in libitm's undolog torvald at gcc dot gnu.org ` (2 preceding siblings ...) 2012-01-13 23:53 ` torvald at gcc dot gnu.org @ 2013-03-22 14:45 ` jakub at gcc dot gnu.org 2013-05-31 11:01 ` jakub at gcc dot gnu.org ` (2 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: jakub at gcc dot gnu.org @ 2013-03-22 14:45 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51855 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.8.0 |4.8.1 --- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-03-22 14:44:17 UTC --- GCC 4.8.0 is being released, adjusting target milestone. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libitm/51855] improve calculation of stack bottom in libitm's undolog 2012-01-13 23:36 [Bug libitm/51855] New: improve calculation of stack bottom in libitm's undolog torvald at gcc dot gnu.org ` (3 preceding siblings ...) 2013-03-22 14:45 ` jakub at gcc dot gnu.org @ 2013-05-31 11:01 ` jakub at gcc dot gnu.org 2013-10-16 9:51 ` jakub at gcc dot gnu.org 2015-06-22 14:25 ` rguenth at gcc dot gnu.org 6 siblings, 0 replies; 8+ messages in thread From: jakub at gcc dot gnu.org @ 2013-05-31 11:01 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51855 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.8.1 |4.8.2 --- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> --- GCC 4.8.1 has been released. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libitm/51855] improve calculation of stack bottom in libitm's undolog 2012-01-13 23:36 [Bug libitm/51855] New: improve calculation of stack bottom in libitm's undolog torvald at gcc dot gnu.org ` (4 preceding siblings ...) 2013-05-31 11:01 ` jakub at gcc dot gnu.org @ 2013-10-16 9:51 ` jakub at gcc dot gnu.org 2015-06-22 14:25 ` rguenth at gcc dot gnu.org 6 siblings, 0 replies; 8+ messages in thread From: jakub at gcc dot gnu.org @ 2013-10-16 9:51 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51855 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.8.2 |4.8.3 --- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> --- GCC 4.8.2 has been released. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libitm/51855] improve calculation of stack bottom in libitm's undolog 2012-01-13 23:36 [Bug libitm/51855] New: improve calculation of stack bottom in libitm's undolog torvald at gcc dot gnu.org ` (5 preceding siblings ...) 2013-10-16 9:51 ` jakub at gcc dot gnu.org @ 2015-06-22 14:25 ` rguenth at gcc dot gnu.org 6 siblings, 0 replies; 8+ messages in thread From: rguenth at gcc dot gnu.org @ 2015-06-22 14:25 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51855 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.8.3 |--- ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-06-22 14:25 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2012-01-13 23:36 [Bug libitm/51855] New: improve calculation of stack bottom in libitm's undolog torvald at gcc dot gnu.org 2012-01-13 23:38 ` [Bug libitm/51855] " torvald at gcc dot gnu.org 2012-01-13 23:47 ` pinskia at gcc dot gnu.org 2012-01-13 23:53 ` torvald at gcc dot gnu.org 2013-03-22 14:45 ` jakub at gcc dot gnu.org 2013-05-31 11:01 ` jakub at gcc dot gnu.org 2013-10-16 9:51 ` jakub at gcc dot gnu.org 2015-06-22 14:25 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).