public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "krebbel at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/51860] [4.7 regression] s390 esa mode bootstrap comparison failure since transactional memory branch merge
Date: Mon, 16 Jan 2012 09:27:00 -0000	[thread overview]
Message-ID: <bug-51860-4-gdDU3vHfg1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-51860-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51860

--- Comment #7 from Andreas Krebbel <krebbel at gcc dot gnu.org> 2012-01-16 08:23:56 UTC ---
Regarding the insn address the split is supposed to happen after the call_insn
3059.

But the code I've added to keep the call_arg_location note after the call insn
prevents that:
      /* Make sure we do not split between a call and its
         corresponding CALL_ARG_LOCATION note.  */
      if (CALL_P (insn))
        {
          rtx next = NEXT_INSN (insn);
          if (next && NOTE_P (next)
          && NOTE_KIND (next) == NOTE_INSN_CALL_ARG_LOCATION)
        continue;
        }

Then the split should occur just after the call_arg_location note but that code
prevents that:

/* We can insert the barrier only after a 'real' insn.  */
  if (GET_CODE (insn) != INSN && GET_CODE (insn) != CALL_INSN)
    continue;

So the split in fact occurs after the next real insn which is the load zero.

(call_insn 3059 39956 39958 (parallel [
            (set (reg:SI 2 %r2)
                (call (mem:QI (reg/f:SI 11 %r11 [15205]) [0
identifier_global_value S1 A8])
                    (const_int 0 [0])))
            (clobber (reg:SI 14 %r14))
        ]) /build/gcc-head/gcc/c-family/c-common.c:5045 576 {*basr_r}
     (nil)
    (expr_list:REG_CFA_RESTORE (use (reg:SI 2 %r2))
        (nil)))

(note 39958 3059 37799 (nil) NOTE_INSN_CALL_ARG_LOCATION)

(insn 37799 39958 44088 (set (reg:SI 1 %r1 [5752])
        (const_int 0 [0])) /build/gcc-head/gcc/c-family/c-common.c:5045 67
{*movsi_esa}
     (nil))

(jump_insn 44088 37799 44089 (set (pc)
        (label_ref 44090)) /build/gcc-head/gcc/c-family/c-common.c:5045 561
{*jump31}
     (nil)


  parent reply	other threads:[~2012-01-16  8:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-14 13:28 [Bug bootstrap/51860] New: [4.7 regression] s390 esa mode bootstrap comparison failure since transactional memory branch krebbel at gcc dot gnu.org
2012-01-14 13:30 ` [Bug bootstrap/51860] [4.7 regression] s390 esa mode bootstrap comparison failure since transactional memory branch merge krebbel at gcc dot gnu.org
2012-01-15 19:06 ` jakub at gcc dot gnu.org
2012-01-15 20:37 ` jakub at gcc dot gnu.org
2012-01-15 20:44 ` krebbel at gcc dot gnu.org
2012-01-15 21:23 ` jakub at gcc dot gnu.org
2012-01-16  1:40 ` jakub at gcc dot gnu.org
2012-01-16  9:01 ` jakub at gcc dot gnu.org
2012-01-16  9:27 ` krebbel at gcc dot gnu.org [this message]
2012-01-16 11:13 ` jakub at gcc dot gnu.org
2012-01-16 13:29 ` jakub at gcc dot gnu.org
2012-01-16 14:16 ` jakub at gcc dot gnu.org
2012-01-16 14:21 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-51860-4-gdDU3vHfg1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).