From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-380348-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 25670 invoked by alias); 18 Jan 2012 19:20:13 -0000
Received: (qmail 25654 invoked by uid 22791); 18 Jan 2012 19:20:12 -0000
X-SWARE-Spam-Status: No, hits=-2.9 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jan 2012 19:19:58 +0000
From: "aravindvijayan224185 at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/51894] New: Fail to warn on likely precedence error in conditional
Date: Wed, 18 Jan 2012 20:00:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Keywords:
X-Bugzilla-Severity: minor
X-Bugzilla-Who: aravindvijayan224185 at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-51894-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2012-01/txt/msg02023.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51894

             Bug #: 51894
           Summary: Fail to warn on likely precedence error in conditional
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: c
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: aravindvijayan224185@gmail.com


Created attachment 26371
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26371
example program showing the failure to warn

example program showing the failure to warn:

gcc version 4.7.0

If you have:

if (ret = return_neg_one() == 1)
 printf("direct_test==true\n");
else
 printf("direct_test==false\n");

The compiler will warn:
/tmp/tmp.c:51:2: warning: suggest parentheses around assignment used as truth
value

But if it is a complex conditional:
if (!cond ||
    (ret = return_neg_one() == 1))

The compiler will not warn.  It seems it should warn in this case as well.