From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-382387-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 12185 invoked by alias); 3 Feb 2012 09:05:03 -0000
Received: (qmail 12128 invoked by uid 22791); 3 Feb 2012 09:05:01 -0000
X-SWARE-Spam-Status: No, hits=-2.9 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Feb 2012 09:04:49 +0000
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/51906] thread lock test failures on darwin11 under Xcode 4.2
Date: Fri, 03 Feb 2012 09:05:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: iains at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: redi at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.7.0
X-Bugzilla-Changed-Fields:
Message-ID: <bug-51906-4-3BjTsgWkD3@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-51906-4@http.gcc.gnu.org/bugzilla/>
References: <bug-51906-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2012-02/txt/msg00321.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51906

--- Comment #41 from Iain Sandoe <iains at gcc dot gnu.org> 2012-02-03 09:04:02 UTC ---
(In reply to comment #40)
> Created attachment 26558 [details]
> disable __GTHREAD_RECURSIVE_MUTEX_INIT for Lion
> 
> Thanks, Iain.
> 
> I'm thinking of something like this, which allows os_defines.h to set a macro
> which forces gthreads to use the init function if the macro is known to be
> problematic.  This should work for PR 51296 too


+#if __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ == 1070
+# define _GTHREAD_USE_RECURSIVE_MUTEX_INIT_FUNC
+#endif

unless the header is guaranteed only to be included for Darwin, then I'd guard
with a
 defined (__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__)

Hmm.. if we use >= then we don't need to keep amending when new OS Versions are
sent out - we're already at 1073 AFAIK.  OTOH, it means that someone needs to
keep an eye on when the fix is made and adjust this code then.

Don't have Lion here (yet) to test it, sorry.