From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11794 invoked by alias); 10 Aug 2013 11:28:39 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 11706 invoked by uid 48); 10 Aug 2013 11:28:35 -0000 From: "janus at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/51945] Diagnose wrong default initialization of DTs in a DT declaration Date: Sat, 10 Aug 2013 11:28:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: fortran X-Bugzilla-Version: 4.7.0 X-Bugzilla-Keywords: accepts-invalid, diagnostic X-Bugzilla-Severity: normal X-Bugzilla-Who: janus at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: janus at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2013-08/txt/msg00574.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51945 --- Comment #7 from janus at gcc dot gnu.org --- (In reply to janus from comment #6) > Btw, here is a variant which triggers an internal error similar to comment > 3, but already with a clean trunk: I guess one could just get rid of the internal error like this: Index: gcc/fortran/intrinsic.c =================================================================== --- gcc/fortran/intrinsic.c (revision 201631) +++ gcc/fortran/intrinsic.c (working copy) @@ -4430,7 +4430,7 @@ gfc_convert_type (gfc_expr *expr, gfc_typespec *ts The possible values are: 1 Generate a gfc_error() - 2 Generate a gfc_internal_error(). + 2 No error. 'wflag' controls the warning related to conversion. */ @@ -4574,27 +4574,16 @@ gfc_convert_type_warn (gfc_expr *expr, gfc_typespe if (gfc_is_constant_expr (expr->value.function.actual->expr) && !do_simplify (sym, expr)) - { + return false; /* Error already generated in do_simplify() */ - if (eflag == 2) - goto bad; - return false; /* Error already generated in do_simplify() */ - } - return true; bad: if (eflag == 1) - { - gfc_error ("Can't convert %s to %s at %L", - gfc_typename (&from_ts), gfc_typename (ts), &expr->where); - return false; - } + gfc_error ("Can't convert %s to %s at %L", + gfc_typename (&from_ts), gfc_typename (ts), &expr->where); - gfc_internal_error ("Can't convert %s to %s at %L", - gfc_typename (&from_ts), gfc_typename (ts), - &expr->where); - /* Not reached */ + return false; }