[Bug libstdc++/51956] New: [patch] improve shared_ptr and weak_ptr pretty-printers for gdb

[Bug libstdc++/51956] New: [patch] improve shared_ptr and weak_ptr pretty-printers for gdb

[b.r.longbons at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51956

             Bug #: 51956
           Summary: [patch] improve shared_ptr and weak_ptr
                    pretty-printers for gdb
    Classification: Unclassified
           Product: gcc
           Version: 4.6.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: b.r.longbons@gmail.com


Created attachment 26422
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26422
show weak count as well as strong

Some ignorant guy was complaining about how GDB was inferior because it didn't
print smart pointers and such "properly". Although we easily proved him wrong,
he *did* bring up that it would be nice to see the weak count as well as the
strong.

I don't even know python, but I managed to make this patch so it shows both the
strong and weak refcount.

I think this patch is trivial, so copyright assignment shouldn't be an issue.
But if it need be, just send me the form.

[Bug libstdc++/51956] [patch] improve shared_ptr and weak_ptr pretty-printers for gdb

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51956

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-01-23
         AssignedTo|unassigned at gcc dot       |redi at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1
           Severity|normal                      |enhancement

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-01-23 09:01:06 UTC ---
Thanks, I've been meaning to do that for some time.

[Bug libstdc++/51956] [patch] improve shared_ptr and weak_ptr pretty-printers for gdb

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51956

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-02-05 13:29:07 UTC ---
I think my preferred format is (count N + M weak)

(gdb) p sp
$2 = std::shared_ptr (count 1 + 1 weak) 0x602010
(gdb) p wp
$3 = std::weak_ptr (count 1 + 1 weak) 0x602010

I'm also going to make it print the type, shared_ptr<int> would be much more
helpful than just shared_ptr

[Bug libstdc++/51956] [patch] improve shared_ptr and weak_ptr pretty-printers for gdb

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51956

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-02-05 19:10:26 UTC ---
Author: redi
Date: Sun Feb  5 19:10:15 2012
New Revision: 183914

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183914
Log:
    PR libstdc++/51956
    * python/libstdcxx/v6/printers.py (StdPointerPrinter): Rename to...
    (SharedPointerPrinter): This. Also show weak count.
    * testsuite/libstdc++-prettyprinters/shared_ptr.cc: New.

Added:
    trunk/libstdc++-v3/testsuite/libstdc++-prettyprinters/shared_ptr.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/python/libstdcxx/v6/printers.py

[Bug libstdc++/51956] [patch] improve shared_ptr and weak_ptr pretty-printers for gdb

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51956

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.7.0

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-02-05 19:13:06 UTC ---
I didn't use your patch, as it printed the wrong thing for the weak count
(_M_weak_count is #weak + (#shared != 0) not #weak + #nshared)

now it prints one of:

(count N, M weak)
(expired, M weak) for an expired weak pointer
(empty)           for an empty pointer