From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19663 invoked by alias); 23 Jan 2012 15:27:17 -0000 Received: (qmail 19649 invoked by uid 22791); 23 Jan 2012 15:27:16 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Jan 2012 15:27:03 +0000 From: "paolo.carlini at oracle dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/51965] Redundant move constructions in heap algorithms Date: Mon, 23 Jan 2012 15:40:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libstdc++ X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: paolo.carlini at oracle dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-01/txt/msg02658.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51965 --- Comment #4 from Paolo Carlini 2012-01-23 15:26:34 UTC --- Indeed, I double checked that *before* changing the functions to use moves we had plain copies, that is the original HP/SGI functions had copies, nothing was passed by reference. Thus just doing what is suggested is unlikely to be correct.