[Bug target/51968] New: gcc trunk (ARM) ICEs in final_scan_insn in final.c:2716, with "could not split insn" error msg

[Bug target/51968] New: gcc trunk (ARM) ICEs in final_scan_insn in final.c:2716, with "could not split insn" error msg

[eric.batut at allegorithmic dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51968

             Bug #: 51968
           Summary: gcc trunk (ARM) ICEs in final_scan_insn in
                    final.c:2716, with "could not split insn" error msg
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: eric.batut@allegorithmic.com


Created attachment 26433
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26433
Preprocessed file that triggers the ICE

Trunk gcc compiled with Android's build-gcc.sh ICEs on the attached
preprocessed file.

The actual error message is:
../../../engine/src/filters/cpu/shader/jpeg_simd.cpp:753:1: error: could not
split insn
(insn 2104 4054 4050 (set (reg:V16QI 103 d20 [orig:846 D.35902 ] [846])
        (vec_concat:V16QI (reg:V8QI 103 d20 [2317])
            (reg:V8QI 105 d21 [2318])))
/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/lib/gcc/arm-linux-androideabi/4.7.0/include/arm_neon.h:5694
1348 {neon_vcombinev8qi}
     (nil))
../../../engine/src/filters/cpu/shader/jpeg_simd.cpp:753:1: internal compiler
error: in final_scan_insn, at final.c:2716


This is a regression caused by commit 183051, and breaks a lot of Neon code in
our codebase :)


cc1plus command:

cc1plus -fpreprocessed jpeg_simd.ii -quiet -dumpbase jpeg_simd.cpp -mandroid
-mbionic -march=armv7-a -mcpu=cortex-a9 -mfloat-abi=softfp -mfpu=vfp -mfpu=neon
-marm -mtls-dialect=gnu -auxbase-strip
tmp/obj/android-g++/release/cpushader_neon/jpeg_simd.o -O2 -O2
-Wno-unused-function -Wno-psabi -Werror=implicit-function-declaration -Wall
-Wextra -Wno-strict-aliasing -Wno-unused -Wno-switch -Wno-comment -version
-fpic -flax-vector-conversions -fdata-sections -ffunction-sections
-fno-short-enums -fno-exceptions -fno-rtti -fvisibility=hidden
-fvisibility-inlines-hidden -fno-strict-aliasing -fPIC -o jpeg_simd.s


gcc -v -save-temps yields:

Using built-in specs.
COLLECT_GCC=/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/bin/arm-linux-androideabi-g++
COLLECT_LTO_WRAPPER=/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/libexec/gcc/arm-linux-androideabi/4.7.0/lto-wrapper
Target: arm-linux-androideabi
Configured with: /home/eb/android-ndk-r6/src/build/../gcc/gcc-4.7.0/configure
--prefix=/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86
--target=arm-linux-androideabi --host=i386-linux-gnu --build=i386-linux-gnu
--with-gnu-as --with-gnu-ld --enable-languages=c,c++
--with-gmp=/tmp/ndk-eb/build/toolchain/temp-install
--with-mpfr=/tmp/ndk-eb/build/toolchain/temp-install
--with-mpc=/tmp/ndk-eb/build/toolchain/temp-install --disable-libssp
--enable-threads --disable-nls --disable-libmudflap --disable-libgomp
--disable-libstdc__-v3 --disable-sjlj-exceptions --disable-shared --disable-tls
--with-float=soft --with-fpu=vfp --with-arch=armv5te --enable-target-optspace
--enable-initfini-array --disable-nls
--prefix=/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86
--with-sysroot=/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/sysroot
--with-binutils-version=2.21.53 --with-mpfr-version=3.0.1
--with-gmp-version=5.0.2 --with-gcc-version=4.7.0 --with-gdb-version=6.6
--with-mpc-version=0.9 --with-arch=armv5te --enable-libstdc__-v3
--program-transform-name='s,^,arm-linux-androideabi-,'
Thread model: posix
gcc version 4.7.0 20120123 (experimental) (GCC) 
COLLECT_GCC_OPTIONS='-v' '-save-temps' '-c' '-mandroid' '-mbionic'
'-Wno-unused-function' '-Wno-psabi' '-march=armv7-a' '-mcpu=cortex-a9'
'-mfloat-abi=softfp' '-mfpu=vfp' '-fpic'
'-Werror=implicit-function-declaration' '-flax-vector-conversions'
'-fdata-sections' '-ffunction-sections' '-fno-short-enums' '-D' 'ANDROID' '-D'
'__ARM_ARCH_5__' '-D' '__ARM_ARCH_5T__' '-D' '__ARM_ARCH_5E__' '-D'
'__ARM_ARCH_5TE__' '-D' '__ARM_NEON__' '-D' 'S_IWRITE=0200' '-D'
'HAVE_USR_INCLUDE_MALLOC_H' '-D' 'MADV_FREE=5' '-D' 'LINUX' '-D'
'PAGE_SIZE=0x400' '-D' 'HAVE_PTHREAD_MUTEX_TIMEDLOCK' '-D' 'HAVE_SYS_SEM_H'
'-D' 'WEBPLUG=0' '-D' 'GAMERELEASE=1' '-D' 'DEBUGMODE=0' '-D' 'UNITY_RELEASE=1'
'-D' 'ENABLE_PROFILER=0' '-D' 'ANDROID' '-D' 'OS_ANDROID' '-D'
'_STLP_HAS_WCHAR_T' '-D' 'BOOST_NO_CWCHAR' '-D' 'ALG_DEBUG_SIMPLEOUTPUT' '-D'
'QT_NO_QWS_TRANSFORMED' '-fno-exceptions' '-fno-rtti' '-fvisibility=hidden'
'-fvisibility-inlines-hidden' '-mfpu=neon' '-O2' '-marm' '-O2'
'-fno-strict-aliasing' '-fPIC' '-D' '_REENTRANT' '-Wall' '-Wextra'
'-Wno-strict-aliasing' '-Wno-unused' '-Wno-switch' '-Wno-comment' '-D'
'ALG_MAIN_CPU_ON' '-D' 'FX_PRJ_RDXM' '-D' 'FX_PRJ_DXTENC' '-D' 'FX_PRJ_PVRENC'
'-D' 'FX_PRJ_ETC' '-D' 'emit=' '-D' 'NDEBUG' '-D' 'ALG_ISA_NEON' '-D'
'FX_ARCH_CURRENT_NEON' '-D' 'FX_ARCH_ON_NEON' '-D' 'ALG_DEBUG_SIMPLEOUTPUT'
'-I' '/usr/lib/qt4/mkspecs/android-g++' '-I' '.' '-I'
'../../../../common/components/include' '-I'
'/home/eb/android-ndk-r6/sources/cxx-stl/stlport/stlport' '-I'
'/home/eb/android-ndk-r6/platforms/android-9/arch-arm/usr/include' '-o'
'tmp/obj/android-g++/release/cpushader_neon/jpeg_simd.o' '-mtls-dialect=gnu'

/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/libexec/gcc/arm-linux-androideabi/4.7.0/cc1plus
-E -quiet -v -I /usr/lib/qt4/mkspecs/android-g++ -I . -I
../../../../common/components/include -I
/home/eb/android-ndk-r6/sources/cxx-stl/stlport/stlport -I
/home/eb/android-ndk-r6/platforms/android-9/arch-arm/usr/include -imultilib
armv7-a -D_GNU_SOURCE -D ANDROID -D __ARM_ARCH_5__ -D __ARM_ARCH_5T__ -D
__ARM_ARCH_5E__ -D __ARM_ARCH_5TE__ -D __ARM_NEON__ -D S_IWRITE=0200 -D
HAVE_USR_INCLUDE_MALLOC_H -D MADV_FREE=5 -D LINUX -D PAGE_SIZE=0x400 -D
HAVE_PTHREAD_MUTEX_TIMEDLOCK -D HAVE_SYS_SEM_H -D WEBPLUG=0 -D GAMERELEASE=1 -D
DEBUGMODE=0 -D UNITY_RELEASE=1 -D ENABLE_PROFILER=0 -D ANDROID -D OS_ANDROID -D
_STLP_HAS_WCHAR_T -D BOOST_NO_CWCHAR -D ALG_DEBUG_SIMPLEOUTPUT -D
QT_NO_QWS_TRANSFORMED -D _REENTRANT -D ALG_MAIN_CPU_ON -D FX_PRJ_RDXM -D
FX_PRJ_DXTENC -D FX_PRJ_PVRENC -D FX_PRJ_ETC -D emit= -D NDEBUG -D ALG_ISA_NEON
-D FX_ARCH_CURRENT_NEON -D FX_ARCH_ON_NEON -D ALG_DEBUG_SIMPLEOUTPUT
../../../engine/src/filters/cpu/shader/jpeg_simd.cpp -mandroid -mbionic
-march=armv7-a -mcpu=cortex-a9 -mfloat-abi=softfp -mfpu=vfp -mfpu=neon -marm
-mtls-dialect=gnu -Wno-unused-function -Wno-psabi
-Werror=implicit-function-declaration -Wall -Wextra -Wno-strict-aliasing
-Wno-unused -Wno-switch -Wno-comment -fpic -flax-vector-conversions
-fdata-sections -ffunction-sections -fno-short-enums -fno-exceptions -fno-rtti
-fvisibility=hidden -fvisibility-inlines-hidden -fno-strict-aliasing -fPIC -O2
-O2 -fpch-preprocess -o jpeg_simd.ii
ignoring nonexistent directory
"/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/lib/gcc/arm-linux-androideabi/4.7.0/../../../../arm-linux-androideabi/include/c++/4.7.0"
ignoring nonexistent directory
"/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/lib/gcc/arm-linux-androideabi/4.7.0/../../../../arm-linux-androideabi/include/c++/4.7.0/arm-linux-androideabi/armv7-a"
ignoring nonexistent directory
"/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/lib/gcc/arm-linux-androideabi/4.7.0/../../../../arm-linux-androideabi/include/c++/4.7.0/backward"
ignoring nonexistent directory
"/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/sysroot/usr/local/include"
#include "..." search starts here:
#include <...> search starts here:
 /usr/lib/qt4/mkspecs/android-g++
 .
 ../../../../common/components/include
 /home/eb/android-ndk-r6/sources/cxx-stl/stlport/stlport
 /home/eb/android-ndk-r6/platforms/android-9/arch-arm/usr/include

/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/lib/gcc/arm-linux-androideabi/4.7.0/include

/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/lib/gcc/arm-linux-androideabi/4.7.0/include-fixed

/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/lib/gcc/arm-linux-androideabi/4.7.0/../../../../arm-linux-androideabi/include

/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/sysroot/usr/include
End of search list.
COLLECT_GCC_OPTIONS='-v' '-save-temps' '-c' '-mandroid' '-mbionic'
'-Wno-unused-function' '-Wno-psabi' '-march=armv7-a' '-mcpu=cortex-a9'
'-mfloat-abi=softfp' '-mfpu=vfp' '-fpic'
'-Werror=implicit-function-declaration' '-flax-vector-conversions'
'-fdata-sections' '-ffunction-sections' '-fno-short-enums' '-D' 'ANDROID' '-D'
'__ARM_ARCH_5__' '-D' '__ARM_ARCH_5T__' '-D' '__ARM_ARCH_5E__' '-D'
'__ARM_ARCH_5TE__' '-D' '__ARM_NEON__' '-D' 'S_IWRITE=0200' '-D'
'HAVE_USR_INCLUDE_MALLOC_H' '-D' 'MADV_FREE=5' '-D' 'LINUX' '-D'
'PAGE_SIZE=0x400' '-D' 'HAVE_PTHREAD_MUTEX_TIMEDLOCK' '-D' 'HAVE_SYS_SEM_H'
'-D' 'WEBPLUG=0' '-D' 'GAMERELEASE=1' '-D' 'DEBUGMODE=0' '-D' 'UNITY_RELEASE=1'
'-D' 'ENABLE_PROFILER=0' '-D' 'ANDROID' '-D' 'OS_ANDROID' '-D'
'_STLP_HAS_WCHAR_T' '-D' 'BOOST_NO_CWCHAR' '-D' 'ALG_DEBUG_SIMPLEOUTPUT' '-D'
'QT_NO_QWS_TRANSFORMED' '-fno-exceptions' '-fno-rtti' '-fvisibility=hidden'
'-fvisibility-inlines-hidden' '-mfpu=neon' '-O2' '-marm' '-O2'
'-fno-strict-aliasing' '-fPIC' '-D' '_REENTRANT' '-Wall' '-Wextra'
'-Wno-strict-aliasing' '-Wno-unused' '-Wno-switch' '-Wno-comment' '-D'
'ALG_MAIN_CPU_ON' '-D' 'FX_PRJ_RDXM' '-D' 'FX_PRJ_DXTENC' '-D' 'FX_PRJ_PVRENC'
'-D' 'FX_PRJ_ETC' '-D' 'emit=' '-D' 'NDEBUG' '-D' 'ALG_ISA_NEON' '-D'
'FX_ARCH_CURRENT_NEON' '-D' 'FX_ARCH_ON_NEON' '-D' 'ALG_DEBUG_SIMPLEOUTPUT'
'-I' '/usr/lib/qt4/mkspecs/android-g++' '-I' '.' '-I'
'../../../../common/components/include' '-I'
'/home/eb/android-ndk-r6/sources/cxx-stl/stlport/stlport' '-I'
'/home/eb/android-ndk-r6/platforms/android-9/arch-arm/usr/include' '-o'
'tmp/obj/android-g++/release/cpushader_neon/jpeg_simd.o' '-mtls-dialect=gnu'

/home/eb/android-ndk-r6/toolchains/arm-linux-androideabi-4.7.0/prebuilt/linux-x86/libexec/gcc/arm-linux-androideabi/4.7.0/cc1plus
-fpreprocessed jpeg_simd.ii -quiet -dumpbase jpeg_simd.cpp -mandroid -mbionic
-march=armv7-a -mcpu=cortex-a9 -mfloat-abi=softfp -mfpu=vfp -mfpu=neon -marm
-mtls-dialect=gnu -auxbase-strip
tmp/obj/android-g++/release/cpushader_neon/jpeg_simd.o -O2 -O2
-Wno-unused-function -Wno-psabi -Werror=implicit-function-declaration -Wall
-Wextra -Wno-strict-aliasing -Wno-unused -Wno-switch -Wno-comment -version
-fpic -flax-vector-conversions -fdata-sections -ffunction-sections
-fno-short-enums -fno-exceptions -fno-rtti -fvisibility=hidden
-fvisibility-inlines-hidden -fno-strict-aliasing -fPIC -o jpeg_simd.s
GNU C++ (GCC) version 4.7.0 20120123 (experimental) (arm-linux-androideabi)
    compiled by GNU C version 4.6.0 20110603 (Red Hat 4.6.0-10), GMP version
5.0.2, MPFR version 3.0.1, MPC version 0.9
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
GNU C++ (GCC) version 4.7.0 20120123 (experimental) (arm-linux-androideabi)
    compiled by GNU C version 4.6.0 20110603 (Red Hat 4.6.0-10), GMP version
5.0.2, MPFR version 3.0.1, MPC version 0.9
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: 4654630ea77465d440d8a712bf4ed3eb

[Bug target/51968] gcc trunk (ARM) ICEs in final_scan_insn in final.c:2716, with "could not split insn" error msg

[eric.batut at allegorithmic dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51968

--- Comment #1 from Eric Batut <eric.batut at allegorithmic dot com> 2012-01-23 17:36:50 UTC ---
Adding Richard Henderson, who committed rev 183051.

[Bug target/51968] gcc trunk (ARM) ICEs in final_scan_insn in final.c:2716, with "could not split insn" error msg

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51968

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-01-23
         AssignedTo|unassigned at gcc dot       |rth at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #2 from Richard Henderson <rth at gcc dot gnu.org> 2012-01-23 18:14:43 UTC ---
Mine

[Bug target/51968] gcc trunk (ARM) ICEs in final_scan_insn in final.c:2716, with "could not split insn" error msg

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51968

--- Comment #3 from Richard Henderson <rth at gcc dot gnu.org> 2012-01-23 18:31:51 UTC ---
Created attachment 26436
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26436
proposed patch

I'll run this through a cross-build first, but I expect this will fix it.

[Bug target/51968] gcc trunk (ARM) ICEs in final_scan_insn in final.c:2716, with "could not split insn" error msg

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51968

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-01-23 21:51:20 UTC ---
Reduced testcase:

/* PR target/51968 */
/* { dg-do compile } */
/* { dg-options "-O2 -march=armv7-a -mfloat-abi=softfp -mfpu=neon" } */
/* { dg-require-effective-target arm_neon_ok } */

typedef __builtin_neon_qi int8x8_t __attribute__ ((__vector_size__ (8)));
typedef __builtin_neon_uqi uint8x8_t __attribute__ ((__vector_size__ (8)));
typedef __builtin_neon_qi int8x16_t __attribute__ ((__vector_size__ (16)));
typedef __builtin_neon_hi int16x8_t __attribute__ ((__vector_size__ (16)));
typedef __builtin_neon_si int32x4_t __attribute__ ((__vector_size__ (16)));
struct T { int8x8_t val[2]; };
int y;

void
foo (int8x8_t z, int8x8_t x, int16x8_t b, int8x8_t n)
{
  if (y)
    {
      struct T m;
      __builtin_neon_vuzpv8qi (&m.val[0], z, x);
    }
  for (;;)
    {
      int8x16_t g;
      int8x8_t h, j, k;
      struct T m;
      j = __builtin_neon_vqmovunv8hi (b, 1);
      g = __builtin_neon_vcombinev8qi (j, h);
      k = __builtin_neon_vget_lowv16qi (g);
      __builtin_neon_vuzpv8qi (&m.val[0], k, n);
    }
}

[Bug target/51968] gcc trunk (ARM) ICEs in final_scan_insn in final.c:2716, with "could not split insn" error msg

[eric.batut at allegorithmic dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51968

--- Comment #5 from Eric Batut <eric.batut at allegorithmic dot com> 2012-01-24 11:12:23 UTC ---
(In reply to comment #3)
> Created attachment 26436 [details]
> proposed patch
> 
> I'll run this through a cross-build first, but I expect this will fix it.

This patch makes gcc trunk no longer crash with our Neon files. Building right
now to test for code correctness, although judging from the patch the
functionality of the code should not be impacted.

Thanks Richard !

[Bug target/51968] gcc trunk (ARM) ICEs in final_scan_insn in final.c:2716, with "could not split insn" error msg

[eric.batut at allegorithmic dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51968

--- Comment #6 from Eric Batut <eric.batut at allegorithmic dot com> 2012-01-24 11:17:33 UTC ---
Our Neon codebase (lots of image processing filters) produce correct results
with the patch applied to the latest trunk rev.

[Bug target/51968] gcc trunk (ARM) ICEs in final_scan_insn in final.c:2716, with "could not split insn" error msg

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51968

--- Comment #7 from Richard Henderson <rth at gcc dot gnu.org> 2012-01-24 17:33:46 UTC ---
Author: rth
Date: Tue Jan 24 17:33:41 2012
New Revision: 183480

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183480
Log:
PR target/51968
        * config/arm/arm.c (neon_split_vcombine): Emit deleted note
        to effect no-op split.

Added:
    trunk/gcc/testsuite/gcc.target/arm/pr51968.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/arm.c

[Bug target/51968] gcc trunk (ARM) ICEs in final_scan_insn in final.c:2716, with "could not split insn" error msg

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51968

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Richard Henderson <rth at gcc dot gnu.org> 2012-01-24 17:41:33 UTC ---
Fixed.

[Bug target/51968] gcc trunk (ARM) ICEs in final_scan_insn in final.c:2716, with "could not split insn" error msg

[eric.batut at allegorithmic dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51968

--- Comment #9 from Eric Batut <eric.batut at allegorithmic dot com> 2012-01-25 09:43:01 UTC ---
(In reply to comment #8)
> Fixed.

Great, many thanks !