public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ktkachov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/51980] ARM - Neon code polluted by useless stores to the stack with vuzpq / vzipq / vtrnq
Date: Wed, 22 Jan 2014 12:19:00 -0000	[thread overview]
Message-ID: <bug-51980-4-3TMld25MFI@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-51980-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51980

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktkachov at gcc dot gnu.org

--- Comment #8 from ktkachov at gcc dot gnu.org ---
> arm-none-eabi-gcc -march=armv7-a -mfpu=neon -mfloat-abi=softfp -O2 -mthumb:
> sqrlen4D_16u8:
>         vmov    d18, r0, r1  @ v16qi
>         vmov    d19, r2, r3
>         vld1.64 {d16-d17}, [sp:64]
>         vabd.u8 q8, q9, q8
>         vmull.u8        q9, d16, d16
>         vmull.u8        q8, d17, d17
>         vuzp.32 q9, q8
>         vpaddl.u16      q9, q9
>         vmov    q10, q9  @ v4si
>         vpadal.u16      q10, q8
>         vmov    r0, r1, d20  @ v4si
>         vmov    r2, r3, d21
>         bx      lr

With current trunk I'm getting for the softfp case:

        push    {lr}    @ 40    *push_multi     [length = 2]
        vmov    d16, r0, r1  @ v16qi    @ 37    *neon_movv16qi/6        [length
= 8]
        vmov    d17, r2, r3
        add     lr, sp, #4      @ 36    *arm_addsi3/5   [length = 4]
        vldr    d18, [sp, #4]   @ 3     *neon_movv16qi/4        [length = 8]
        vldr    d19, [sp, #12]
        vabd.u8 q9, q8, q9      @ 7     neon_vabdv16qi  [length = 4]
        vmull.u8        q8, d18, d18    @ 14    neon_vmullv8qi  [length = 4]
        vmull.u8        q9, d19, d19    @ 16    neon_vmullv8qi  [length = 4]
        vuzp.32 q8, q9  @ 18    *neon_vuzpv4si_insn     [length = 4]
        vpaddl.u16      q8, q8  @ 22    neon_vpaddlv8hi [length = 4]
        vpadal.u16      q8, q9  @ 28    neon_vpadalv8hi [length = 4]
        vmov    r0, r1, d16  @ v4si     @ 39    *neon_movv4si/5 [length = 8]
        vmov    r2, r3, d17
        ldr     pc, [sp], #4    @ 45    *ldr_with_return        [length = 4]


The move between the vpad*s is gone, but there's a couple of redundant loads
and some register spillage.


  parent reply	other threads:[~2014-01-22 12:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-24 15:29 [Bug target/51980] New: " eric.batut at allegorithmic dot com
2012-01-24 15:31 ` [Bug target/51980] " rguenth at gcc dot gnu.org
2012-01-27 14:50 ` eric.batut at allegorithmic dot com
2012-01-27 15:51 ` ramana at gcc dot gnu.org
2012-03-30  8:18 ` ramana at gcc dot gnu.org
2012-03-30  8:40 ` ramana at gcc dot gnu.org
2012-07-05 16:46 ` ramana at gcc dot gnu.org
2013-05-28 19:30 ` mgretton at gcc dot gnu.org
2014-01-22 12:19 ` ktkachov at gcc dot gnu.org [this message]
2014-01-22 12:19 ` StaffLeavers at arm dot com
2014-01-22 12:20 ` StaffLeavers at arm dot com
2014-01-22 12:21 ` StaffLeavers at arm dot com
2014-01-22 12:22 ` StaffLeavers at arm dot com
2014-01-22 12:22 ` StaffLeavers at arm dot com
2014-06-13 15:38 ` christophe.lyon at st dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-51980-4-3TMld25MFI@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).