[Bug fortran/52038] New: [4.7 regression] fortran bootstrap failure: no previous prototype for 'symbol_as'

[Bug fortran/52038] New: [4.7 regression] fortran bootstrap failure: no previous prototype for 'symbol_as'

[mikpe at it dot uu.se]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52038

             Bug #: 52038
           Summary: [4.7 regression] fortran bootstrap failure: no
                    previous prototype for 'symbol_as'
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: mikpe@it.uu.se


Bootstrapping gcc-4.7-20120128 on i686-linux with fortran enabled and
--disable-build-poststage1-with-cxx fails in stage 2 due to:

/mnt/scratch/objdir47/./prev-gcc/xgcc -B/mnt/scratch/objdir47/./prev-gcc/
-B/mnt/scratch/install47/i686-pc-linux-gnu/bin/
-B/mnt/scratch/install47/i686-pc-linux-gnu/bin/
-B/mnt/scratch/install47/i686-pc-linux-gnu/lib/ -isystem
/mnt/scratch/install47/i686-pc-linux-gnu/include -isystem
/mnt/scratch/install47/i686-pc-linux-gnu/sys-include    -c  -DIN_GCC_FRONTEND
-g -O2 -gtoggle -DIN_GCC   -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual
-Wstrict-prototypes -Wmissing-prototypes -Wmissing-format-attribute -pedantic
-Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror
-Wold-style-definition -Wc++-compat   -DHAVE_CONFIG_H -I. -Ifortran
-I/mnt/scratch/gcc-4.7-20120128/gcc -I/mnt/scratch/gcc-4.7-20120128/gcc/fortran
-I/mnt/scratch/gcc-4.7-20120128/gcc/../include
-I/mnt/scratch/gcc-4.7-20120128/gcc/../libcpp/include
-I/home/mikpe/pkgs/linux-x86/gmp-5.0.3/include
-I/home/mikpe/pkgs/linux-x86/mpfr-3.1.0/include
-I/home/mikpe/pkgs/linux-x86/mpc-0.9/include 
-I/mnt/scratch/gcc-4.7-20120128/gcc/../libdecnumber
-I/mnt/scratch/gcc-4.7-20120128/gcc/../libdecnumber/bid -I../libdecnumber   
/mnt/scratch/gcc-4.7-20120128/gcc/fortran/resolve.c -o fortran/resolve.o
/mnt/scratch/gcc-4.7-20120128/gcc/fortran/resolve.c:1586:1: error: no previous
prototype for 'symbol_as' [-Werror=missing-prototypes]
cc1: all warnings being treated as errors

make[3]: *** [fortran/resolve.o] Error 1

The previous weekly snapshot, 4.7-20120121, bootstrapped fine.

Looking at the diff the reason is obvious: a non-static definition of
symbol_as() was added to resolve.c, but there's (a) no prototype for it, and
(b) no uses either.

Disabling symbol_as() with #if 0 / #endif allowed the bootstrap to complete.

[Bug fortran/52038] [4.7 regression] fortran bootstrap failure: no previous prototype for 'symbol_as'

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52038

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-01-29
                 CC|                            |burnus at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-01-29 11:54:51 UTC ---
Added (accidentally) with Rev. 183620 of 2012-01-27. The function is part of
the (uncommitted) patch for PR 50981.

[Bug fortran/52038] [4.7 regression] fortran bootstrap failure: no previous prototype for 'symbol_as'

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52038

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-01-29 11:56:23 UTC ---
Author: burnus
Date: Sun Jan 29 11:56:18 2012
New Revision: 183675

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183675
Log:
2012-01-29  Tobias Burnus  <burnus@net-b.de>

        PR fortran/52038
        * resolve.c (symbol_as): Remove unused, accidentally
        added function.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/resolve.c

[Bug fortran/52038] [4.7 regression] fortran bootstrap failure: no previous prototype for 'symbol_as'

[mikpe at it dot uu.se]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52038

Mikael Pettersson <mikpe at it dot uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Mikael Pettersson <mikpe at it dot uu.se> 2012-01-29 11:59:26 UTC ---
Thanks, closing as fixed.

[Bug fortran/52038] [4.7 regression] fortran bootstrap failure: no previous prototype for 'symbol_as'

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52038

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-01-29 11:59:59 UTC ---
FIXED on the trunk (4.7). Thanks for the report!

(In reply to comment #1)
> Added (accidentally) with Rev. 183620 of 2012-01-27
(That's for PR 52016.)

[Bug fortran/52038] [4.7 regression] fortran bootstrap failure: no previous prototype for 'symbol_as'

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52038

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikael at gcc dot gnu.org

--- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-01-29 12:04:35 UTC ---
> Added (accidentally) with Rev. 183620 of 2012-01-27. The function is part of
> the (uncommitted) patch for PR 50981.

AFAICT it was introduced to simplify constructs such as

+      if ((sym->as != NULL && sym->ts.type != BT_CLASS)
+      || (sym->ts.type == BT_CLASS && sym->attr.class_ok
+          && CLASS_DATA (sym)->as))

or

+      e->rank = sym->ts.type == BT_CLASS
+            ? CLASS_DATA (sym)->as->rank : sym->as->rank;

(see r183622) to

       if (symbol_as (sym) != NULL)
...
       gfc_array_spec *as = symbol_as (sym);

       e->rank = as->rank;

CCed Mikael Morin as a reminder to provide a prototype;-)

[Bug fortran/52038] [4.7 regression] fortran bootstrap failure: no previous prototype for 'symbol_as'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52038

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.7.0