[Bug target/52079] New: ICE in aggregate_value_p while building libgo on arm-linux-gnueabihf

[Bug target/52079] New: ICE in aggregate_value_p while building libgo on arm-linux-gnueabihf

[doko at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52079

             Bug #: 52079
           Summary: ICE in aggregate_value_p while building libgo on
                    arm-linux-gnueabihf
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: doko@gcc.gnu.org


20120131 trunk, configured with
--with-arch=armv7-a --with-float=hard --with-fpu=vfpv3-d16 --with-mode=thumb 
--build=arm-linux-gnueabihf --host=arm-linux-gnueabihf
--target=arm-linux-gnueabihf

(gdb) run
Starting program:
/scratch/packages/gcc/snap/gcc-snapshot-20120131/build/gcc/go1
../../../src/libgo/go/strconv/atob.go ../../../src/libgo/go/strconv/atof.go
../../../src/libgo/go/strconv/atoi.go ../../../src/libgo/go/strconv/decimal.go
../../../src/libgo/go/strconv/extfloat.go ../../../src/libgo/go/strconv/ftoa.go
../../../src/libgo/go/strconv/itoa.go ../../../src/libgo/go/strconv/quote.go
-quiet -dumpbase atob.go -march=armv7-a -mfloat-abi=hard -mfpu=vfpv3-d16
-mthumb -mtls-dialect=gnu -auxbase-strip strconv/.libs/strconv.o -g -O2
-version -fgo-prefix=libgo_strconv -fPIC -I .
-L/scratch/packages/gcc/snap/gcc-snapshot-20120131/build/./gcc
-L/lib/arm-linux-gnueabihf -L/usr/lib/arm-linux-gnueabihf -o /tmp/ccILwoBv.s
GNU Go (Ubuntu/Linaro 20120131-0ubuntu1) version 4.7.0 20120131 (experimental)
[trunk revision 183758] (arm-linux-gnueabihf)
        compiled by GNU C version 4.7.0 20120131 (experimental) [trunk revision
183758], GMP version 5.0.2, MPFR version 3.1.0-p3, MPC version 0.9
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
GNU Go (Ubuntu/Linaro 20120131-0ubuntu1) version 4.7.0 20120131 (experimental)
[trunk revision 183758] (arm-linux-gnueabihf)
        compiled by GNU C version 4.7.0 20120131 (experimental) [trunk revision
183758], GMP version 5.0.2, MPFR version 3.1.0-p3, MPC version 0.9
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096

Program received signal SIGSEGV, Segmentation fault.
0x00279eb6 in aggregate_value_p(tree_node const*, tree_node const*) ()

(gdb) bt
#0  0x00279eb6 in aggregate_value_p(tree_node const*, tree_node const*) ()
#1  0x001942d8 in emit_library_call_value_1(int, rtx_def*, rtx_def*,
libcall_type, machine_mode, int, std::__va_list) ()
#2  0x00197994 in emit_library_call_value(rtx_def*, rtx_def*, libcall_type,
machine_mode, int, ...) ()
#3  0x0030f086 in expand_twoval_binop_libfunc(optab_d*, rtx_def*, rtx_def*,
rtx_def*, rtx_def*, rtx_code) ()
#4  0x00217be0 in expand_divmod(int, tree_code, machine_mode, rtx_def*,
rtx_def*, rtx_def*, int) ()
#5  0x00228470 in expand_expr_real_2(separate_ops*, rtx_def*, machine_mode,
expand_modifier) ()
#6  0x0019ce00 in expand_gimple_stmt(gimple_statement_d*) ()
#7  0x0019e20e in expand_gimple_basic_block(basic_block_def*) ()
#8  0x0019f77a in gimple_expand_cfg() ()
#9  0x003201fc in execute_one_pass(opt_pass*) ()
#10 0x0032049c in execute_pass_list(opt_pass*) ()
#11 0x003dd67e in tree_rest_of_compilation(tree_node*) ()
#12 0x001b49ec in cgraph_expand_function(cgraph_node*) ()
#13 0x001b5fa0 in cgraph_optimize() ()
#14 0x001b645a in cgraph_finalize_compilation_unit() ()
#15 0x0012c70e in Gogo::write_globals() ()
#16 0x0039329a in toplev_main(int, char**) ()
#17 0xb6bdcc3a in __libc_start_main () from /lib/arm-linux-gnueabihf/libc.so.6
#18 0x0010a64e in _start ()

[Bug target/52079] ICE in aggregate_value_p while building libgo on arm-linux-gnueabihf

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52079

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-02-01
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-01 13:43:03 UTC ---
Created attachment 26542
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26542
gcc47-pr52079.patch

Untested fix.  While the c-family/fortran/lto/ada
lang_hooks.types.type_for_mode returns non-NULL for TImode (it creates a type
for 2 * HOST_BITS_PER_WIDE_INT bitsize), go (and assuming java too) just return
NULL.
This is an attempt to try harder in this case, another alternative would be for
go/java type_for_mode and type_for_size langhooks to return non-NULL for TImode
resp. 128-bit size (using build_nonstandard_integer_type), at least when
HOST_BITS_PER_WIDE_INT >= 64 (like other FEs do).

[Bug target/52079] ICE in aggregate_value_p while building libgo on arm-linux-gnueabihf

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52079

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-01 14:01:09 UTC ---
Created attachment 26543
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26543
gcc47-pr52079.patch

Alternate patch for the GO FE.  There are hundreds of other
lang_hooks.types.type_for_mode callers, so this variant seems to be safer to
me, at least at this point.

[Bug target/52079] ICE in aggregate_value_p while building libgo on arm-linux-gnueabihf

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52079

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26543|0                           |1
        is obsolete|                            |

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-01 14:17:54 UTC ---
Created attachment 26544
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26544
gcc47-pr52079-2.patch

The alternate patch for real this time.

[Bug target/52079] ICE in aggregate_value_p while building libgo on arm-linux-gnueabihf

[ian at airs dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52079

--- Comment #4 from Ian Lance Taylor <ian at airs dot com> 2012-02-01 14:22:36 UTC ---
The patch to gcc/go/go-lang.c is OK.  You don't need the #if as far as I'm
concerned.

(The whole idea of a frontend hook for type_for_mode is somewhat broken
anyhow.)

[Bug target/52079] ICE in aggregate_value_p while building libgo on arm-linux-gnueabihf

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52079

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-01 18:58:51 UTC ---
Author: jakub
Date: Wed Feb  1 18:58:44 2012
New Revision: 183806

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183806
Log:
    PR target/52079
    * go-lang.c (go_langhook_type_for_mode): For TImode and 64-bit HWI
    return build_nonstandard_integer_type result if possible.

Modified:
    trunk/gcc/go/ChangeLog
    trunk/gcc/go/go-lang.c

[Bug target/52079] ICE in aggregate_value_p while building libgo on arm-linux-gnueabihf

[doko at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52079

--- Comment #6 from Matthias Klose <doko at gcc dot gnu.org> 2012-02-02 08:30:34 UTC ---
builds with this patch; testsuite still running

[Bug target/52079] ICE in aggregate_value_p while building libgo on arm-linux-gnueabihf

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52079

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-02 08:34:00 UTC ---
Fixed then.