public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "LpSolit at netscape dot net" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/52080] Stores to bitfields introduce a store-data-race on adjacent data
Date: Tue, 19 Feb 2013 20:37:00 -0000	[thread overview]
Message-ID: <bug-52080-4-HovbEMOxaq@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-52080-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52080

--- Comment #15 from Richard Biener <rguenth at gcc dot gnu.org> 2012-06-04 08:43:31 UTC ---
Author: rguenth
Date: Mon Jun  4 08:43:23 2012
New Revision: 188167

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188167
Log:
2012-06-04  Richard Guenther  <rguenther@suse.de>
    Eric Botcazou  <ebotcazou@adacore.com>

    Backport from mainline
    2012-04-03  Eric Botcazou  <ebotcazou@adacore.com>

        * expr.c (get_bit_range): Add OFFSET parameter and adjust BITPOS.
        Change type of BITOFFSET to signed.  Make sure the lower bound of
        the computed range is non-negative by adjusting OFFSET and BITPOS.
        (expand_assignment): Adjust call to get_bit_range.

    2012-03-27  Eric Botcazou  <ebotcazou@adacore.com>

        * expr.c (get_bit_range): Return the null range if the enclosing record
        is part of a larger bit field.

    2012-03-20  Richard Guenther  <rguenther@suse.de>

        * stor-layout.c (finish_bitfield_representative): Fallback
        to conservative maximum size if the padding up to the next
        field cannot be computed as a constant.
        (finish_bitfield_layout): If we cannot compute the distance
        between the start of the bitfield representative and the
        bitfield member start a new representative.
        * expr.c (get_bit_range): The distance between the start of
        the bitfield representative and the bitfield member is zero
        if the field offsets are not constants.

    2012-03-16  Richard Guenther  <rguenther@suse.de>

        * stor-layout.c (finish_bitfield_representative): Fall back
        to the conservative maximum size if we cannot compute the
        size of the tail padding.

    2012-03-14  Richard Guenther  <rguenther@suse.de>

    * tree.h (DECL_BIT_FIELD_REPRESENTATIVE): New define.
    * stor-layout.c (start_bitfield_representative): New function.
    (finish_bitfield_representative): Likewise.
    (finish_bitfield_layout): Likewise.
    (finish_record_layout): Call finish_bitfield_layout.
    * tree.c (free_lang_data_in_decl): Only free DECL_QUALIFIER
    for QUAL_UNION_TYPE fields.
    * tree-streamer-in.c (lto_input_ts_field_decl_tree_pointers):
    Stream DECL_BIT_FIELD_REPRESENTATIVE.
    * tree-streamer-out.c (write_ts_field_decl_tree_pointers): Likewise.

    PR middle-end/52080
    PR middle-end/52097
    PR middle-end/48124
    * expr.c (get_bit_range): Unconditionally extract bitrange
    from DECL_BIT_FIELD_REPRESENTATIVE.
    (expand_assignment): Adjust call to get_bit_range.

    * gcc.dg/torture/pr48124-1.c: New testcase.
    * gcc.dg/torture/pr48124-2.c: Likewise.
    * gcc.dg/torture/pr48124-3.c: Likewise.
    * gcc.dg/torture/pr48124-4.c: Likewise.
    * gnat.dg/pack16.adb: Likewise.
    * gnat.dg/pack16_pkg.ads: Likewise.
    * gnat.dg/pack17.adb: Likewise.
    * gnat.dg/specs/pack7.ads: Likewise.
    * gnat.dg/specs/pack8.ads: Likewise.
    * gnat.dg/specs/pack8_pkg.ads: Likewise.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/torture/pr48124-1.c
    branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/torture/pr48124-2.c
    branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/torture/pr48124-3.c
    branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/torture/pr48124-4.c
    branches/gcc-4_7-branch/gcc/testsuite/gnat.dg/pack16.adb
    branches/gcc-4_7-branch/gcc/testsuite/gnat.dg/pack16_pkg.ads
    branches/gcc-4_7-branch/gcc/testsuite/gnat.dg/pack17.adb
    branches/gcc-4_7-branch/gcc/testsuite/gnat.dg/specs/pack7.ads
    branches/gcc-4_7-branch/gcc/testsuite/gnat.dg/specs/pack8.ads
    branches/gcc-4_7-branch/gcc/testsuite/gnat.dg/specs/pack8_pkg.ads
Modified:
    branches/gcc-4_7-branch/gcc/ChangeLog
    branches/gcc-4_7-branch/gcc/expr.c
    branches/gcc-4_7-branch/gcc/stor-layout.c
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_7-branch/gcc/tree-streamer-in.c
    branches/gcc-4_7-branch/gcc/tree-streamer-out.c
    branches/gcc-4_7-branch/gcc/tree.c
    branches/gcc-4_7-branch/gcc/tree.h


  parent reply	other threads:[~2013-02-19 20:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01 10:07 [Bug target/52080] New: " rguenth at gcc dot gnu.org
2012-02-01 10:23 ` [Bug target/52080] " rguenth at gcc dot gnu.org
2012-02-01 10:25 ` rguenth at gcc dot gnu.org
2012-02-01 10:39 ` rguenth at gcc dot gnu.org
2012-02-01 11:13 ` rguenth at gcc dot gnu.org
2012-02-01 17:12 ` ebotcazou at gcc dot gnu.org
2012-02-01 17:45 ` ebotcazou at gcc dot gnu.org
2012-02-01 17:50 ` matz at gcc dot gnu.org
2012-02-01 18:53 ` bergner at gcc dot gnu.org
2012-02-02 11:01 ` gcc-bugs at tesarici dot cz
2012-02-02 11:11 ` rguenth at gcc dot gnu.org
2012-02-02 12:40 ` gcc-bugs at tesarici dot cz
2012-02-21 12:04 ` rguenth at gcc dot gnu.org
2012-03-14 11:00 ` rguenth at gcc dot gnu.org
2012-03-14 11:01 ` rguenth at gcc dot gnu.org
2012-06-04  8:44 ` rguenth at gcc dot gnu.org
2013-02-19 20:37 ` LpSolit at netscape dot net [this message]
2014-02-16 13:17 ` jackie.rosen at hushmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-52080-4-HovbEMOxaq@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).