[Bug ada/52110] New: s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[Bug ada/52110] New: s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

             Bug #: 52110
           Summary: s-osinte.ads:447:09: "clockid_t" conflicts with
                    declaration at line 194
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: danglin@gcc.gnu.org
              Host: hppa1.1-hp-hpux10.20
            Target: hppa1.1-hp-hpux10.20
             Build: hppa1.1-hp-hpux10.20


/xxx/gnu/gcc/objdir/./gcc/xgcc -B/xxx/gnu/gcc/objdir/./gcc/
-B/opt/gnu/gcc/gcc-4.7/hppa1.1-hp-hpux10.20/bin/
-B/opt/gnu/gcc/gcc-4.7/hppa1.1-hp-hpux10.20/lib/ -isystem
/opt/gnu/gcc/gcc-4.7/hppa1.1-hp-hpux10.20/include -isystem
/opt/gnu/gcc/gcc-4.7/hppa1.1-hp-hpux10.20/sys-include    -c -g -O2   -W -Wall
-gnatpg -nostdinc   a-dynpri.adb -o a-dynpri.o
s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194
make[5]: *** [a-dynpri.o] Error 1

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

--- Comment #1 from John David Anglin <danglin at gcc dot gnu.org> 2012-02-03 16:21:17 UTC ---
Removing declaration at s-taspri-hpux-dce.ads, I get:

/xxx/gnu/gcc/objdir/./gcc/xgcc -B/xxx/gnu/gcc/objdir/./gcc/
-B/opt/gnu/gcc/gcc-4.7/hppa1.1-hp-hpux10.20/bin/
-B/opt/gnu/gcc/gcc-4.7/hppa1.1-hp-hpux10.20/lib/ -isystem
/opt/gnu/gcc/gcc-4.7/hppa1.1-hp-hpux10.20/include -isystem
/opt/gnu/gcc/gcc-4.7/hppa1.1-hp-hpux10.20/sys-include    -c -g -O2   -W -Wall
-gnatpg -nostdinc   a-dynpri.adb -o a-dynpri.o
s-taspri.ads:105:22: atomic access to "Thread" cannot be guaranteed
make[5]: *** [a-dynpri.o] Error 1

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

--- Comment #2 from dave.anglin at bell dot net 2012-02-04 01:40:27 UTC ---
Attached is a possible patch.  On "most" PARISC machines, reads and  
writes are strongly ordered and
possibly this meets the "atomic"  requirement.

--
John David Anglin    dave.anglin@bell.net

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-02-05
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org
     Ever Confirmed|0                           |1

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-02-05 19:12:36 UTC ---
> Attached is a possible patch.  On "most" PARISC machines, reads and  
> writes are strongly ordered and possibly this meets the "atomic"  requirement.

Not entirely I think, since the object is 64-bit wide.  Of course, it's a
little annoying to discover years later that the implementation wasn't really
correct.

So I'd leave s-taspri-hpux-dce.ads unchanged and just comment out the second
pragma Atomic, with a ??? saying that, historically, the pragma had been
silently accepted but actually ineffective.

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

--- Comment #4 from dave.anglin at bell dot net 2012-02-05 21:43:41 UTC ---
On 5-Feb-12, at 2:12 PM, ebotcazou at gcc dot gnu.org wrote:

> --- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org>  
> 2012-02-05 19:12:36 UTC ---
>> Attached is a possible patch.  On "most" PARISC machines, reads and
>> writes are strongly ordered and possibly this meets the "atomic"   
>> requirement.
>
> Not entirely I think, since the object is 64-bit wide.  Of course,  
> it's a
> little annoying to discover years later that the implementation  
> wasn't really
> correct.

It would be inefficient but it would be possible to implement 64-bit  
atomic loads
and stores using floating point double loads and stores.

> So I'd leave s-taspri-hpux-dce.ads unchanged and just comment out  
> the second
> pragma Atomic, with a ??? saying that, historically, the pragma had  
> been
> silently accepted but actually ineffective.


I'll give this a try but it will take a while to test.

Dave
--
John David Anglin    dave.anglin@bell.net

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

--- Comment #5 from dave.anglin at bell dot net 2012-03-03 15:35:44 UTC ---
Attached is updated change for hpux10.  Test results are here:
http://gcc.gnu.org/ml/gcc-testresults/2012-02/msg02575.html

--
John David Anglin    dave.anglin@bell.net

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

--- Comment #6 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-03-04 07:52:24 UTC ---
> Attached is updated change for hpux10.  Test results are here:
> http://gcc.gnu.org/ml/gcc-testresults/2012-02/msg02575.html

Does it change anything if you put a pragma Volatile in lieu of the Atomic?

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

--- Comment #7 from John David Anglin <danglin at gcc dot gnu.org> 2012-03-12 00:04:35 UTC ---
Build is successful with pragma Volatile in lieu of the Atomic.
However, test results appear similar:
http://gcc.gnu.org/ml/gcc-testresults/2012-03/msg01197.html

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

--- Comment #8 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-03-12 06:46:41 UTC ---
> Build is successful with pragma Volatile in lieu of the Atomic.
> However, test results appear similar:
> http://gcc.gnu.org/ml/gcc-testresults/2012-03/msg01197.html

OK, let's use pragma Volatile anyway, it's the closest approximation we have.

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.3.1

--- Comment #9 from John David Anglin <danglin at gcc dot gnu.org> 2012-11-26 00:47:46 UTC ---
Forgot about this...

Retested recently and pragma Volatile caused a compilation issue.  Plan to
commit the patch "add-hpux10-patch.txt" if there are no additional suggestions.

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.1                       |---

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

--- Comment #10 from John David Anglin <danglin at gcc dot gnu.org> 2012-12-01 19:43:08 UTC ---
Author: danglin
Date: Sat Dec  1 19:43:04 2012
New Revision: 194024

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194024
Log:
    PR ada/52110
    * s-osinte-hpux-dce.ads: Declare pthread_rwlockattr_t and
    pthread_rwlock_t subtypes.  Delete duplicate declaration of clockid_t.
    * s-taspri-hpux-dce.ads: Change "pragma Atomic (Thread)" to comment.


Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/s-osinte-hpux-dce.ads
    trunk/gcc/ada/s-taspri-hpux-dce.ads

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

--- Comment #11 from John David Anglin <danglin at gcc dot gnu.org> 2012-12-01 19:45:29 UTC ---
Author: danglin
Date: Sat Dec  1 19:45:24 2012
New Revision: 194025

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194025
Log:
    PR ada/52110
    * s-osinte-hpux-dce.ads: Declare pthread_rwlockattr_t and
    pthread_rwlock_t subtypes.  Delete duplicate declaration of clockid_t.
    * s-taspri-hpux-dce.ads: Change "pragma Atomic (Thread)" to comment.


Modified:
    branches/gcc-4_7-branch/gcc/ada/ChangeLog
    branches/gcc-4_7-branch/gcc/ada/s-osinte-hpux-dce.ads
    branches/gcc-4_7-branch/gcc/ada/s-taspri-hpux-dce.ads

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from John David Anglin <danglin at gcc dot gnu.org> 2012-12-01 19:47:08 UTC ---
Fixed.

[Bug ada/52110] s-osinte.ads:447:09: "clockid_t" conflicts with declaration at line 194

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52110

--- Comment #13 from John David Anglin <danglin at gcc dot gnu.org> 2012-12-07 00:59:58 UTC ---
Volatile fails for the following reason:

/xxx/gnu/gcc/objdir/./gcc/xgcc -B/xxx/gnu/gcc/objdir/./gcc/
-B/opt/gnu/gcc/gcc-4.8/hppa1.1-hp-hpux10.20/bin/
-B/opt/gnu/gcc/gcc-4.8/hppa1.1-hp-hpux10.20/lib/ -isystem
/opt/gnu/gcc/gcc-4.8/hppa1.1-hp-hpux10.20/include -isystem
/opt/gnu/gcc/gcc-4.8/hppa1.1-hp-hpux10.20/sys-include    -c -g -O2   -W -Wall
-gnatpg -nostdinc   s-taprop.adb -o s-taprop.o
s-taprop.adb:818:10: access to volatile object cannot yield
access-to-non-volatile type
s-taprop.adb:826:23: access to volatile object cannot yield
access-to-non-volatile type