public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/52116] pragma GCC diagnostic only acts on some lines
Date: Sat, 04 Feb 2012 11:10:00 -0000	[thread overview]
Message-ID: <bug-52116-4-WbCIyH00X8@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-52116-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52116

--- Comment #1 from Manuel López-Ibáñez <manu at gcc dot gnu.org> 2012-02-04 11:09:44 UTC ---
Created attachment 26572
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26572
patch to fix (2)

I am not surprised. Location information in GCC is not very precise. Have you
tested with GCC 4.7?

For 1), someone would need to look more closely at the locations recorded by
each pragma, and compare them with the locations of the diagnostic.

Fixing 2) is easier. Just check the output of the first diagnostic and only
emit the second if the output was true. Also, change the second warning() to
inform(). An untested patch attached. Feel free to take it, test it and submit
it. http://gcc.gnu.org/contribute.html


  reply	other threads:[~2012-02-04 11:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-03 19:35 [Bug c/52116] New: " b.r.longbons at gmail dot com
2012-02-04 11:10 ` manu at gcc dot gnu.org [this message]
2012-02-04 11:11 ` [Bug c/52116] " manu at gcc dot gnu.org
2012-02-04 18:31 ` b.r.longbons at gmail dot com
2012-02-04 18:41 ` manu at gcc dot gnu.org
2012-02-13 17:24 ` manu at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-52116-4-WbCIyH00X8@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).