From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-382542-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 2838 invoked by alias); 4 Feb 2012 16:05:39 -0000
Received: (qmail 2826 invoked by uid 22791); 4 Feb 2012 16:05:37 -0000
X-SWARE-Spam-Status: No, hits=-2.9 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 04 Feb 2012 16:05:23 +0000
From: "dcb314 at hotmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/52124] New: config/cr16/cr16.c: possibly redundant code
Date: Sat, 04 Feb 2012 16:05:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dcb314 at hotmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-52124-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2012-02/txt/msg00476.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52124

             Bug #: 52124
           Summary: config/cr16/cr16.c: possibly redundant code
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dcb314@hotmail.com


I just ran the static analysis checker cppcheck over the latest trunk code
and it said

[gcc/config/cr16/cr16.c:2024] -> [gcc/config/cr16/cr16.c:2024]: (style) Same
expression on both sides of '||'.

The source code is

  return (cfun->calls_alloca || crtl->calls_eh_return
      || cfun->has_nonlocal_label || crtl->calls_eh_return);

which looks to me like one too many mentions of crtl->calls_eh_return,
but may mean some other variable has been missed out.