public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "carrot at google dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/52129] New: wrong code to pass parameters to tail call function Date: Mon, 06 Feb 2012 01:17:00 -0000 [thread overview] Message-ID: <bug-52129-4@http.gcc.gnu.org/bugzilla/> (raw) http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52129 Bug #: 52129 Summary: wrong code to pass parameters to tail call function Classification: Unclassified Product: gcc Version: 4.7.0 Status: UNCONFIRMED Severity: major Priority: P3 Component: target AssignedTo: unassigned@gcc.gnu.org ReportedBy: carrot@google.com Target: arm-unknown-linux-gnueabi Created attachment 26578 --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26578 test case The attached test case is simplified from llvm. Compile it with options -march=armv7-a -mthumb -O2 -finline-limit=64, GCC 4.7 generates: ... 61 add r2, sp, #44 62 add r3, r1, r3, lsl #2 // A 63 mov r0, r7 // B 64 add r1, r1, r4, lsl #2 65 str r1, [sp, #48] // C 66 ldmia r2, {r1, r2} // D 67 add sp, sp, #20 68 pop {r4, r5, r6, r7, lr} 69 add sp, sp, #8 70 b _ZN15ARMDAGToDAGISel19SelectAddrModeImm12E7SDValueRS0_S1_ Instructions ABCD pass parameters to a tail call function, instruction C pass one parameter through stack. Instruction D read out two words from [sp+44] and [sp+48], it is also the passed in parameter N of the function itself. the second word overlaps with instruction C, it is unexpected, so the read out value of N is actually garbage, and cause runtime error. The bug is introduced in expand pass ... (insn 69 68 70 6 (set (mem:SI (plus:SI (reg/f:SI 128 virtual-incoming-args) (const_int 8 [0x8])) [0 S4 A32]) (reg:SI 176)) ARMISelDAGToDAG2.ii:45 -1 (nil)) (insn 70 69 71 6 (set (reg:SI 0 r0) (reg/f:SI 152 [ this ])) ARMISelDAGToDAG2.ii:45 -1 (nil)) (insn 71 70 72 6 (set (reg:SI 177) (plus:SI (reg/f:SI 128 virtual-incoming-args) (const_int 4 [0x4]))) ARMISelDAGToDAG2.ii:45 -1 (nil)) (insn 72 71 73 6 (parallel [ (set (reg:SI 1 r1) (mem/c:SI (reg:SI 177) [4 N+0 S4 A32])) (set (reg:SI 2 r2) (mem/c:SI (plus:SI (reg:SI 177) (const_int 4 [0x4])) [4 N+4 S4 A32])) ]) ARMISelDAGToDAG2.ii:45 -1 (nil)) (insn 73 72 74 6 (set (reg:SI 3 r3) (reg:SI 170)) ARMISelDAGToDAG2.ii:45 -1 (nil)) (call_insn/j 74 73 75 6 (parallel [ (set (reg:SI 0 r0) (call (mem:SI (symbol_ref:SI ("_ZN15ARMDAGToDAGISel19SelectAddrModeImm12E7SDValueRS0_S1_") [flags 0x41] <function_decl 0x7fcefe992800 SelectAddrModeImm12>) [0 SelectAddrModeImm12 S4 A32]) (const_int 4 [0x4]))) (return) (use (const_int 0 [0])) ]) ARMISelDAGToDAG2.ii:45 -1 (nil) (expr_list:REG_CFA_WINDOW_SAVE (use (reg:SI 3 r3)) (expr_list:REG_DEP_TRUE (use (reg:SI 2 r2)) (expr_list:REG_DEP_TRUE (use (reg:SI 1 r1)) (expr_list:REG_CFA_WINDOW_SAVE (use (reg:SI 0 r0)) (expr_list:REG_CFA_WINDOW_SAVE (use (mem/f:SI (plus:SI (reg/f:SI 128 virtual-incoming-args) (const_int 8 [0x8])) [0 S4 A32])) (nil))))))) ... insn 74 is a tail call, insns 69 to 73 are part of the parameter passing instructions. Because of large number of parameters, insn69 pass one parameter through stack. But this function itself contains some passed in parameters in the stack, and need to pass them again to the tail call function in insn 72. At this time the content of the stack has been overwritten by insn 69, so insn 72 read out wrong value, and will cause runtime error. The correct result should put insn 69 after insn 72 to avoid writing to the memory before using it. GCC 4.6 also contains this bug.
next reply other threads:[~2012-02-06 1:17 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-06 1:17 carrot at google dot com [this message] 2012-02-06 3:06 ` [Bug target/52129] " pinskia at gcc dot gnu.org 2012-02-06 8:03 ` jakub at gcc dot gnu.org 2012-02-06 9:47 ` jakub at gcc dot gnu.org 2012-02-06 13:33 ` jakub at gcc dot gnu.org 2012-02-06 13:35 ` jakub at gcc dot gnu.org 2012-02-09 17:29 ` jakub at gcc dot gnu.org 2012-02-09 17:48 ` jakub at gcc dot gnu.org 2012-02-18 14:01 ` mikpe at it dot uu.se
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-52129-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).