[Bug gcov-profile/52150] New: [4.7 regression] junk at end of line in Firefox PGO build

[Bug gcov-profile/52150] New: [4.7 regression] junk at end of line in Firefox PGO build

[markus at trippelsdorf dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52150

             Bug #: 52150
           Summary: [4.7 regression]  junk at end of line in Firefox PGO
                    build
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: gcov-profile
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: markus@trippelsdorf.de


Consider: 

 % cat test.i
typedef struct _cairo cairo_t;
cairo_t *_moz_cairo_create ();

__typeof (_moz_cairo_create)
_moz_cairo_create __asm__ ("INT__moz_cairo_create");
cairo_t *_moz_cairo_create ()
{
}

% gcc -c -fprofile-generate test.i
/tmp/ccwYenBS.s: Assembler messages:
/tmp/ccwYenBS.s:41: Error: junk at end of line, first unrecognized character is
`*'
/tmp/ccwYenBS.s:42: Error: bad expression
/tmp/ccwYenBS.s:42: Error: junk at end of line, first unrecognized character is
`I'
/tmp/ccwYenBS.s:66: Error: unrecognized symbol type ""
/tmp/ccwYenBS.s:66: Error: junk at end of line, first unrecognized character is
`*'
/tmp/ccwYenBS.s:67: Error: expected comma after name `__gcov__' in .size
directive
/tmp/ccwYenBS.s:68: Error: invalid character '*' in mnemonic
/tmp/ccwYenBS.s:76: Error: operation combines symbols in different segments

>From test.s:
 39 __gcov_indirect_call_counters:
 40         .zero   8 
 41         .local  __gcov0_*INT__moz_cairo_create
 42         .comm   __gcov0_*INT__moz_cairo_create,8,8
 43         .text 
 44         .type   _GLOBAL__sub_I_65535_0_INT__moz_cairo_create, @function

[Bug gcov-profile/52150] [4.7 regression] junk at end of line in Firefox PGO build

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52150

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |assemble-failure
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-02-07
      Known to work|                            |4.6.3
   Target Milestone|---                         |4.7.0
     Ever Confirmed|0                           |1
      Known to fail|                            |4.7.0

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-02-07 17:41:05 UTC ---
Confirmed.

[Bug gcov-profile/52150] [4.7 regression] junk at end of line in Firefox PGO build

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52150

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-02-07 17:42:41 UTC ---
The profiling code forgot to remove the * from the assembly name it looks like.
 The * means it is defined.

[Bug gcov-profile/52150] [4.7 regression] junk at end of line in Firefox PGO build

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52150

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jakub at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |

[Bug gcov-profile/52150] [4.7 regression] junk at end of line in Firefox PGO build

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52150

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-08 08:03:43 UTC ---
Started with http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181105

[Bug gcov-profile/52150] [4.7 regression] junk at end of line in Firefox PGO build

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52150

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-08 08:37:41 UTC ---
Created attachment 26607
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26607
gcc47-pr52150.patch

Untested fix.  I took the liberty to also overwrite the last _ with . or $,
so that at least when possible these artificial symbols don't clash with user
__gcov__foo etc. symbols (yeah, I know, they are reserved for implementation,
still the assembly would likely fail if those were used).

[Bug gcov-profile/52150] [4.7 regression] junk at end of line in Firefox PGO build

[markus at trippelsdorf dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52150

--- Comment #5 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2012-02-08 10:31:27 UTC ---
(In reply to comment #4)
> Created attachment 26607 [details]
> gcc47-pr52150.patch
> 
> Untested fix.  I took the liberty to also overwrite the last _ with . or $,
> so that at least when possible these artificial symbols don't clash with user
> __gcov__foo etc. symbols (yeah, I know, they are reserved for implementation,
> still the assembly would likely fail if those were used).

The patch fixes the issue and survived a full Firefox PGO build.
Thanks Jakub.

[Bug gcov-profile/52150] [4.7 regression] junk at end of line in Firefox PGO build

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52150

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-08 13:27:37 UTC ---
Author: jakub
Date: Wed Feb  8 13:27:31 2012
New Revision: 184006

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=184006
Log:
    PR gcov-profile/52150
    * coverage.c: Include target.h.
    (build_var): Call targetm.strip_name_encoding on the assembler name.
    Change one _ into . or $ if the target allows it.
    * Makefile.in (coverage.o): Depend on $(TARGET_H).

    * gcc.dg/tree-prof/pr52150.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/tree-prof/pr52150.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/Makefile.in
    trunk/gcc/coverage.c
    trunk/gcc/testsuite/ChangeLog

[Bug gcov-profile/52150] [4.7 regression] junk at end of line in Firefox PGO build

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52150

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-08 13:39:09 UTC ---
Fixed.