[Bug libstdc++/52191] New: abi_check should flag additions to released versions

[Bug libstdc++/52191] New: abi_check should flag additions to released versions

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52191

             Bug #: 52191
           Summary: abi_check should flag additions to released versions
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ro@gcc.gnu.org
                CC: bkoz@gcc.gnu.org


When regenerating the Solaris libstdc++ baselines, I noticed that there were
several additions to already release/closed symbol versions:

  http://gcc.gnu.org/ml/gcc-patches/2012-01/msg01163.html

Provided that the baselines for the various targets are updated immediately
before
releases, abi_check should be able to flag such additions since they are
obviously
not supposed to happen.  This is certainly far better than noticing the problem
only by accident/manual inspection or, even worse, only after another major
release has happened.

Ben, do you think this is feasible?

Thanks.
  Rainer

[Bug libstdc++/52191] abi_check should flag additions to released versions

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52191

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-02-10
     Ever Confirmed|0                           |1
           Severity|normal                      |enhancement

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-02-10 11:12:54 UTC ---
Confirmed.  That would be indeed very nice to have.

[Bug libstdc++/52191] abi_check should flag additions to released versions

[bkoz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52191

--- Comment #2 from Benjamin Kosnik <bkoz at gcc dot gnu.org> 2012-02-28 20:21:13 UTC ---
Created attachment 26774
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26774
patch to check new symbols are in new version names

[Bug libstdc++/52191] abi_check should flag additions to released versions

[bkoz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52191

Benjamin Kosnik <bkoz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

--- Comment #3 from Benjamin Kosnik <bkoz at gcc dot gnu.org> 2012-02-28 20:23:50 UTC ---

Hey Ranier. This is as you requested. 

I expect you'll notice the new symbols now on solaris. I believe the new
symbols should be conditionalized such that they are added in linux in the
older version names, and on solaris in the new symbol names. Working on that
now but prompt testresults from solaris with this patch (and the new fail) will
be appreciated.



-benjamin

[Bug libstdc++/52191] abi_check should flag additions to released versions

[bkoz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52191

--- Comment #4 from Benjamin Kosnik <bkoz at gcc dot gnu.org> 2012-02-28 20:25:53 UTC ---
Author: bkoz
Date: Tue Feb 28 20:25:48 2012
New Revision: 184639

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=184639
Log:
2012-02-21  Benjamin Kosnik  <bkoz@redhat.com>

    PR libstdc++/52191
    * testsuite/util/testsuite_abi.cc (compare_symbols): Check new
    symbols added into the latest version. Mark tls entities as
    undesignated.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/testsuite/util/testsuite_abi.cc

[Bug libstdc++/52191] abi_check should flag additions to released versions

[bkoz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52191

Benjamin Kosnik <bkoz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot       |bkoz at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.7.0

--- Comment #5 from Benjamin Kosnik <bkoz at gcc dot gnu.org> 2012-02-29 23:25:26 UTC ---

Ranier, can you revisit your initial email, with the symbol changes and the
abi_check changes?

http://gcc.gnu.org/ml/gcc-patches/2012-01/msg01163.html

It seems to me that all that needs doing is to conditionalize the newly-added
symbols on solaris such that

  1). they are added into GLIBCXX_3.4.17 on solaris
  2). they remain in the same version name on linux

If you will give me an accurate list of new symbols on solaris (say from a
abi_check log) it would be useful.

thanks,
Benjamin

[Bug libstdc++/52191] abi_check should flag additions to released versions

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52191

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.7.0                       |4.7.1

--- Comment #6 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-03-22 08:26:23 UTC ---
GCC 4.7.0 is being released, adjusting target milestone.

[Bug libstdc++/52191] abi_check should flag additions to released versions

[bkoz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52191

Benjamin Kosnik <bkoz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|4.7.1                       |4.7.0

--- Comment #7 from Benjamin Kosnik <bkoz at gcc dot gnu.org> 2012-05-02 22:48:24 UTC ---

Ooops, correcting this. It is fixed in 4.7.0, and by happen-stance no
additional complexity is required for solaris.