From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7821 invoked by alias); 14 Feb 2012 22:05:36 -0000 Received: (qmail 7809 invoked by uid 22791); 14 Feb 2012 22:05:35 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,TW_AV,TW_VF X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Feb 2012 22:05:21 +0000 From: "ebotcazou at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/52205] unwinding through signal handler fails Date: Tue, 14 Feb 2012 22:05:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: ebotcazou at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: ebotcazou at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-02/txt/msg01480.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52205 --- Comment #9 from Eric Botcazou 2012-02-14 22:04:35 UTC --- > I'm currently doing so, and preliminary results look good. I've got a > couple of comments on the patch as-is which I find harder than necessary > to read/understand: > > * It uses far too magic numbers unnecessarily and/or without > explanation. E.g. looking for the caller frame with hardcoded offsets > (cuh_patter, sah_address) is unnecessary: just use struct frame in > for that, where fr_savfp is the saved frame pointer at > that exact offset. > > * All the patterns should be acompanied by the disassembly to make it > easier to compare with that you see e.g. in a debugger. > > * Talking of Solaris 8 in Solaris Containers is unnecessary and > incomplete: this is just the Solaris 8 alternate thread library (in > /usr/lib/lwp) which is copied over /usr/lib/libthread.so.1 when > booting the branded zone, but is also used by gcc on Solaris 8 by > default. This alternate thread library became the default in Solaris > 9, thus they are the same. Fine with me (I won't make any of these changes myself though).