public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ro at CeBiTec dot Uni-Bielefeld.DE" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/52205] unwinding through signal handler fails
Date: Tue, 14 Feb 2012 18:39:00 -0000 [thread overview]
Message-ID: <bug-52205-4-vopdFoFuPe@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-52205-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52205
--- Comment #8 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2012-02-14 18:39:32 UTC ---
> --- Comment #6 from Ian Lance Taylor <ian at airs dot com> 2012-02-12 19:52:02 UTC ---
> The patch fixes the test case and also passes some relevant Go tests.
>
> Rainer, if OK, I'd like to leave it to you to comment on the patch and do a
> full testsuite run.
I'm currently doing so, and preliminary results look good. I've got a
couple of comments on the patch as-is which I find harder than necessary
to read/understand:
* It uses far too magic numbers unnecessarily and/or without
explanation. E.g. looking for the caller frame with hardcoded offsets
(cuh_patter, sah_address) is unnecessary: just use struct frame in
<sys/frame.h> for that, where fr_savfp is the saved frame pointer at
that exact offset.
* All the patterns should be acompanied by the disassembly to make it
easier to compare with that you see e.g. in a debugger.
* Talking of Solaris 8 in Solaris Containers is unnecessary and
incomplete: this is just the Solaris 8 alternate thread library (in
/usr/lib/lwp) which is copied over /usr/lib/libthread.so.1 when
booting the branded zone, but is also used by gcc on Solaris 8 by
default. This alternate thread library became the default in Solaris
9, thus they are the same.
Rainer
next prev parent reply other threads:[~2012-02-14 18:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 23:32 [Bug target/52205] New: SPARC Solaris 2.11 unwind through signal handler fails with -fnon-call-exceptions ian at airs dot com
2012-02-10 23:37 ` [Bug target/52205] " pinskia at gcc dot gnu.org
2012-02-11 10:48 ` ebotcazou at gcc dot gnu.org
2012-02-12 4:13 ` ian at airs dot com
2012-02-12 10:07 ` ebotcazou at gcc dot gnu.org
2012-02-12 15:33 ` ebotcazou at gcc dot gnu.org
2012-02-12 19:53 ` ian at airs dot com
2012-02-12 20:25 ` ebotcazou at gcc dot gnu.org
2012-02-14 18:39 ` ro at CeBiTec dot Uni-Bielefeld.DE [this message]
2012-02-14 22:05 ` [Bug target/52205] unwinding through signal handler fails ebotcazou at gcc dot gnu.org
2012-02-15 8:15 ` ebotcazou at gcc dot gnu.org
2012-02-15 8:17 ` ebotcazou at gcc dot gnu.org
2012-02-15 8:22 ` ebotcazou at gcc dot gnu.org
2012-02-16 19:54 ` ro at CeBiTec dot Uni-Bielefeld.DE
2012-05-26 13:56 ` ebotcazou at gcc dot gnu.org
2012-05-26 14:12 ` ebotcazou at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-52205-4-vopdFoFuPe@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).