From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-383652-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 7929 invoked by alias); 15 Feb 2012 21:34:03 -0000
Received: (qmail 7653 invoked by uid 22791); 15 Feb 2012 21:34:02 -0000
X-SWARE-Spam-Status: No, hits=-2.7 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00,TW_EG
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Feb 2012 21:33:15 +0000
From: "jojelino at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libffi/52221] [libffi] r183675,r184021 needs to be fixed.
Date: Wed, 15 Feb 2012 21:43:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libffi
X-Bugzilla-Keywords:
X-Bugzilla-Severity: blocker
X-Bugzilla-Who: jojelino at gmail dot com
X-Bugzilla-Status: WAITING
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: Summary Severity
Message-ID: <bug-52221-4-Vil5klGt3V@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-52221-4@http.gcc.gnu.org/bugzilla/>
References: <bug-52221-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2012-02/txt/msg01586.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52221

gee <jojelino at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[libffi] r184021 needs to   |[libffi] r183675,r184021
                   |be fixed.                   |needs to be fixed.
           Severity|normal                      |blocker

--- Comment #7 from gee <jojelino at gmail dot com> 2012-02-15 21:32:10 UTC ---
there is an big mistake in r183675

-      ffi_call_win32(ffi_prep_args_raw, &ecif, cif->bytes, cif->flags,
-                     ecif.rvalue, fn);
+      ffi_call_win32(ffi_prep_args, &ecif, cif->abi, cif->bytes, cif->flags,
+             ecif.rvalue, fn);

and below the mistake, another one.

+    if (passed_regs < 2 && abi == FFI_FASTCALL)
+      abi = FFI_THISCALL;
+    if (passed_regs < 1 && abi == FFI_THISCALL)
+      abi = FFI_STDCALL;
+        ffi_call_win32(ffi_prep_args, &ecif, abi, cif->bytes, cif->flags,
+                       ecif.rvalue, fn);
+      }

why ffi_prep_args_raw changed to ffi_prep_args?? this explains why i succeed
but not sigsegving in ExtraClassLoader.
because of this, i decidec to raise the severity to blocker.