public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ktietz at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libffi/52221] [libffi] r183675,r184021 needs to be fixed.
Date: Thu, 16 Feb 2012 21:01:00 -0000	[thread overview]
Message-ID: <bug-52221-4-mZjXiRdfKH@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-52221-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52221

--- Comment #10 from Kai Tietz <ktietz at gcc dot gnu.org> 2012-02-16 20:37:28 UTC ---
I see here three issues about this patch.

First, you don't treat stack-alignment.
Second, why you emulate here stack-argument cleanup for ret __size-4?  Why not
stick to already present variant?
Thirs, you corrupt arguments after the second.

That this patch works for you might be true, but it is for sure in general
wrong.


  parent reply	other threads:[~2012-02-16 21:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-12 17:22 [Bug libffi/52221] New: [libffi] r184021 " jojelino at gmail dot com
2012-02-12 17:58 ` [Bug libffi/52221] " ktietz at gcc dot gnu.org
2012-02-13 15:18 ` ktietz at gcc dot gnu.org
2012-02-13 15:19 ` ktietz at gcc dot gnu.org
2012-02-13 17:02 ` jojelino at gmail dot com
2012-02-13 18:35 ` jojelino at gmail dot com
2012-02-13 21:06 ` ktietz at gcc dot gnu.org
2012-02-15 21:43 ` [Bug libffi/52221] [libffi] r183675,r184021 " jojelino at gmail dot com
2012-02-16 20:20 ` jojelino at gmail dot com
2012-02-16 21:01 ` ktietz at gcc dot gnu.org [this message]
2012-02-16 21:06 ` jojelino at gmail dot com
2012-02-16 23:35 ` jojelino at gmail dot com
2012-02-17  8:39 ` jojelino at gmail dot com
2012-02-17  9:07 ` ktietz at gcc dot gnu.org
2012-02-22 18:23 ` jojelino at gmail dot com
2012-02-23 21:04 ` ktietz at gcc dot gnu.org
2012-02-23 21:28 ` ktietz at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-52221-4-mZjXiRdfKH@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).