From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27492 invoked by alias); 16 Feb 2012 21:01:03 -0000 Received: (qmail 27482 invoked by uid 22791); 16 Feb 2012 21:01:02 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Feb 2012 21:00:38 +0000 From: "ktietz at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug libffi/52221] [libffi] r183675,r184021 needs to be fixed. Date: Thu, 16 Feb 2012 21:01:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libffi X-Bugzilla-Keywords: X-Bugzilla-Severity: blocker X-Bugzilla-Who: ktietz at gcc dot gnu.org X-Bugzilla-Status: WAITING X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-02/txt/msg01731.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52221 --- Comment #10 from Kai Tietz 2012-02-16 20:37:28 UTC --- I see here three issues about this patch. First, you don't treat stack-alignment. Second, why you emulate here stack-argument cleanup for ret __size-4? Why not stick to already present variant? Thirs, you corrupt arguments after the second. That this patch works for you might be true, but it is for sure in general wrong.