* [Bug libffi/52223] [4.5/4.6/4.7 Regression] libffi's man page install breaks with multilibs and overridden mandir
2012-02-13 0:09 [Bug libffi/52223] New: [4.5,4.6,4.7 regression] libffi's man page install breaks with multilibs and overridden mandir mikpe at it dot uu.se
@ 2012-02-13 11:17 ` rguenth at gcc dot gnu.org
2012-02-13 14:07 ` mikpe at it dot uu.se
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-02-13 11:17 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52223
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |WAITING
Last reconfirmed| |2012-02-13
Target Milestone|--- |4.5.4
Summary|[4.5,4.6,4.7 regression] |[4.5/4.6/4.7 Regression]
|libffi's man page install |libffi's man page install
|breaks with multilibs and |breaks with multilibs and
|overridden mandir |overridden mandir
Ever Confirmed|0 |1
--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-02-13 11:17:21 UTC ---
I think you should always use DESTDIR instead of setting prefix or mandir
at install time.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libffi/52223] [4.5/4.6/4.7 Regression] libffi's man page install breaks with multilibs and overridden mandir
2012-02-13 0:09 [Bug libffi/52223] New: [4.5,4.6,4.7 regression] libffi's man page install breaks with multilibs and overridden mandir mikpe at it dot uu.se
2012-02-13 11:17 ` [Bug libffi/52223] [4.5/4.6/4.7 Regression] " rguenth at gcc dot gnu.org
@ 2012-02-13 14:07 ` mikpe at it dot uu.se
2012-02-13 16:50 ` joseph at codesourcery dot com
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: mikpe at it dot uu.se @ 2012-02-13 14:07 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52223
Mikael Pettersson <mikpe at it dot uu.se> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |RESOLVED
Resolution| |INVALID
--- Comment #2 from Mikael Pettersson <mikpe at it dot uu.se> 2012-02-13 14:07:15 UTC ---
"make DESTDIR=... install" does work, and it's documented. "make prefix=...
mandir=... install" doesn't seem to be documented, so presumably this was a
procedural error I inherited from Fedora's gcc spec file, sigh.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libffi/52223] [4.5/4.6/4.7 Regression] libffi's man page install breaks with multilibs and overridden mandir
2012-02-13 0:09 [Bug libffi/52223] New: [4.5,4.6,4.7 regression] libffi's man page install breaks with multilibs and overridden mandir mikpe at it dot uu.se
2012-02-13 11:17 ` [Bug libffi/52223] [4.5/4.6/4.7 Regression] " rguenth at gcc dot gnu.org
2012-02-13 14:07 ` mikpe at it dot uu.se
@ 2012-02-13 16:50 ` joseph at codesourcery dot com
2012-02-13 19:15 ` mikpe at it dot uu.se
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: joseph at codesourcery dot com @ 2012-02-13 16:50 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52223
--- Comment #3 from joseph at codesourcery dot com <joseph at codesourcery dot com> 2012-02-13 16:50:17 UTC ---
This ought to work. Does applying the fix I discuss in
<http://gcc.gnu.org/ml/gcc-patches/2011-09/msg01187.html> - setting
FLAGS_TO_PASS = $(AM_MAKEFLAGS) in Makefile.am - for libffi help here?
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libffi/52223] [4.5/4.6/4.7 Regression] libffi's man page install breaks with multilibs and overridden mandir
2012-02-13 0:09 [Bug libffi/52223] New: [4.5,4.6,4.7 regression] libffi's man page install breaks with multilibs and overridden mandir mikpe at it dot uu.se
` (2 preceding siblings ...)
2012-02-13 16:50 ` joseph at codesourcery dot com
@ 2012-02-13 19:15 ` mikpe at it dot uu.se
2012-02-19 11:10 ` mikpe at it dot uu.se
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: mikpe at it dot uu.se @ 2012-02-13 19:15 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52223
--- Comment #4 from Mikael Pettersson <mikpe at it dot uu.se> 2012-02-13 19:15:07 UTC ---
(In reply to comment #3)
> This ought to work. Does applying the fix I discuss in
> <http://gcc.gnu.org/ml/gcc-patches/2011-09/msg01187.html> - setting
> FLAGS_TO_PASS = $(AM_MAKEFLAGS) in Makefile.am - for libffi help here?
Yes, with that applied overriding mandir at install does work.
I had to adapt the patch a little, this is what I tested:
--- gcc-4.7-20120211/libffi/Makefile.am.~1~
+++ gcc-4.7-20120211/libffi/Makefile.am
@@ -76,6 +76,9 @@ AM_MAKEFLAGS = \
"RANLIB=$(RANLIB)" \
"DESTDIR=$(DESTDIR)"
+# Subdir rules rely on $(FLAGS_TO_PASS)
+FLAGS_TO_PASS = $(AM_MAKEFLAGS)
+
MAKEOVERRIDES=
toolexeclib_LTLIBRARIES = libffi.la
--- gcc-4.7-20120211/libffi/Makefile.in.~1~
+++ gcc-4.7-20120211/libffi/Makefile.in
@@ -455,6 +455,8 @@ AM_MAKEFLAGS = \
"RANLIB=$(RANLIB)" \
"DESTDIR=$(DESTDIR)"
+# Subdir rules rely on $(FLAGS_TO_PASS)
+FLAGS_TO_PASS = $(AM_MAKEFLAGS)
MAKEOVERRIDES =
toolexeclib_LTLIBRARIES = libffi.la
noinst_LTLIBRARIES = libffi_convenience.la
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libffi/52223] [4.5/4.6/4.7 Regression] libffi's man page install breaks with multilibs and overridden mandir
2012-02-13 0:09 [Bug libffi/52223] New: [4.5,4.6,4.7 regression] libffi's man page install breaks with multilibs and overridden mandir mikpe at it dot uu.se
` (3 preceding siblings ...)
2012-02-13 19:15 ` mikpe at it dot uu.se
@ 2012-02-19 11:10 ` mikpe at it dot uu.se
2012-02-22 15:07 ` jakub at gcc dot gnu.org
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: mikpe at it dot uu.se @ 2012-02-19 11:10 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52223
Mikael Pettersson <mikpe at it dot uu.se> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|INVALID |
--- Comment #5 from Mikael Pettersson <mikpe at it dot uu.se> 2012-02-19 10:16:09 UTC ---
Reopening, since Joseph's comment and analogous patch for libquadmath implies
that this is in fact expected to work.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libffi/52223] [4.5/4.6/4.7 Regression] libffi's man page install breaks with multilibs and overridden mandir
2012-02-13 0:09 [Bug libffi/52223] New: [4.5,4.6,4.7 regression] libffi's man page install breaks with multilibs and overridden mandir mikpe at it dot uu.se
` (4 preceding siblings ...)
2012-02-19 11:10 ` mikpe at it dot uu.se
@ 2012-02-22 15:07 ` jakub at gcc dot gnu.org
2012-02-23 13:00 ` mikpe at it dot uu.se
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-02-22 15:07 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52223
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-22 15:03:34 UTC ---
(In reply to comment #4)
> (In reply to comment #3)
> > This ought to work. Does applying the fix I discuss in
> > <http://gcc.gnu.org/ml/gcc-patches/2011-09/msg01187.html> - setting
> > FLAGS_TO_PASS = $(AM_MAKEFLAGS) in Makefile.am - for libffi help here?
>
> Yes, with that applied overriding mandir at install does work.
>
> I had to adapt the patch a little, this is what I tested:
>
> --- gcc-4.7-20120211/libffi/Makefile.am.~1~
> +++ gcc-4.7-20120211/libffi/Makefile.am
> @@ -76,6 +76,9 @@ AM_MAKEFLAGS = \
> "RANLIB=$(RANLIB)" \
> "DESTDIR=$(DESTDIR)"
>
> +# Subdir rules rely on $(FLAGS_TO_PASS)
> +FLAGS_TO_PASS = $(AM_MAKEFLAGS)
> +
> MAKEOVERRIDES=
>
> toolexeclib_LTLIBRARIES = libffi.la
> --- gcc-4.7-20120211/libffi/Makefile.in.~1~
> +++ gcc-4.7-20120211/libffi/Makefile.in
> @@ -455,6 +455,8 @@ AM_MAKEFLAGS = \
> "RANLIB=$(RANLIB)" \
> "DESTDIR=$(DESTDIR)"
>
> +# Subdir rules rely on $(FLAGS_TO_PASS)
> +FLAGS_TO_PASS = $(AM_MAKEFLAGS)
> MAKEOVERRIDES =
> toolexeclib_LTLIBRARIES = libffi.la
> noinst_LTLIBRARIES = libffi_convenience.la
Are you going to post this to gcc-patches? Please CC the build maintainers.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libffi/52223] [4.5/4.6/4.7 Regression] libffi's man page install breaks with multilibs and overridden mandir
2012-02-13 0:09 [Bug libffi/52223] New: [4.5,4.6,4.7 regression] libffi's man page install breaks with multilibs and overridden mandir mikpe at it dot uu.se
` (5 preceding siblings ...)
2012-02-22 15:07 ` jakub at gcc dot gnu.org
@ 2012-02-23 13:00 ` mikpe at it dot uu.se
2012-02-27 10:01 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: mikpe at it dot uu.se @ 2012-02-23 13:00 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52223
--- Comment #7 from Mikael Pettersson <mikpe at it dot uu.se> 2012-02-23 12:47:33 UTC ---
Patch has been posted:
http://gcc.gnu.org/ml/gcc-patches/2012-02/msg01173.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libffi/52223] [4.5/4.6/4.7 Regression] libffi's man page install breaks with multilibs and overridden mandir
2012-02-13 0:09 [Bug libffi/52223] New: [4.5,4.6,4.7 regression] libffi's man page install breaks with multilibs and overridden mandir mikpe at it dot uu.se
` (6 preceding siblings ...)
2012-02-23 13:00 ` mikpe at it dot uu.se
@ 2012-02-27 10:01 ` jakub at gcc dot gnu.org
2012-02-27 10:07 ` [Bug libffi/52223] [4.5/4.6 " jakub at gcc dot gnu.org
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-02-27 10:01 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52223
--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-27 10:00:22 UTC ---
Author: jakub
Date: Mon Feb 27 10:00:12 2012
New Revision: 184592
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=184592
Log:
PR libffi/52223
* Makefile.am (FLAGS_TO_PASS): Define.
* Makefile.in: Regenerate.
Modified:
trunk/libffi/ChangeLog
trunk/libffi/Makefile.am
trunk/libffi/Makefile.in
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libffi/52223] [4.5/4.6 Regression] libffi's man page install breaks with multilibs and overridden mandir
2012-02-13 0:09 [Bug libffi/52223] New: [4.5,4.6,4.7 regression] libffi's man page install breaks with multilibs and overridden mandir mikpe at it dot uu.se
` (7 preceding siblings ...)
2012-02-27 10:01 ` jakub at gcc dot gnu.org
@ 2012-02-27 10:07 ` jakub at gcc dot gnu.org
2012-06-20 13:16 ` rguenth at gcc dot gnu.org
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-02-27 10:07 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52223
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[4.5/4.6/4.7 Regression] |[4.5/4.6 Regression]
|libffi's man page install |libffi's man page install
|breaks with multilibs and |breaks with multilibs and
|overridden mandir |overridden mandir
--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-27 10:05:58 UTC ---
Fixed on the trunk so far.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libffi/52223] [4.5/4.6 Regression] libffi's man page install breaks with multilibs and overridden mandir
2012-02-13 0:09 [Bug libffi/52223] New: [4.5,4.6,4.7 regression] libffi's man page install breaks with multilibs and overridden mandir mikpe at it dot uu.se
` (8 preceding siblings ...)
2012-02-27 10:07 ` [Bug libffi/52223] [4.5/4.6 " jakub at gcc dot gnu.org
@ 2012-06-20 13:16 ` rguenth at gcc dot gnu.org
2012-06-20 13:17 ` rguenth at gcc dot gnu.org
2012-06-20 13:17 ` rguenth at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-06-20 13:16 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52223
--- Comment #10 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-20 13:16:43 UTC ---
Author: rguenth
Date: Wed Jun 20 13:16:35 2012
New Revision: 188830
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188830
Log:
2012-06-20 Richard Guenther <rguenther@suse.de>
Backport from mainline
2012-02-27 Mikael Pettersson <mikpe@it.uu.se>
PR libffi/52223
* Makefile.am (FLAGS_TO_PASS): Define.
* Makefile.in: Regenerate.
Modified:
branches/gcc-4_5-branch/libffi/ChangeLog
branches/gcc-4_5-branch/libffi/Makefile.am
branches/gcc-4_5-branch/libffi/Makefile.in
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libffi/52223] [4.5/4.6 Regression] libffi's man page install breaks with multilibs and overridden mandir
2012-02-13 0:09 [Bug libffi/52223] New: [4.5,4.6,4.7 regression] libffi's man page install breaks with multilibs and overridden mandir mikpe at it dot uu.se
` (9 preceding siblings ...)
2012-06-20 13:16 ` rguenth at gcc dot gnu.org
@ 2012-06-20 13:17 ` rguenth at gcc dot gnu.org
2012-06-20 13:17 ` rguenth at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-06-20 13:17 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52223
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
Status|REOPENED |RESOLVED
Resolution| |FIXED
--- Comment #10 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-20 13:16:43 UTC ---
Author: rguenth
Date: Wed Jun 20 13:16:35 2012
New Revision: 188830
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188830
Log:
2012-06-20 Richard Guenther <rguenther@suse.de>
Backport from mainline
2012-02-27 Mikael Pettersson <mikpe@it.uu.se>
PR libffi/52223
* Makefile.am (FLAGS_TO_PASS): Define.
* Makefile.in: Regenerate.
Modified:
branches/gcc-4_5-branch/libffi/ChangeLog
branches/gcc-4_5-branch/libffi/Makefile.am
branches/gcc-4_5-branch/libffi/Makefile.in
--- Comment #11 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-20 13:16:54 UTC ---
Fixed.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug libffi/52223] [4.5/4.6 Regression] libffi's man page install breaks with multilibs and overridden mandir
2012-02-13 0:09 [Bug libffi/52223] New: [4.5,4.6,4.7 regression] libffi's man page install breaks with multilibs and overridden mandir mikpe at it dot uu.se
` (10 preceding siblings ...)
2012-06-20 13:17 ` rguenth at gcc dot gnu.org
@ 2012-06-20 13:17 ` rguenth at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-06-20 13:17 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52223
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
Status|REOPENED |RESOLVED
Resolution| |FIXED
--- Comment #11 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-20 13:16:54 UTC ---
Fixed.
^ permalink raw reply [flat|nested] 13+ messages in thread