[Bug web/52228] New: Bugzilla: Missing link for "PR...."

[Bug web/52228] New: Bugzilla: Missing link for "PR...."

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228

             Bug #: 52228
           Summary: Bugzilla: Missing link for "PR...."
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: web
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: burnus@gcc.gnu.org
                CC: LpSolit@netscape.net


In the following line, the second PR is not linkified - only the first one:

   cf. PR49733/PR25829

   cf. PR 49733/PR 25829

I think it works with bug:

  cf. bug49733/bug25829
  cf. bug 49733/bug 25829
  cf. bug #49733/bug #25829

[Bug web/52228] Bugzilla: Missing link for "PR...."

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-02-13
     Ever Confirmed|0                           |1

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-02-13 11:11:08 UTC ---
Confirmed.

[Bug web/52228] Bugzilla: Missing link for "PR...."

[LpSolit at netscape dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228

Frédéric Buclin <LpSolit at netscape dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |LpSolit at netscape dot net
                   |gnu.org                     |
           Severity|normal                      |minor

--- Comment #2 from Frédéric Buclin <LpSolit at netscape dot net> 2012-02-13 15:29:25 UTC ---
My regexp explicitly forbirds / right before PR.... but I cannot remember why:

  qr/(?<!\/)\b(pr(?:\s*|\s+\S+\/)(\d+)(?:\s+comment\s+(\d+))?)/i

I will drop this restriction, but will bring it back if it appears there was a
good reason to do so. :)

[Bug web/52228] Bugzilla: Missing link for "PR...."

[LpSolit at netscape dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228

Frédéric Buclin <LpSolit at netscape dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Frédéric Buclin <LpSolit at netscape dot net> 2012-02-13 15:31:48 UTC ---
Note to self: I didn't update the tarball with this change.

[Bug web/52228] Bugzilla: Missing link for "PR...."

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-02-13 15:39:57 UTC ---
(In reply to comment #2)
> My regexp explicitly forbirds / right before PR.... but I cannot remember why

maybe so it doesn't catch external links like http://sourceware.org/PR123 ?

[Bug web/52228] Bugzilla: Missing link for "PR...."

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-02-13 15:40:36 UTC ---
(In reply to comment #4)
> (In reply to comment #2)
> > My regexp explicitly forbirds / right before PR.... but I cannot remember why
> 
> maybe so it doesn't catch external links like http://sourceware.org/0 ?

yeah, that'll be it :)  that was entered as sourceware.org / P R 1 2 3 (without
spaces) and got mangled

[Bug web/52228] Bugzilla: Missing link for "PR...."

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-02-13 15:44:21 UTC ---
as shown at http://gcc.gnu.org/ml/gcc-bugs/2012-02/msg01317.html

[Bug web/52228] Bugzilla: Missing link for "PR...."

[LpSolit at netscape dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228

Frédéric Buclin <LpSolit at netscape dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |ASSIGNED
         Resolution|FIXED                       |

--- Comment #7 from Frédéric Buclin <LpSolit at netscape dot net> 2012-02-13 15:59:50 UTC ---
(In reply to comment #5)
> yeah, that'll be it :)

Ah, right! That was the reason I explicitly excluded / right before PR. So I
guess the problem described in comment 0 is minor enough to let it unfixed. Any
objection?

[Bug web/52228] Bugzilla: Missing link for "PR...."

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #8 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-02-13 16:17:21 UTC ---
(In reply to comment #2)
> My regexp explicitly forbirds / right before PR.... but I cannot remember why:
>   qr/(?<!\/)\b(pr(?:\s*|\s+\S+\/)(\d+)(?:\s+comment\s+(\d+))?)/i
> I will drop this restriction, but will bring it back if it appears there was a
> good reason to do so. :)

Best would be a pattern, which only prohibits "http(s):"[nonwhitespace]/PR".


(In reply to comment #7)
> Ah, right! That was the reason I explicitly excluded / right before PR. So I
> guess the problem described in comment 0 is minor enough to let it unfixed. Any
> objection?

For the issue of comment 0, allowing "[0-9]/PR" should probably be safe.
However, one also finds:  "middle-end/PR1234" (for those which mistype "PR
middle-end/1234").

Regarding comment 0, how about such a pattern:

qr/(?<!\D/)\b(pr(?:\s*|\s+\S+\/)(\d+)(?:\s+comment\s+(\d+))?)/i
       ^^

Plus a comment, which explains why one has that pattern ...

[Bug web/52228] Bugzilla: Missing link for "PR...."

[LpSolit at netscape dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228

--- Comment #9 from Frédéric Buclin <LpSolit at netscape dot net> 2012-02-13 16:24:20 UTC ---
(In reply to comment #8)
> Regarding comment 0, how about such a pattern:
> 
> qr/(?<!\D/)\b(pr(?:\s*|\s+\S+\/)(\d+)(?:\s+comment\s+(\d+))?)/i

This is just a hack. Not a good idea.


> Best would be a pattern, which only prohibits "http(s):"[nonwhitespace]/PR".

Of course, but negative look-behind assertions only accept fixed-width strings.
Else I would simply look for :// in the string. I have a workaround which I'm
discussing upstream.

[Bug web/52228] Bugzilla: Missing link for "PR...."

[LpSolit at netscape dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228

Frédéric Buclin <LpSolit at netscape dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Frédéric Buclin <LpSolit at netscape dot net> 2012-02-13 17:51:21 UTC ---
Here we go!